so when cider is not connected the icon would be:

when connected but never evaluated nothing or there is something being evaluated it would be:

and when connected and nothing evaluating/something was already evaluated:

I managed to make almost everything work using cider-connected-hook , cider-disconnected-hook , cider-mode-hook and cider-file-loaded-hook , but the latter is not totally reliable for the intermediate state

it'd be nice to have a pre-hook when cider is evaluating something and a pos-hook when it finished evaluated or it's cancelled

BTW this already work on doom-emacs without the intermediate state, I made it some months ago My modeline:

WDYT @bozhidar? if you agree, would you accept an PR adding those hooks?

I see the hooks beeing important not for just modeline but anyone that would want to add some kind of UX feedback of cider state :)

I thought these books existed and the spinner package was used for this

AFAIK the spinner is used only for lsp-mode

it seems cider has spinner indeed, but I never see it working, maybe doom disables it?

I think it's related with the spinner running on the repl buffer, and the repl buffer has no modeline

I managed to manually call cider code on my buffer and only this way works:

ah we use spinner in CIDER but it's hardcoded with no hooks

https://github.com/clojure-emacs/cider/blob/master/cider-client.el#L207

yeah I saw that, but even so I never saw this spinner working, does it always work for you @U11BV7MTK? I suspect doom-emacs does something that hides it

and the stop messages: • https://github.com/clojure-emacs/cider/blob/master/cider-connection.el#L159 • https://github.com/clojure-emacs/cider/blob/master/cider-debug.el#L349 • https://github.com/clojure-emacs/cider/blob/master/cider-client.el#L94

been a while since i've used CIDER actually but yes it always worked

you can check the value of the var cider-show-eval-spinner

if doom sets this to nil it will never show

I see, so probably a doom-emacs thing, anyway, I still think the hooks would improve how other can extend this behavior

100% agree on the hooks

it's true, I checked it

I checked every variable related to the spinner, all are on the default value 🤷

only thing i can think of is there are packages that dimish things in the modeline and i bet they are getting swept up in that

but i forgot what its called

might actuall be called diminish

maybe diminished-mode-alist

I have no variable or function with dimi as prefix :thinking_face:

hmm. i bet there's another package that achieves the same thing. anything that claims to clean up the modeline. but this is all speculation

yeah, it makes sense

actually, doom-modeline is built-in on doom-emacs: https://github.com/hlissner/doom-emacs/blob/develop/modules/ui/modeline/+light.el I remember I coded there adding that cider repl icon

but most doom-emacs people use the main modeline: https://github.com/seagle0128/doom-modeline I already used both and saw people using both, and never saw that spinner

if you turn off modeline-mode does it show up when you eval?

the modeline becomes huge 😂 I can't even know if it works

but I suspect it's there....

😂 yeah.. I'm used to keep only on the notebook without any extra monitor :man-shrugging:

14"

you'll need to kill some minor modes and hopefully it shows up

haha. i guess proving the point of why its so useful lol

Cleaned some minor modes, but no spinner:

its still not clear to me that you can see all of them

i don't see any space indicating the list has ended

using the mouse can you click on them and choose which ones to see?

I think the repl one was the last, I cleaned some more:

Yeah, I actually wrote that code @U8QBZBHGD 😅

this whole conversation was to have some hooks from cider to improve it even more :)

if you do (require 'spinner) and then (spinner-start) do you see it now?

i also see this in spinner.el:

(unless (and (listp mode-line-process)
                 (memq 'spinner--mode-line-construct mode-line-process))
      (setq mode-line-process
            (list (or mode-line-process "")
                  'spinner--mode-line-construct)))

check those constraints? mode-line-process. although i guess that's just adding it to the list and ensuring not to re-add it

yes, running that works

this show the cider spinner corectly:

(spinner-start cider-eval-spinner-type nil
                     cider-eval-spinner-delay)

but that's the question, why it's not activating automatically

anyway, thanks for the help @U11BV7MTK, I'd still like to have my repl icon instead of the spinner

i'm gonna look into this: maybe spinner start isn't built into all interactive eval handlers?

right. i agree. but my thinking is that the places where spinner calls are would be the place to swap in the hooks and have spinner as the default on the hook

yes, agree

so once spinner works for you you'll know that your change works when the spinner keeps working on the hook, and then unhook it and set your own icon on the hook and it'll almost 100% work

another thing to check, is define dummy functions for spinner-start and stop that just message "i was called and started" or whatever and see if CIDER is failing to call or spinner is failing to render

good idea, let me try

yeah, cider-spinner-start is being called for sure

probably the buffer it's wrong, it's the repl one, not the active buffer where I'm coding :)

well that's frustrating

oh maybe! i haven't seen CIDER in a while so i'm not actually sure which buffer lol

with a hook, I'll be able to listen to the hook on other buffers

and you'll dabble a toe into the waters of multiple connections and figuring out which repl buffer is connected

that's an area where the workspace style editors are far easier: intellij and vs code. There aren't multiple projects open at once

yeah haha, I used the simple one https://github.com/hlissner/doom-emacs/blob/develop/modules/lang/clojure/config.el#L105

yes, but that's one of the things I like emacs, I don't need multiple emacs :p

agree. i really like that about emacs. but it does make that particular problem harder

for sure

actually one thing i don't like about lsp. I often look into lots of other projects and that spins up lsp servers just by looking at a clj file. i wish it was opt in per proejct

i have to remember to lsp-workspace-shutdown if i go look at clojure source code or core.match, etc

yeah, unless you opened the buffer from the current workspace which will open in a cache emacs folder using the same session, it will connect another session indeed

yikes

yeah, maybe we could improve that on lsp-mode somehow

anyway, I'll go to bed now, thank you for the help and chat @U11BV7MTK @U8QBZBHGD

Thanks one long thread! @UKFSJSM38 all sorts of improvements are more than welcome. 🙂

I also also thinking it'd be nice to have some indication about whether a ns was evaluated or not, etc, but never got to doing those.

Thanks! I'll try to open a PR adding those hooks so :)

Btw, what are you using to see the variable values in the minibuffer? That looks cool!

That's another thing we can do for CIDER as well, although I'm not sure how it will look for bigger values. 😄

Haha, it's from doom-emacs I guess It uses ivy via shortcut SPC h vshowing all variables and it's values

Hmm, I used ivy for years and I never knew it could do this. Oh, well... 😄

Haha :man-shrugging: maybe some doom magic as well

@bozhidar just checking. does this assume anything about anyone writing an .nrepl-port file?

No, it just assumes that you write the port to the terminal, the same wait that Lein does it.

@bozhidar cool. lein:

nREPL server started on port 63373 on host 127.0.0.1

$ bb nrepl-server
Started nREPL server at 127.0.0.1:1667
For more info visit: 

there is some code here that accounts for this: https://github.com/babashka/babashka/wiki/GNU-Emacs

nbb does it the way lein does (this time we could fix it in time)

Just wanted to point you at the bb-jack-in @U07FP7QJ0 showed me a while ago. https://gist.github.com/plexus/5c27d643853c791685cede8b24fb854b#file-03_user_config-el-L35

Yeah, it's trivial to have a dedicated command, but if we assume that most babashka projects use bb.edn, I think it makes more sense to make cider-jack-in-clj aware of babashka (which is what I did), than to introduce one more set of commands. Obviously with Emacs we always have infinite possibilities. 🙂

Nothing comes to mind, however if the issue is flaky, perhaps tools.deps own caching .cpcache is into play

this can happen if you are using local deps

cache will not be recomputed if those change

(but I am working on a fix for this!)

Doubt this is an issue but FYI you can specify aliases directly with cider-clojure-cli-aliases, instead of sending them as global options.

One project contains a local dep, but it was never a local dep I had issues with

Well it would be something transitive from a local dep so could be about anything

You should be able to fix it by using clj -Sforce from the command line (+ any aliases)

No seems to be a cider issue. Ran into it again a couple of times and the jack in command does not contain the aliases.

cider-clojure-cli-global-options seem to be nil in that case

@UE1N3HAJH Unfortunately only :indents and :alias-maps are currently supported. We'd need to change both cider--nrepl-format-code-request-map from cider-client.el in Cider code, and at least format-code-reply in Cider-nREPL code.

Thanks @U8T05KBEW I thought as much. I may make a PR if I get around to it.