Fork me on GitHub
#cider
<
2021-04-13
>
bozhidar07:04:57

@srijayanth I think it might be handy to just add a project-level configuration variable that can be used to specify the project root ns. People would be able to use it in case the inference doesn’t work properly for one reason or another.

craftybones07:04:56

That could work, though I am still surprised this isn’t working. The env property user.dir is set correctly

craftybones07:04:04

so it is set to project root

bozhidar07:04:09

Hmm, so I guess it’s something else. Might be a good idea to debug what’s happening exactly when you run the command. I’m on the road this week and my ability to debug anything is quite limited right now. You can also file a GH issue, so we won’t forget about this.

vemv08:04:54

Sounds good if I try to fix the https://github.com/clojure-emacs/refactor-nrepl build? No overlap w/ someone else?

❤️ 3
bozhidar08:04:53

@vemv Definitely! It’s safe to say that refactor-nrepl has been getting very little love lately, so it’s extremely unlikely to run into conflicts with anyone there. 🙂

vemv08:04:53

cider ! Nice, I have some possible improvements to propose, especially cljr-slash perf improvements

👍 3
yuhan09:04:38

That would be awesome :) cljr-slash is probably the most useful command in the library, but it causes a 1-2 second lag every time I use it on a fully qualified namespace.

vemv09:04:07

1-2? you're lucky ;p I reduced it to 1-2 from ~8 or so, don't remember exactly the numbers. I have ~900 .clj files in my largest work project (oc it's also faster in non-humongous projects)

😱 3
vemv09:04:00

> every time I use it on a fully qualified namespace good observation, this is part of my plan. there's a few edge cases where cljr-slash should be a no-op, which is the best possible optimization ^^

yuhan10:04:08

looking forward to it!

yuhan10:04:54

Looks like it also triggers on fractions like 1/2, but that might be better fixed on the emacs package

5
blak3mill3r20:04:07

Slightly tricky, the fractions... however the fact that symbols in Clojure cannot start with a number at least makes it possible to parse without backtracking

blak3mill3r20:04:51

I love cljr-slash and the rest of refactor-nrepl ... but I disabled it a while ago because of some combination of lag and suspicion of buggy interactions 😞

richiardiandrea04:04:09

Thank you for fixing!

bozhidar05:04:55

@UCPS050BV @vemv One more thing to consider in case you want to hack on refactor-nrepl and clj-refactor - a while ago we’ve decided to move the most useful parts of both of them that are not tied to the analyzer to clojure-mode/CIDER to simplify the maintenance and the setup. We didn’t do much on the front - basically our biggest achievement was move a bunch of simple refactoring functions to clojure-mode, but I hope we’ll revisit this down the road.

👍 6
Rusty Shackleford19:04:58

Hi all, is there a ready-made way to cider-connect to a running nREPL that does not have the cider middleware already loaded, and then inject that middleware dynamically, i.e. without having to alter the original code that exposes the nREPL? My use-case: I'd like to hack around on clojure-lsp, which will start a "vanilla" nREPL instance if built with a debug flag. So I've built it locally with that flag, configured lsp-mode to use that build, fired up Emacs and lsp-mode, retrieved the port number the nREPL is exposing, and then would like to use Cider for debugging etc. as I mess around with the code. But when I cider-connect to the running nREPL I get WARNING: CIDER requires cider-nrepl to be fully functional. Some features will not be available without it! If I'm reading the docs correctly, I believe I can add cider-nrepl to the project's deps.edn, find the code that starts the repl and add some parameters to include the cider middleware at startup, then rebuild, but I'm wondering if there's a built-in way to do this on the fly? Reading through the nrepl docs, it looks like it does expose a wrap-dynamic-loader function that could do this, but I've having trouble putting all the pieces together for how that might be invoked directly from Cider (somewhat new to Clojure, coming from Java-land).