Fork me on GitHub
#cider
<
2019-06-19
>
bozhidar05:06:26

@d.ian.b Looks like you hit some bug in emidje or whatever middleware is providing this op.

bozhidar05:06:07

@benedek Seems like some regression in the recent commits (I’m thinking it is probably https://github.com/clojure-emacs/refactor-nrepl/commit/916b55445d2a700c85bb57efb73b6fd98a2d653a)

bozhidar05:06:00

We had forgotten to bump the version of clj-refactor.el to snapshot and when I did this I had to also push a new snapshot of the middleware to match it, which revealed the problem.

bozhidar05:06:45

@kingcode I’m sorry to hear about your painful upgrade experience. 0.15 -> 0.21 represents a couple of years of development, plus the big switch to the new nREPL. Generally it’s a good idea to always stick to the latest CIDER and avoid such big upgrades. I also plan to address this to some extent by adding some upgrade notes for the different releases.

benedek06:06:38

thanks @bozhidar for looking into it

benedek07:06:19

yeah could have. wonder how the tests passed tho?!

bozhidar07:06:23

Me too. Maybe they didn’t cover the part the blew up?

benedek07:06:31

yeah plausible explanation ;)

kingcode13:06:10

@bozhidar Oh no apologies needed! I love your work and everything Cider :) Actually it took only about an hour to recover from the upgrade, and I only need to set up a few key bindings...Looking forward to discovering the new version! Thank you!

bozhidar13:06:00

You’re welcome! I guess a good starting point would be https://github.com/clojure-emacs/cider/blob/master/CHANGELOG.md

kingcode13:06:10

As said above, my own troubles had to do with dependencies relying on the old tools.nrepl - this will get easier in the future

bozhidar13:06:30

Yep, this was a one time thing and it’s not going to happen again.

Ian Fernandez13:06:06

how can I make cider jack-in ask for a profile before jack-in?

kingcode13:06:06

Thank you Bozhidar, I will make sure to read this up, sorry for not doing that first (in a bit of a crunch) - thanks for your fantastic work!

bozhidar13:06:05

@d.ian.b Just use C-u before the jack-in command.

Ian Fernandez13:06:53

I'm using this, but I want some command to detect if lein, if deps, if boot, ask for profile

Ian Fernandez13:06:02

in the jack-in

Ian Fernandez13:06:11

maybe I'll make this haha

Ian Fernandez13:06:33

I'm learning some of elisp

bozhidar13:06:56

We had this in the early version of CIDER, but it was removed in favour of a more generic way to customize the jack-in command.

bozhidar13:06:26

Otherwise it was a slippery slope if we started to add different prefixes or commands for everything someone might want to alter.

bozhidar13:06:18

And I see to recall that not every tool had the notion of a profile, which also made it problematic to support such thing out of the box.

bozhidar13:06:29

Adding a small local wrapper should be trivial.

Ian Fernandez17:06:35

aw, understood, thanks