This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2018-10-26
Channels
- # 100-days-of-code (1)
- # aleph (4)
- # beginners (112)
- # boot (2)
- # business (4)
- # calva (3)
- # cider (37)
- # clara (26)
- # cljs-dev (6)
- # cljsrn (1)
- # clojars (4)
- # clojure (89)
- # clojure-brasil (1)
- # clojure-conj (1)
- # clojure-dev (81)
- # clojure-dusseldorf (8)
- # clojure-italy (41)
- # clojure-nl (3)
- # clojure-spec (11)
- # clojure-uk (14)
- # clojurescript (73)
- # cursive (1)
- # data-science (3)
- # datomic (2)
- # dirac (9)
- # duct (6)
- # emacs (4)
- # figwheel-main (1)
- # fulcro (47)
- # incanter (3)
- # jobs-discuss (43)
- # leiningen (18)
- # luminus (6)
- # lumo (4)
- # mount (4)
- # off-topic (31)
- # portkey (8)
- # protorepl (5)
- # re-frame (9)
- # reagent (15)
- # reitit (2)
- # ring-swagger (7)
- # shadow-cljs (28)
- # specter (4)
- # tools-deps (8)
- # uncomplicate (1)
@pri OK, so I think it’d be really best for you to file a ticket where we track this. The chat is a poor medium for this.
@bozhidar My clojure-mode version is 20181005.452
, and the Sesman issue is still there. Alright, I'll try to dig a little more to report the precise issue.
@dominicm @bozhidar Regarding boot repl
, there are two things I've hit so far.
1. boot repl
correctly loads data readers, cider.tasks/nrepl-server
doesn't seem to. Hence, for example, the debugger doesn't work (missing dbg
reader).
2. I'm used to "patching" the default repl
task with custom logic, e.g. compiling Java before starting the REPL. I guess, this one is on me, and is easily fixed by patching the cider.tasks/nrepl-server
task as well, but I guess this still makes it a breaking behavior enough to mention in the changelog.
> 1. boot repl
correctly loads data readers, cider.tasks/nrepl-server
doesn’t seem to. Hence, for example, the debugger doesn’t work (missing dbg
reader).
I assume that’s not hard to fix, right? I’ve never used boot, this was all @richiardiandrea’s show so far and I hear he moved away from boot as well. 🙂 I guess we should at least open a ticket to track this.
Yep not using boot anymore but can look into that, I am not officially surprised about how many things the boot repl task is doing 😃
> 2. I’m used to “patching” the default repl
task with custom logic, e.g. compiling Java before starting the REPL. I guess, this one is on me, and is easily fixed by patching the cider.tasks/nrepl-server
task as well, but I guess this still makes it a breaking behavior enough to mention in the changelog. (edited)
Re boot #1. I think the fix should be simple. I'll also take a look.
If you need help regarding the Boot stuff, feel free to ping me in PRs more liberally, can't promise many contributions but would at least alpha-test.
We use Boot exclusively.
@alexyakushev what do you mean patching? Normally I just have a task like javac, and then I compose the tasks.
Either that, or boot.core/replace-task!
In any case, we relied on CIDER calling boot repl
specifically.
It's no big problem to switch to another one, but the change came as a surprise.
I see. That's not a strategy I've really seen. I don't think relying on cider calling a particular function is part of the API contract.
@alexyakushev At any rate - I’ve updated the changelog and I plan to tweak a bit the docs related to jack-in
later.
Btw, I haven’t forgotten about the compliment bump as well, but I was hoping to cut a new cider-nrepl
release soon and the snapshot version of compliment
would be an issue for this.
Likely the test failures are just some Travis flakiness. I’m getting more and more frustrated with Travis, but I don’t have time to move the build to Circle.
That PR fails with JDK 10 quite reliably, but I can't explain that
Works with JDK11, but other cljs stuff fails then
It is a snapshot only because it wasn't tested globally yet, but it doesn't change anything besides JDK9+ handling.
If we could merge the snapshot and use for ~1 week, we would follow with the releases of compliment and new cider-nrepl
@alexyakushev Can you only remove the Java 10 change or change this to 11?
@bozhidar I didn't quite get what you mean
@alexyakushev There’s a commit changing Java 9 to 10.
> Can you only remove the Java 10 change or change this to 11? Then some other CIDER cljs stuff fails.
Are you OK with that?
Anyway, did exactly that
@alexyakushev I’ve pushed a new snapshot. The cljs failures are unrelated. I hope we’ll address those eventually.