Fork me on GitHub
#cider
<
2018-03-24
>
richiardiandrea03:03:57

That's an awesome quote !

stardiviner06:03:58

Weird, today I try to jack-in out side of Clojure project. cider-jack-in does not go to jack-in outside of project, it warning with Unsupported project type 'clojure' Because in my buffer, variable cider-default-repl-command becomes "clojure". but it is not in cider--identify-buildtools-present. Maybe because CIDER upgrade issue.

stardiviner06:03:11

This might be an issue.

stardiviner06:03:35

Seems cider-project-type does not handle the situation that does not have a project.

bozhidar10:03:48

@stardiviner Recently I renamed this to “clojure-cli”, as “clojure” was a very generic name and the code references to it in CIDER were confusing even me, who wrote that code. 😄

bozhidar10:03:28

@xiongtx 😄 😄 😄 Fine by me!

dominicm10:03:01

@bozhidar I think @alexmiller identified "clojure tools" or something as the preferred naming. I don't reall though.

bozhidar10:03:53

That sound a bit generic too me as well, but I guess anything is better than just naming this “clojure”.

👍 1
stardiviner10:03:04

@bozhidar I have to custom the variable cider-default-repl-command to clojure. And after yesterday upgrade of CIDER, I check out code, it already has new cider-project-type. But cider-jack-in outside of project still did not match cider-project-type condition match in function cider-jack-in. I think might a missing handling on "out side of project" ? you might can take a test.

stardiviner10:03:37

s/I have to/I have not/

dominicm10:03:08

Worth asking him I think, and double checking. Would be good to be consistent.

bozhidar10:03:55

@stardiviner Maybe I renamed one thing too many. I’ll check when I have some time. You can file some ticket with repro steps for your problem so I won’t forget about it. Too many things are happening lately, and I deal with them way more hastily and carelessly than I’d like to.

stardiviner10:03:15

@bozhidar Sure. post an issue on CIDER GitHub repo?

stardiviner10:03:43

Thank you for your work on CIDER, I like it so much.

bozhidar11:03:29

The issue is fixed. I was mislead by the name of this variable, which in the past was really a default command, but now it’s created as a default project-type for some reason.

bozhidar11:03:41

This will need a real fix, but I it will have to wait.

stardiviner12:03:41

:thumbsup::skin-tone-2: