Fork me on GitHub
#cider
<
2018-03-16
>
bozhidar00:03:01

@gonewest818 I recall macroexpand was enriching eval somewhere. The debugging middleware was doing something similar.

bozhidar00:03:01

Basically the important thing when enriching an existing middleware is to make sure the different middleware gets applied in the right order, which you specify in the middleware descriptor.

gonewest81800:03:33

Yes, I eventually found inspect, thanks. I am not 100% sure of the wrap- macro but I’ll work from the example and see how much I can pick up.

bozhidar00:03:16

@pri most likely the lein executable is not on Emacs’s exec path. However, if you’re getting something about lein in a boot project that’s pretty puzzling. Why did you decide to customize the boot command instead of the generic command or whatever?

bozhidar00:03:08

> I was under the impression that it reevaluated every function in the buffer, no? @iwannaseethelight It works differently - compiles the entire file, doesn’t care about the functions in it.

iwannaseethelight00:03:15

Do you mean that it compiles the file but that functions in it won’t be re-instrumented?

bozhidar02:03:36

Frankly, I don’t remember the implementation details in the debugger. I just know that evaluating forms and entire buffers is implemented differently in nREPL.

bozhidar00:03:06

@jumblemuddle In theory the connection dispatch should work transparently based on the project you’re in and the type of the file you’re editing, but with static dispatch you can just select explicitly which connection to use.

pri00:03:00

@bozhidar as mentioned in my question, i'm not using boot or lein (a new mac or ubuntu installation) and testing via a fresh emacs + clojure-mode + inf-clojure + nodejs setup. As of now, I'm able to connect to lumo's socket repl via lumo -n 5555 by running M-x inf-clojure-connect, and a repl opens up in a new buffer; however I can't evaluate or load the form in the source file; in cider I'd normally evaluate via C-x e or C-c C-k.

bozhidar02:03:58

Probably inf-clojure-minor-mode is not setup or something like that. Those keybindings are coming from it.

bozhidar02:03:47

But to start lumo directly with inf-clojure you’d normally modify the generic command (which is not project-specific. Don’t recall the name of the exact variable.

bozhidar02:03:32

I assume you don’t have this in your config (add-hook 'clojure-mode-hook #'inf-clojure-minor-mode).

bozhidar02:03:54

Just keep in mind that this is going to interfere with cider-mode, so be careful with this.

bozhidar02:03:54

Maybe we should add to inf-clojure something like CIDER’s functionality to enable its minor mode automatically when started.

richiardiandrea04:03:58

We can also redirect questions to #inf-clojure if appropriate 😉

richiardiandrea04:03:01

I use the above every day so I can help with that and yes it cannot cohexist with cider-mode

bozhidar10:03:13

Probably there should be a warning if you enable both of them, otherwise some people might be extremely confused.

benedek12:03:52

@gonewest818 doing a PR in orchard and it seems the CHANGELOG is a bit out of place

benedek12:03:01

is it there by accident?

gonewest81814:03:37

@benedek isn’t that just what the lein new foo template produces?

benedek14:03:53

hehe could be

benedek14:03:09

perhaps should be removed if not used?

benedek14:03:54

i naively added a line in the PR have not even looked what it contains until @bozhidar pointed out that it is completely out of place

gonewest81814:03:26

or could change the placeholder text to make it more obvious it’s to be filled in?

benedek14:03:44

well, could be i guess, as orchard has not been released yet ever

gonewest81814:03:08

So the first release could be a single bullet, a “we split out functionality & migrated here” kind of thing, or could try to be more of an inventory exactly what. For now I would suggest just the one liner.

benedek14:03:59

yeah one liner would be deffo more easy

bozhidar15:03:59

I’d change this to something meaningful. Changelogs are useful.

bozhidar15:03:09

cider-nrepl could also benefit from one (finally).

mikerod21:03:07

Anyone used cider-test-run-ns-tests and then in the *cider-test-report* buffer tried to do the d diff option? When I do it it doesn’t give me a useful diff.

mikerod21:03:04

basically, I have a test like:

(t/is (= foo (run-thing bar)))

the diff compares
"expected buffer"
(t/is (= foo (run-thing bar)))

"actual buffer"
(= <foo-evaled> <fn-result-evaled>)

mikerod21:03:08

It is like it is trying to use the actual test code form as the expected and the evaled stuff as the actual. not comparing the args across the =