Fork me on GitHub
#cider
<
2018-03-01
>
bozhidar01:03:30

@stardiviner I see you already got an answer for this question. 🙂

stardiviner04:03:47

Yes, problem found, I will start to fix this issue soon. Thanks for catch on my question.

dpsutton06:03:10

@bozhidar missed a use of cider-cljs-repl-types when you renamed so current CIDER won't work for people ^

manuel07:03:16

sorry, I opened an issue before reading that was already reported here.

bozhidar11:03:08

@dpsutton Thanks for fixing my mess. I just noticed I actually forgot to update the that pcase completely, and because of this there would be no startup messages. I’ll fix that as well. I should have tested this again after renaming the constant. 🙂

hkjels12:03:49

it seems like cider-format-buffer uses cljfmt, but it does not respect the preferences set in profile.clj. Are there any settings of cider-format-buffer I’m not seeing?

hkjels12:03:30

It also loses point-position which is really annoying

bozhidar12:03:13

Which version of CIDER are you using? @xiongtx fixed recently the issue with the lost buffer position.

hkjels17:03:14

point was persisted when I updated to 17-snapshot. It doesn’t work if you have the same file open in multiple buffers though. Probably fixed in a similar way that I posted earlier

bozhidar12:03:34

> it seems like cider-format-buffer uses cljfmt, but it does not respect the preferences set in profile.clj. Are there any settings of cider-format-buffer I’m not seeing?

bozhidar12:03:48

Those are settings for the lein plugin, so it’s hard for CIDER to process them. Might be nice to expose those via CIDER itself.

qqq13:03:29

Is there a way to (on a individual basis) /ignore the github bot ? 🙂 I click on the "bold" cider channel, thinking there is an interesting discussion; but then find it impossible to read due to every other third msg being the github bot.

gganley14:03:51

I just looked through the GitHub config on my slack workspace, it is all or nothing

gganley14:03:04

you can’t say “I would only like commit messages and no other messages”

gganley14:03:30

There could easily be a #cider-gh but that may be more fragmentation then some folks would like

dpsutton14:03:21

i doubt bohzidar wants to annoy people. the hope was to expose issues and what PRs look like. if this goal isn't being achieved we can remove. i thought the traffic had died down from the initial onslaught and hopefully it was closer to achieving that goal.

gganley14:03:14

Speaking for myself I like having the accepted merges but the comments gets tiresome

dpsutton14:03:11

yeah i agree. I think he tried to turns those off. its unfortunate that it seems to not allow issues and PRs only

dpsutton14:03:01

but certainly comments are welcome @qqq and if the general opinion seems to be for turning them off we will. I have an email for each one of these notifications anyways. was hoping for new eyes and contributors

gganley14:03:14

We could forego the Slack integration and just use a custom thing using http://zapier.com just saying

dpsutton14:03:50

never heard of that

gganley14:03:00

Oh dear lord it’s the coolest thing

gganley14:03:06

it’s like IFTTT on HGH

dpsutton14:03:03

that's a lot of acronyms haha

gganley14:03:48

I had that thought last night, some things sound really unapproachable when you say them outloud

gganley14:03:56

like I play a game called League of Legends

gganley14:03:19

and someone used the phrase “low cooldown mini ghost” and I realized how ludicrous that sounds

dpsutton14:03:10

my girlfriend plays counter strike and i hear a lot of strange phrases come out about being lit from nades

bozhidar16:03:58

I’ve disabled the comments, now what’s shown are commits open/closed PRs and issues.

bozhidar16:03:26

If people think that’s annoying I’ll just disable this completely.

qqq16:03:53

@bozhidar: perhaps my slack client is misconfigured, but this is what it looked like with the github bot on:, where the purple/pink = slack human comments https://imgur.com/a/G0KXI

dpsutton16:03:08

that's what we all see. those are issues and PRs.

bozhidar17:03:04

I’ll kill this integration now. No need to waste more time discussing it.

qqq17:03:56

Perhaps this is more appropraite for #off-topic , but if slack allowed each user to have their own /ignore list, it'd also solve this problem. In particular, it's not people here discussing the github issues but the github bot itself that I want to ignore.

qqq17:03:21

https://www.quora.com/Is-there-a-way-to-ignore-certain-users-in-Slack <-- apparently they don't want to implement it since slack is for 'team communications'

gganley17:03:53

I don’t get why we don’t just stuff it into a #cider-notifications or #cider-gh channel

gganley17:03:27

Like for my personal slack workspace I have a channel called #commits

qqq17:03:58

1. I would not subscribe to #cider-notifications / #cider-gh -- I don't think many others would busbscribe to it. 2. I think the original goal was to have people in slack discuss github pull requests / comments / ...

gganley17:03:13

Oh I wouldn’t sub I would check in on it

gganley17:03:30

Like I don’t get notifications for any channels, only DM’s

gganley17:03:46

But thinking on it I shouldn’t assume everyone sets it up the same way as myself

qqq17:03:07

Hmm, from that perspective, the github bot (even though I dislike it) would make a lot of sense. 1. people put alot more effort into a github pull request than a #cider queston 2. so if we are willing to discuss random #ceer questions in #cider, they why not also discuss pull-requests (where the author has actually put in the effort to write elisp code) from this perspective, the github notifcations (atleast for pr-requests, not sure abou comments), make complete sense; it's just not clear how to do it without being disruptive

qqq17:03:03

yeah, #cider, not sure how I managed to type ceer

qqq17:03:48

here is another weird thought experiment: case A: for every pull request, the author of the PR manually came here and posted a msg saying "here is my pull request, it does XYZ, would love feedback" case B: the exact msg is posted by github bot for whatever reason, case A = would be great, case B = annoying

gganley17:03:09

I guess I’m used to it but IMO seeing only new PR’s and new issues is my ideal situation

gganley17:03:24

but I guess that’s because I don’t allow any channel to give me “unread” markers

gganley17:03:52

It is my understand that it is preferable to have the PR discussion on GitHub

gganley18:03:08

So maybe a bot that literally messages in the following format

gganley18:03:55

CiderBot: title of PR by Author join the discussion! link to PR

gganley18:03:22

because if you look at the way the bot formats it there is so much boilerplate

qqq18:03:20

@gganley: I think you are on to something with the boilerplate someone runs into an issue: posts it here on #cider : we are all happy to help someone runs into an issue; posts the exact same issue to github; and the github bot posts it here: we all get out pitchforks so for whatever reason, possibly due to formatting, github bot posts = makes people annoyed

gganley18:03:30

Bots are friends, not monsters

gganley18:03:40

I for one…

gganley18:03:24

Like I mentioned it earlier but anything from IFTTT to zapier could do this and we would have a lot more fine control over it

gganley18:03:36

hell zapier allows you the vomit Node.js onto it

sonnyto20:03:01

how do I connect to clojure 1.8 socket repl from cider?

sonnyto20:03:11

seems cider can only connect to nrepl

richiardiandrea22:03:07

Socket repl support is not straightforward to get with the current nRepl + bencode middleware. I guess once orchard is stable and prepl is in..it will be supported