Fork me on GitHub
#cider
<
2017-11-16
>
drewverlee00:11:32

does cider require you to be connected to the internet to work?

grzm01:11:36

I've got a POC for fixing the boot/cider-expected-ns issue: it looks like it's actually in cider-nrepl (what get's returned from cider-sync-request:classpath): https://github.com/grzm/cider-nrepl/commit/4fe4a7021835a5cd2305a9a322c412b8bbd24c05

benedek11:11:30

@grzm wonder if this is not similar or related to this https://github.com/clojure-emacs/refactor-nrepl/issues/97

benedek11:11:33

I think it is and was fixed for some use cases in refactor-nrepl

grzm16:11:45

@benedek Yeah, I think that's addressing the same issue. I think it might be fixed at the wrong level here, as I think this is something that should be shared by all nrepl user, rather than fixed per-user, e.g., in cider-nrepl rather in refactor-nrepl and cider.

dominicm16:11:23

@grzm there's a few bits of cider that's in both cider-nrepl and refactor-nrepl around handling boot, it's mostly copy & paste.

dominicm16:11:31

It could go into a library, but it's hard to beat copy & paste.

grzm16:11:54

@dominicm I'd argue that that copy-and-paste misses a lot of use cases and duplicates code, requiring more places to fix as code is updated. That in particular bit me here.

benedek16:11:58

well the midterm goal is to merge refactor-nrepl into cider-nrepl

benedek16:11:11

which will kill these annoying duplications

benedek16:11:29

only I don't have time to work on this merge

grzm16:11:51

well, this would be a start of some it it 🙂

grzm17:11:48

@benedek Is there an open ticket or wiki page or other reference related to merging refactor-nrepl into cider-nrepl?

benedek22:11:25

@grzm not really. quite a bit of discussion about it on gitter i think. this issue is kinda related (https://github.com/clojure-emacs/refactor-nrepl/issues/195) as would make sense to rewrite/make the analyzer part more robust to support cljs