Fork me on GitHub
#cider
<
2017-09-20
>
oskarkv16:09:03

@bozhidar Should I create an issue for this PR? I don't think there was one. https://github.com/clojure-emacs/cider/pull/2086

dpsutton16:09:10

i suppose so. it would also be nice to include some screenshots of before and after

dpsutton16:09:37

when you make your final commit, you can squash all your stuff down into one and preface it with [bug#]: ....

dpsutton16:09:50

this way people can easily find discussion, screenshots, etc

dpsutton16:09:28

its not super cod to nsistent and there seems to be no open issue on this so i'm surprised he's holding to this. its possible he wants to make it more consistently tied to open issues or perhaps he's confused this with the fontlocking issue about namespace/function-name

dpsutton16:09:39

either way, thanks for the contrib!

dpsutton16:09:54

and i think the screenshots would be of value so i'd just make the issue 🙂

dpsutton17:09:43

just saw. nice

dpsutton17:09:03

i haven't looked into your code change, but presumably it recognizes functions in general?

dpsutton17:09:21

like (def func (partial func-a 2)) and the like?

dpsutton17:09:39

will this be your first contribution?

dpsutton17:09:01

do you think you would like to write up some notes about how you tested things?

dpsutton17:09:12

like what seemed weird, what took you a while to figure out , etc

dpsutton17:09:31

either about the issue you worked on or about setting up cider/cider-nrepl to test and poke things?

dpsutton17:09:58

if you feel like it throw up a md file on https://github.com/clojure-emacs/hackingcider

oskarkv17:09:05

It took me a while to figure out where the code i needed was, but then I read the article about debugging, and the repl-toggle-messages, or whatever, led me to the right place

dpsutton17:09:22

no pressure to do it either way, but if you think others looking to get involved might benefit from what you learned, I'm a big fan of lowering barrier to entry 🙂

dpsutton17:09:33

either way i'm glad you took the time and made CIDER better

dpsutton17:09:54

i'm glad you found those articles useful

oskarkv17:09:58

No problem

dpsutton17:09:10

feel free to PR those particular articles as well if you think they could be more clear

oskarkv17:09:48

I would like an article about how to debug a CLJS environment with cider-nrepl

oskarkv17:09:22

I spit some debug messages because I couldn't figure out any better way

oskarkv17:09:38

or maybe I should have said

oskarkv17:09:48

How to debug cider-nrepl for cljs

dpsutton17:09:59

i don't know the answer to that question

dpsutton17:09:24

but it may involve that ^

oskarkv17:09:42

Hm, I see another problem with the colors 😛

oskarkv17:09:14

I turned off clojure-mode's font locking

oskarkv17:09:21

but partial is not green... hmm

oskarkv17:09:48

It's just in that position, after def

oskarkv17:09:18

Maybe I didn't turn off everything from clojure-mode... I just emptied clojure-font-lock-keywords

dpsutton17:09:54

are you jacked in?

oskarkv17:09:06

A-fn and + are green 😛

oskarkv17:09:24

If I enter something before partial, partial turns green

oskarkv18:09:28

I found a clue

oskarkv18:09:36

If I comment out all the code in cider--parse-and-apply-locals then partial becomes green.

dpsutton18:09:06

oh god, those locals get confusing. useful but really tough to reason about

oskarkv18:09:31

It looks for def just to be short

oskarkv18:09:53

It sould look for defn and defmacro, I think

oskarkv18:09:12

Gotta read more carefully

oskarkv19:09:41

I solved it...

oskarkv19:09:13

But what about other things that are like def 😞

oskarkv19:09:31

defconst for example. It's not in clojure.core but I have defined it 😛

oskarkv19:09:49

I really need forks of everything and merge in new updates instead of downloading from melpa 😛

oskarkv19:09:25

But I get an annoying message all the time when I do that

dpsutton19:09:34

what do you mean?

oskarkv19:09:59

About forks?

oskarkv19:09:36

I mean I should load all my emacs plugins from git repos instead of downloading them automatically from melpa

oskarkv19:09:02

That way it's much easier to manage personal changes

oskarkv19:09:26

But I get some error annoying warning message when I do that

oskarkv19:09:31

Gotta get rid of that

dpsutton19:09:44

ahhhhh yeah

dpsutton19:09:47

what warning?

oskarkv19:09:04

Let's see...

oskarkv19:09:26

Hm, not getting it now... 😛

oskarkv19:09:22

Oh, yeah, here

oskarkv19:09:53

"The local variables list in ... contains values that may not be safe"

oskarkv19:09:57

Googling...

oskarkv19:09:13

Too tired for that right now 😛

dpsutton19:09:22

it sucks when there's so many things moving at the same time

dpsutton19:09:43

when what you need to do is conceptually easy but 5 small, easy things are all difficult to do