2022-11-09 cherry | Clojure Slack Archive

cherry 2022-11-09

borkdude 2022-11-09T11:55:50.532749Z

alex 2022-11-09T18:16:19.830469Z

EDIT: Will post to GH issues I have the following do! macro that wraps individual exprs in js/await. When I have greater than ~20 expressions in the body of the do!, the compiler throws an error

(defmacro do!
  [& exprs]
  `(do
     ~@(map (fn [expr#] `(js/await ~expr#)) exprs)))

;; usage
(do!
  (first-async-fn)
  ...
  (twentieth-async-fn))

file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/cli.js:483
arguments[18],arguments[19],arguments[20],arguments[21]);default:throw Error(["Invalid arity: ",$APP.v.h(arguments.length-1)].join(""));}};$APP.g.apply=function(a,b){return this.call.apply(this,[this].concat($APP.ib(b)))};$APP.g.v=function(){var a=$APP.w(this);return a.v?a.v():a.call(null)};$APP.g.h=function(a){var b=$APP.w(this);return b.h?b.h(a):b.call(null,a)};$APP.g.g=function(a,b){var c=$APP.w(this);return c.g?c.g(a,b):c.call(null,a,b)};

Error: Invalid arity: 23
    at VQ.$APP.g.call (file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/cli.js:483:72)
    at VQ.$APP.g.apply (file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/cli.js:483:184)
    at Xg (file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/cljs_core.js:551:491)
    at Wg (file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/cljs_core.js:547:70)
    at Ug (file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/cljs_core.js:546:421)
    at Function.$APP.Ch.B (file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/cljs_core.js:793:404)
    at file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/compiler.js:587:258
    at file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/compiler.js:588:267
    at $APP.kr.$APP.g.g (file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/compiler.js:213:289)
    at file:///Users/alex/code/icebreaker/ui_tests/node_modules/cherry-cljs/lib/compiler.js:185:206

I'm able to work around this issue by wrapping a subset of the expressions (to get under ~20) into their own functions and invoking them i.e.

(do!
  (^:async (fn []
    (do!
      (first-async-fn)
      ...
      (tenth-async-fn)))
  (^:async (fn []
      (eleventh-async-fn)
      ...
      (twentieth-async-fn)))))

borkdude 2022-11-09T18:18:12.114919Z

Issue welcome. Might be something in SCI

✅ 1

alex 2022-11-09T18:24:43.793709Z

Is = & other comparators not supported yet?

(= 1 1)

 1) [chromium] › cherry_playwright.spec.mjs:422:19 › stage host controls ==========================

    ReferenceError: _EQ_ is not defined

    > 444 | (await _EQ_.call(null, 1, 1));

borkdude 2022-11-09T18:25:08.908009Z

ehm.... should be...

borkdude 2022-11-09T18:25:41.048299Z

I can repro the problem:

$ ./node_cli.js -e '(= 1 2)'
file:///Users/borkdude/dev/cherry/.tmpQ1aZ4r/cherry.mjs:1
_EQ_.call(null, 1, 2);
^

Issue welcome, will fix tonight

✅ 1

borkdude 2022-11-09T18:26:08.302389Z

I think this is a recent regression

alex 2022-11-09T18:41:14.167299Z

Gotcha. Maybe from the aliases stuff I was doing? I definitely could have messed something up...

borkdude 2022-11-09T19:03:44.510819Z

No worries :) I don't think it's anything you changed, and even if it was, there should have been a test catching this

borkdude 2022-11-09T19:06:27.704199Z

It seems like an advanced compilation issue

borkdude 2022-11-09T20:01:52.133739Z

https://clojurians.slack.com/archives/C03S1L9DN/p1668023765627519

borkdude 2022-11-09T20:33:31.372259Z

So it seems it's an issue with shadow-cljs

borkdude 2022-11-09T21:36:07.529539Z

@rahx1t both 78 and 79 are now fixed and published to npm

alex 2022-11-09T22:00:51.931919Z

Thank you! that's interesting re: "EQ" and "=" conflict re: 78, I am still getting the same invalid arity issue after installing alpha59

borkdude 2022-11-09T22:05:46.867419Z

hm ok, I'll try again tomorrow

borkdude 2022-11-09T22:07:47.302649Z

I've encountered this issue before. The issue is that a function with metadata implements some protocol and protocol implementations can't have more than 20 arguments

borkdude 2022-11-09T22:08:35.155189Z

but if you unwrap this function, using the .-afn field, you get the normal function which does support more than 20 args and this is what I've tried. This fix worked in SCI before, but I'll re-test it tomorrow

💡 1

borkdude 2022-11-09T22:12:43.104699Z

Here is a repro in cljs:

ClojureScript 1.10.914
cljs.user=>   (def f (fn [x & xs]))
#'cljs.user/f
cljs.user=> (apply f (range 30))
nil
cljs.user=>   (def f (with-meta (fn f [x & xs]) {}))
#'cljs.user/f
cljs.user=> (apply f (range 30))
Execution error (Error) at (<cljs repl>:1).
Invalid arity: 30

borkdude 2022-11-09T22:12:59.835749Z

This is what I do to work around it:

cljs.user=> (apply (.-afn f) (range 30))
nil

borkdude 2022-11-09T22:13:09.466699Z

and this should have worked in 59, but I'm not sure why it didn't

alex 2022-11-09T22:30:49.938419Z

What would be considered the function w/ metadata in this macro?

(defmacro do!
  [& exprs]
  `(do
     ~@(map (fn [expr#] `(js/await ~expr#)) exprs)))

borkdude 2022-11-09T22:32:51.077949Z

In SCI, macros are functions with metadata, namely {:macro true}

💡 1

borkdude 2022-11-09T22:33:36.223749Z

I'll take another look tomorrow 💤

alex 2022-11-09T22:33:58.565289Z

No rush. I have the wrap-them-in-a-fn workaround 🙂 Ty!

Clojurians Log v2

cherry 2022-11-09