Dear Calva friends: calva https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.564
• https://github.com/BetterThanTomorrow/calva/issues/3117
• Fix: https://github.com/BetterThanTomorrow/calva/issues/3125
• Fix: https://github.com/BetterThanTomorrow/calva/issues/3095
• Rename ‘Toggle Line Comment’ to ‘Toggle Comment’
• Current form takes #_ commented forms at all cursor positions within the form
◦ Fix: https://github.com/BetterThanTomorrow/calva/issues/3108
◦ Fix: No longer treat #_ discarded ns forms as namespace declarations
Thanks to @doppiaelle1999, @jonurnieta, and https://github.com/marco-carvalho for the help with improving Calva! 🙏 ❤️ gratitude
I think there might be a performance regression in this release. I updated to it and was trying to work on next.jdbc.result-set and every time I did anything navigation that went backward, or tried to backspace, it hung up for several seconds (the {} in the status line next to Clojure showed a spinning icon).
I reverted to 2.0.563 and the same operations were instantaneous.
I'll do some more experiments over the weekend to make sure I can repro, and will report back.
Wow, that's awful. Thanks for reporting!
Yeah, I can absolutely repro this...
Clone next.jdbc, open up test/next/jdbc_test.clj and go to line 1138, put your cursor as shown here:
{:multi-rs true|})
Press backspace three times. For me, that deletes the e and then hangs up for a while, then deletes the u and r.
Undo those three backspaces and see how long it takes for the error annotation to go away (and the file tab to turn back from red to yellow).
Now install 2.0.563, reload, let everything start up and settle to zero CPU. Now repeat the scenario above: no hangs, instantaneous responses and state changes.(I can repro it on any large file, TBH)
Hello @seancorfield I've been trying to solve this and I could only reproduce it in large files. Could you try this build? It looks like it solves it but just to confirm that it also works for you
Sure...
thanks! If you can try it and you do, let me know
That build is nice and fast -- behaves like 2.0.563 in terms of performance!
So... what was the regression?
Great! It was vs code config loading on every keystroke, due to the new feature about comment form configuration
Ah... that would explain why I was also seeing activity in the git/github view (little blue "crawl" indicator across the top on every keystroke)?
It could be, yes
You rock, dude!