Hey! The first image is how the highlighting looks when calva is disabled, and the second one when it is enabled. Can I use calva but "skip" its highlighting?
In the previous pictures, semantic tokens were enabled on both machines. I tried on a fresh install using VS Code Insiders, and nothing changed.
A fresh install of VS Code Insiders on “this machine” yielded the same bad result? That is very interesting and strange. I’m out of ideas for now, but will continue to think about it. Well, there are a bunch of logs we can check, come to think of it. clojure-lsp writes a log to ‘/tmp/clojure-lsp.log’, and there’s the console log you find from the Help menu, Toggle Developer Tools. It’s a lot of false positives there, but since you have a machine where things are behaving maybe a comparison can tell us something.
I think that’s semantic tokens from clojure-lsp. Can be disabled I clojure-lsp settings.
I tried to, but I couldn’t @pez. When I disabled it this is what I got - not the same as the first image I sent
Calva does some default highlighting that you can’t skip, but it does look like you have more than that in that last screenshot. It’s not super easy for me to see because it depends a lot on the theme. See what you get if you disable clojure-lsp (just so that we know where what highlighting comes from).
this is what I get
Thanks. That’s the minimum highlighting you can hope for with Calva and the theme you are using. The rest is provided by clojure-lsp and you control that with clojure-lsp config. (To the extent it can be controlled.)
Thanks. However, checking the previews on the GitHub repo and disabling all my extensions (just having calva enabled), I believe there's something wrong with my end. The first image is how it should look like, and the second one is how it actually does. The highlighting definitely does not look the same and to be honest I've got no clue on what could be causing the difference on the highlighting.
I also tried uninstalling VSCode & uninstalling calva with no luck.
with a different theme -- so many things being the same color makes it really hard to use
actually, this is really weird. machine a: calva, with no other extensions, works as desired
this machine:
using the same theme
If you have semantic tokens enabled on machine-a and not on “this machine”, I think that would explain some of the difference. You could also try with extension bisect (a command available from the Extensions pane). And also see what you get if you do a fresh Calva install in VS Code Insiders.
I created a new mini project, and all of the REPL output is going to the terminal. I verified in .vscode/settings.json file that the calva.outputDestinations are all set to "terminal". Is this the expected default for Calva? I have a vague memory of the REPL output going somewhere else by default before. I just want to be sure I know what the default is and that I didn't mess something up in my own environment.
It's been so long since I did a completely fresh install... And I switched to the terminal output as soon as it was implemented! 😄
After using it all day yesterday and today, I found it to work well. Thanks!
Context: I'm running a workshop tomorrow, so I want to be super clear that I understand the default behavior.
Also, if the terminal is the default for output, I'm curious to hear the rationale for that vs the Output View which appears to have good performance too.
You'd have to search the archives of this channel but the output view had a bunch of (vs code) limitations that cannot be worked around, as I recall. So now terminal is the better choice. I think it's the default...
@seancorfield OK. That's good to know. Thank you!
The terminal isn’t the default yet, but it should be. The mini project uses the terminal as a suggestion, so to speak.