Clojurians Log v2

That is so crazy. I really don’t understand this issue.

Now I have understood it well enough to have hopes for that C fixes the issue with connecting: https://github.com/BetterThanTomorrow/calva/issues/2806#issuecomment-2846824052 That’s not to say that I have understood the issue as such. The A/B experiment outcome is truly worrying. But anyway.

yup build C worked for me as well!

and v2.0.506 works as well! Whew

Many thanks, @patrix! I can’t reproduce still, but I think I now have spotted a key difference between the previous code and my refactored (if it can be called that when we don’t have tests for it!) code. New build should be available here https://app.circleci.com/pipelines/github/BetterThanTomorrow/calva/8737/workflows/1b546663-aa68-4081-b22b-81898516abca/jobs/49049/artifacts any minute now.

I’ll test in a few hours

Another shot in the dark at this error: https://github.com/BetterThanTomorrow/calva/issues/2806#issuecomment-2844933758

heyy that one worked!

; Starting Jack-in: (cd /workspaces/test; clojure -Sdeps '{:deps {nrepl/nrepl {:mvn/version,"1.3.1"},cider/cider-nrepl {:mvn/version,"0.52.1"}}}' -M:dev:+default:+portal -m nrepl.cmdline --middleware "[cider.nrepl/cider-middleware]")
; Using host:port localhost:44485 ...
; Hooking up nREPL sessions ...
; Connected session: clj
; Evaluating code from settings: 'calva.autoEvaluateCode.onConnect.clj'
nil
clj꞉user꞉> 
"Please see 
about why stdout printed to this file is prepended with `;` to be line comments."
clj꞉user꞉> 
; Jack-in done.
clj꞉user꞉> 

That is a bit crazy, but goes to prove that Rich Hickey is right about that most problems come from state… We really need to decomplect a lot of Calva’s parts. Thanks for testing and confirming! 🙏 I will have a closer look at the tiny changes and see if I can keep their intent and fix the connect issue.

I've replied in the issue as well that both test builds (A and B) you provided worked for me

P.S flowstorm is able to connect to that port

Hi! I think this is a regression. Mentioned in replies here: https://clojurians.slack.com/archives/CBE668G4R/p1745744348413999 So you should be able to restore the connect behaviour by using version 2.0.501 of Calva (I may be misremembering the version, check the link). I can’t reproduce this yet. Can you see if there are errors in the dev console that can give us clues?

solved, thanks

Please help me with checking the dev console log with the new not-working version. 🙏 I need to fix this, but I am blind without any more clues about it.

Sure, lets go at it where can I find the dev console?

From the vs code help menu. Toggle Developer Tools

Also. Please file an issue. There’s an option in the VS Code help menu to file an issue from there. Then it will attach some VS Code and OS info to the issue. In case this is related to that. (I doubt it is, this is a bad refactoring of mine, I am pretty sure.)

https://github.com/BetterThanTomorrow/calva/issues/2806 I dumped the logs from the devtool console in the issue. Tell me if you need more info or if you want me to try stuff

I’m getting this too, with regular Clojure not shadow-cljs. Will try to get some logs as well. Works with 2.0.501

I posted a comment in the issue with a link to a dev build that hopefully fixes the problem: https://github.com/BetterThanTomorrow/calva/issues/2806#issuecomment-2842391996 Please test it for me, as I can’t repro the problem yet. 🙏 ❤️ calva

🙏 I'll test it and report back (it won't happen immediately, I'm just heading out with my family)

Posted the errors from the console log on my vscode (with v 2.0.504)

and did the same with the test build

• Calva version is 2.0.503 • Only seems to happen when clojure-lsp is up and running • nothing set up for configs like "editor.formatOnSave", its all default • calva configs:

"calva.fmt.configPath": "CLOJURE-LSP",
  "calva.paredit.defaultKeyMap": "original",
  "calva.prettyPrintingOptions": {
    "printEngine": "puget",
    "enabled": true,
    "width": 120,
    "maxLength": 50
  },
  "calva.definitionProviderPriority": [
    "lsp",
    "repl"
  ],
  "calva.fmt.newIndentEngine": false,
  "calva.legacyPrintBareReplWindowOutput": false,
  "calva.outputDestinations": {
    "evalResults": "terminal",
    "evalOutput": "terminal",
    "otherOutput": "terminal"
  },
  "calva.showCalvaSaysOnStart": false,
  "calva.autoOpenJackInTerminal": false,
  "calva.autoOpenREPLWindow": false,
  "calva.useLegacyReplWindowPath": false,
  "calva.autoOpenInspector": false,
  "calva.redirectServerOutputToRepl": false,

We’ve had som regression around the formatter lately. Not seen anything that would be related to clojure-lsp, and that sounds very strange… there’s an issue with format on save https://github.com/BetterThanTomorrow/calva/issues/2789 For which we have cooked what hopefully is a fix. I have posted a link in the last comment there, but no one there seems to care so we’re a bit stuck. See if it fixes your issue there.

I also now rediscovered this issue. https://github.com/BetterThanTomorrow/calva/issues/2787 (Too many issues right now!)

Oh, https://github.com/BetterThanTomorrow/calva/issues/2787 seems to be the exact problem as I'm having

Btw, enabling the new Ident engine does solve the problem for now, so gratitude-thank-you

We should probably remove that old indent engine. I think that it, by some accident, used to fix things for Vim users, but I don’t think it is worth the cost it imposes in maintenance.