Fork me on GitHub
#calva
<
2024-04-05
>
pez13:04:27

Dear Calva friends. In the ^previous thread^ the issue with the flat representation of variables in the Calva debugger frames was brought up. I now have a dev build of Calva that presents a tree-thing for structured values. I would love some help putting it to some tests so that we at least can shake out any crashy things I may have introduced. If you want to help with this please https://output.circle-artifacts.com/output/job/f833653d-4f20-4c15-896c-d59a751dbcb6/artifacts/0/tmp/artifacts/calva-2.0.436-2494-structured-debugger-variables-83f2a684.vsix Thanks in advance! ❤️ 🙏

👍 1
pez11:04:18

I have changed how we build the structure to use the TokenCursor instead of doing the cljs.edn/parse -> clj->js thing. Because too much was lost in the translation to a JS object. Here’s the latest VSIX: https://output.circle-artifacts.com/output/job/6ae01bb7-cc72-4f61-a6bc-85808e87ee70/artifacts/0/tmp/artifacts/calva-2.0.436-2494-structured-debugger-variables-f0dc9661.vsix

pez11:04:52

I suspect it would be tons of work to try get metadata to be preserved, whichever way we go, so skipping even trying that for now.

José Javier Blanco Rivero12:04:20

Hi @U0ETXRFEW! I gotta say I'm very satisfied with the changes in the debugger frame. It comes really handy as a tree structure. However, when I was testing it, I found a pair of issues not only in WSL2, but also in Windows 10. These issues are not related to the debugger frame, I believe. In the first case, I pressed by chance F11 (debug step by step) when declaring an atom within a let binding and it hanged. If I press F10 it runs normally (picture 1). In the second case, I debugged a function that makes an async HTTP request using the Hato library. Since it returns a MinimalFuture, I was dereferencing the call and eventually it hanged showing the following message (picture 2). In this case it does not matter if I hit F10 or F11. I guess the must be an issue with Futures and Atoms. Maybe this is not the usual way to raise an issue, please let me know...

pez13:04:58

Hi! Glad you like the changes. As for the issues, it would be great with a minimal repro project. And also if instead of F10 and F11, you say which commands you are using.

José Javier Blanco Rivero14:04:59

I only managed to reproduce the issue with atoms. Here is the link to the repo: https://github.com/javierrweiss/calva-debugger-issues

pez15:04:41

Thanks for the repro! Please file an issue about it. And include some repro steps either in the README of the project or in the issue. Preferably both. 😃

👍 1
pez16:04:54

+ links: project <-> issue. I have tons of tabs and stuff open and I easily lose my track (it’s how my brain works, lots of things going on, while it only really can deal with one at the time, haha). Links helps me a lot.

pez16:04:57

The repo readme links to itself right now. Better if it links to the issue.

pez18:04:28

Thanks. I’ll try to make it worth the effort!

pez18:04:19

TGIF. Have a great weekend, Calva friends. ❤️

hammock 3
👍 2
1
❤️ 1