Okay, it seems to be clojure-lsp. When I stop the clojure-lsp server via the bottom toolbar folding works again, when I start it, it stops working. Will post this in #CPABC1H61

Issue created: https://github.com/BetterThanTomorrow/calva/issues/2486

hit same issue

commented on the issue, not a total fix for me

There is a total fix for you in the OP of that issue, I think. 😃

as in just use indentation?

as I missed that indentation is what I'm used to I think, it's indistinguishable from semantic once you've autoformatted I guess, thanks

So what do we need to use the non-“boring” one? I switched to lsp nightly. Set mode to “auto” or “indentation”?

Seems like “indentation” allows folding nested forms, where “auto” does not.

@U09D96P9B yes. Seems that clojure-lsp only uses top level forms. And not RCFs.

I have not changed any settings, it was only after I updated

This has come up several times recently.

Calva changed output to comments so that your REPL window doesn't break syntax related stuff.

There's a setting to get the legacy behavior back, but the output window is going away and will switch to a new output terminal that has different behavior for highlighting.

(I'm in a meeting otherwise I'd link you to the threads that talk about -- search for legacy in this channel and you should find the threads about the settings)

Thanks!

I think if you search for legacy in settings in VS Code, it will find the two(?) legacy setting flags. I've already switched to the new terminal output window (but I've always had Calva's REPL output hidden nearly all the time anyway).

My meeting is over now, so if you need more help, LMK...

Actually I am a little confused reading this document https://calva.io/output/#about-stdout-in-the-repl-window So now the output is in a comment form but it seems like you are talking about a seperate output window from the input window entirely... I do alot of things like adding prints while I playing in the REPL and having another window to see those as well as things as exceptions would be ideal! What setting do I have to enable to move all my output to a separate window?

The changes shouldn’t affect what happens in errors, and unusable wasn’t what we aimed for either. Sounds like something is going very wrong.

Starting the repl looks fine

; Connecting ...
; Reading port file: file:///REDACTED_BY_ME ...
; No nrepl port file found.
; Hooking up nREPL sessions ...
; Connected session: clj
; Evaluating code from settings: 'calva.autoEvaluateCode.onConnect.clj'
(when-let [requires (resolve 'clojure.main/repl-requires)] (clojure.core/apply clojure.core/require @requires))
nil
clj꞉user꞉> 

clj꞉user꞉> 
(println "HELLO")
; HELLO
nil

clj꞉user꞉> 
(defn test "" [data] (clojure.pprint/pprint data))
#'user/test
clj꞉user꞉> 
(test {"key" #{"VALUE1" "VALUE2"}})
; {"key" #{"VALUE1" "VALUE2"}}

(test (zipmap (map str (range 1 2000)) (map str (range 1 2000))))

So it seems to only be with very large outputs but 2000 lines is not that bad....

Not good. Please report.

How do I do that? Do I open up an issue on the repository?

Yes, sorry, should have been clearer. Please report as an issue on the repo.

👍 Sorry yea very new to this kind of stuff still

Worth checking whether it works in the new terminal output too -- if it does, maybe you should just switch to that?

How do I switch to that?

Scroll up on the doc page you looked at before.

Turn OFF the legacy REPL output setting.

👍 Roger

So it switches to the new REPL window.

Using the terminal as output the stuff I ran above is fine, using the REPL input and output in the same window without legacy behavior this seems like an issue, I have not tried with legacy behavior

I will just switch to the new terminal, I like this alot better but another question while I have you.... If I start a REPL manually and connect to it using Calva how does the output work then with the output still set to terminal (since Calva did not start the REPL I am a little confused)?

Dunno. Try it and see...

It’s unrelated to the jack-in terminal. There’s no process or anything backing it.

Yea I just tested it thanks! Did you still want me to open up that issue for the non legacy output in the same window issue?

Yes, even though we are eventually retiring using the REPL Window for output, it is still good to have a record of what issues it has. And also if this is a regression, I need to at least investigate what happened, because the changes really shouldn’t have that effect.

https://github.com/BetterThanTomorrow/calva/issues/2487

Thanks!

I could repro once. But not any longer. Very strange issue, but also we do know that the repl window has issues with processing a lot of output messages in quick succession, so this may be triggering that.

The strange part to me here is that it would matter if we prepend the output lines with a semicolon or not.

Also taking away from this thread that the documentation for this is a bit lacking.

👍 Thanks for the help!

Yea its only with the non legacy behavior with the old window, the legacy behavior seems to work fine. And so does the new terminal window