Fork me on GitHub
#calva
<
2023-10-22
>
pez15:10:21

Dear Calva Friends: https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.392 • Bump bundled deps.clj to v1.11.1.1413 • Add timestamps to nREPL message log diagnostics • Fix: https://github.com/BetterThanTomorrow/calva/issues/2299 I do hope this should be the main fix for those structural editing hangs that have been plaguing some users for all too long now. Thanks to everyone who has been helping with this. A special THANK YOU! to @ingy who created the reproduction that enabled me to find the bug in the code and fix it. ❤️ 🙏 calva

🙌 2
❤️ 2
gratitude 4
Karol Wójcik10:10:22

Works like a charm! No hangs! Thank you so much!! 😊

🙏 1
pez10:10:43

Awesome. Thanks for reporting!

seancorfield16:10:51

I just got a hang with this latest version. Will see if I can repro...

pez18:10:00

Would be awesome with a repro!

Nathan20:10:35

Hello, I'm having a similar issue with hangs but they most noticeably happen on Calva Paredit: Move Cursor Backward Sexp/Form (or Forward). While the hang happen I can't do any action related to calva (structural editing or else ) but any other action (basic vscode action or another extension) works fine. Once the hangs finishes, usually after 5 to 10 seconds, all "queued" events will get executed at once. Should I consider this to be the same issue ? The good news is that it's extremely easy to reproduce on my end, I simply move the cursor back and forth between forms and it will happen in less than 30s. Would love to help if there is anything I can do

pez20:10:06

Sounds awful with the hangs! But good with the repro. Can you check if you see any errors in the development console that seems related to the hangs? You can open the development tools from the Help menu (and from the command palette).

Nathan20:10:09

It can get a little irritating but love the extension otherwise so I'm sticking with it ! I already checked both the console and the output for the extension host but not a single log when it happens. I should also point out that this only happens for me when using WSL and remoting VSCode into it. A native linux distro that I have on another computer works perfectly fine. ( But I don't know for sure it's linked to WSL, that is simply what I noticed happening for me )

pez20:10:46

Well, @U04V70XH6 is also running with WSL… So it could be related to that. Please file an issue. You can mention something like [WSL] in the title, and we can change the title if we have reason to believe it’s more general.

seancorfield20:10:38

Interesting. I guess I could try installing VS Code etc directly on WSL and try using it via the X emulation but that can be a bit glitchy too - and the hangs are a relatively recent problem...

pez20:10:49

Could be due to some change in the Remote Extension?

Ingy döt Net20:10:50

@U04CXBCRW0Z The hangs that I experienced and were fixed didn't allow me to use the cursor at all or any action at all in VS code while it was hung

pez20:10:10

Yeah, this is something else.

Ingy döt Net20:10:32

Sometimes I wonder if copilot is causing hangs but I have nothing to back that up

pez20:10:18

The one you and I fixed, @ingy was only hitting in unstructured documents. Somehow I doubt that @U04V70XH6 has that situation very often. 😃

seancorfield20:10:26

I see this in a workspace with Copilot disabled

Nathan20:10:55

Will do, thanks for the fast reply ! I'll also try to run a bit more tests between both computers to try and find if anything could be the cause Also I don't have any other extension active other than Calva and WSL

Ingy döt Net20:10:14

I was just wondering that in general not as the cause of your problem

pez20:10:13

CoPilot is bad at balancing parens. So the bug we fixed could have been waking up often if CoPilot generated code.

Ingy döt Net20:10:12

I am well aware of the bad parens. Happens constantly. But I've never noticed that related to slow downs or hangs

pez20:10:55

Yeah, I think the bug we fixed only hit with an excess of closing brackets. And CoPilot usually produces too few of those.

pez20:10:49

I don’t run with CoPilot completions in Clojure code. But I do in TypeScript, and haven’t noticed any hangs there.

Ingy döt Net20:10:36

Why don't you use it in clojure?

pez21:10:39

The signal to noise ratio is not high enough, I think. When I want help I use the chat instead. It knows where in the code I am so I don’t need to give it much context.

Karol Wójcik21:10:09

Btw is there something calva can do to autobalance parens after copilot completion?

pez21:10:54

If the indentation is correct you can try Calva Format: Infer Parens (from indentation).

Karol Wójcik21:10:22

😍 😍 😍 😍 😍

Nathan21:10:00

Here is a link to the issue I created for what we talked about earlier. English is not my first language so if anything is unclear, please say so ! I'll keep it updated as soon as I find out more. https://github.com/BetterThanTomorrow/calva/issues/2331

❤️ 1
pez21:10:30

Thanks, @U04CXBCRW0Z! That issue was perfectly clear to me. (Not a native speaker either, so could be that we speak the same broken English. 😃 )

😆 2