calva 2023-05-21 | Slack Archive

pez15:05:25

Dear Calva friends: https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.362 • Bump bundled deps.clj to v1.11.1.1273-4 • Fix regression: https://github.com/BetterThanTomorrow/calva/issues/2200 Thanks @furkan3ayraktar for reporting! 🙏 ❤️

🙌 2

xavi16:05:45

I'm working on a React Native app with Krell and with this release the cljs REPL can't connect to the app... :(

clj꞉user꞉> 
; Creating cljs repl session...
; Connecting cljs repl: deps.edn + Krell...
;   The Calva Connection Log might have more connection progress information.
; Error while connecting cljs REPL: TypeError: Cannot read properties of null (reading 'startsWith')
; Jack-in done.

I downgraded to the previous release of Calva and it works.

pez17:05:52

Thanks for this report! Which versions, specifically, are you switching between? It seems rather unlikely that the change between 361 and 362 should have this effect. Not impossible, I guess, but the change should only affect shadow-cljs connections…

xavi17:05:55

i actually have 361 now and it works. It didn't work with 362

xavi17:05:10

Looking at https://github.com/BetterThanTomorrow/calva/commit/a45388fda55bc47ca800d1ecc220e689eeb726b0#diff-93f9f09a29cd12cc70ff95aca80720b00ef8acd54370b9e0e18c8752b45a8196 I think that if this is false...

menuSelections && menuSelections.cljsDefaultBuild && useDefaultBuild

and this is false too...

typeof initCode === 'object' || initCode.includes('%BUILD%')

then in the added line...

build = build.startsWith(':') ? build : `:${build}`;

build will be null and then there would be the error i saw...

TypeError: Cannot read properties of null (reading 'startsWith')

pez17:05:52

That makes sense. I’ll fix. Or if you want to file a PR?

xavi17:05:59

Sorry I don't have time now. I really appreciate a lot all the time you put into this. Thank you

pez18:05:42

No worries. Thanks for reporting and for the help with reasoning around the cause. 🙏

xavi18:05:55

You're welcome. And thanks to you!

pez18:05:10

Can you test 363? Should be in the Marketplace now.

pez18:05:43

Dear Calva friends: https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.363 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2202 I forgot a null check in the previous release… Thanks @xavi for the report and help! 🙏 ❤️

2023-05-21

Channels