Fork me on GitHub
#calva
<
2023-02-01
>
Sergio09:02:43

Hi, I have a Babashka file and when I jack-in the shortcuts don't work. However by running with right-click -> Evaluate Current Form it works. Any idea of what could be happening?

pez09:02:43

No idea. That sounds very strange. Does it work with other Clojure projects?

Sergio09:02:33

Yes, a normal Clojure project can't evaluate 😞

Sergio09:02:01

I meant: yes it fails for even normal clojure projects.

pez09:02:53

@U039K02M4UB Is this similar to what you had?

pez09:02:20

It might be that the VS Code install is corrupted. To test that is a bit of a bother, but you can test if things work with a fresh install of VS Code Insiders: https://code.visualstudio.com/insiders/

Sergio10:02:43

sounds good, thank you for the help!

Sergio10:02:18

For the record: it worked!. Thanks!

pez10:02:05

You are welcome. So then either your VS Code installation is corrupt, or you have some extension that messes things up. The latter is unlikely, But if you could see if an extension bisect gives anything.

pez10:02:58

Sometimes a restart of the computer helps... ¯\(ツ)

Sergio10:02:21

I checked the Shortcuts and Jupyter notebook had the same shortcut, but it was uninstalled some time ago. So, maybe some hanging config?

Sergio10:02:45

yes, very strange but I think something among those lines might have been the problem.

pez12:02:37

Dear Calva friends, https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.329 just released: • https://github.com/BetterThanTomorrow/calva/issues/2035https://github.com/BetterThanTomorrow/calva/issues/2043 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2032 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2041 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2040 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2038 • Calva development: https://github.com/BetterThanTomorrow/calva/issues/2051 • Calva development, Fix: https://github.com/BetterThanTomorrow/calva/issues/2052 Contributors 🙏❤️ calva : The usual suspects of recent @m401 and @ahtunget got company from @ferdinand. This release is partly a re-release of the enhanced clojure-lsp support from 2.0.237, with some learnings, but there's also other stuff there. I am very pleased with that #joyride is now used for e2e testing of the Calva VSIX extension package. Thanks to @borkdude for making that possible and for helping me get pass some of my own traps while implementing.

🚀 4
🎉 14
calva 6
Thierry13:02:04

This version breaks clojure-lsp auto starting in VSCode for me. Going back to version 2.0.328 fixes this for me.

pez13:02:27

Not good! Can you describe your workspace layout some?

Thierry13:02:16

Sure, I have the below folders. where . is the main source and docs-code contains a project somewhere in a subfolder. It doesn't matter if I remove both extra folders and only have the main folder in my code-workspace file, clojure-lsp says it isnt started and I should choose a project.

"folders": [
		{
			"path": "."
		},
		{
			"path": "..\\_docs-code"
		},
		{
			"path": "..\\bootstrap\\bootstrap-4.1.3"
		}
	]
This is a screenshot with all folders in the code-workspace after i click clojure-lsp in the bottom bar because it's not started. https://files.slack.com/files-pri/T03RZGPFR-F04MLJNUKGC/image.png

Thierry13:02:06

Going back one version from 239 to 238 makes clojure-lsp auto start.

Thierry13:02:43

Here's a screenshot with the folders removed

Thierry13:02:56

If I then click the project and click start clojure-lsp starts

Thierry13:02:01

It just won't auto start

Thierry13:02:24

hovering the mouse over clojure-lsp gives a popup 'Open a clojure file to see the server status'

pez13:02:55

When 328 autostarts it, which project-root is it using? You can see this with the command for showing serverinfo.

Thierry13:02:28

let met check

Thierry13:02:09

"project-root-uri": "file:///d:/thier/Documents/GoogleDrive-Thorax/Dev/aorta-develop",

Thierry13:02:12

the one it should use

Thierry13:02:05

the code-workspace file I opened is in that folder

pez13:02:06

So that's . in that file? (I'm not using workspace folders myself much.)

Thierry13:02:39

yes, thats the default path

pez13:02:36

Can you screenshot the explorer view too? Maybe that makes it clearer to me why that's the project where it should autostart.

pez13:02:22

And please file an issue about this.

Thierry13:02:04

I will file an issue, having lunch atm 🙂

pez13:02:38

Smaklig spis

pez13:02:45

^ Swedish ^ for something like Enjoy your meal. But I don't think there's a general expressions like that in English. It would be more like Enjoy your lunch... Well, I am not a native speaker so probably am missing some idiom. 😃

pez13:02:30

<!subteam^S03BGSAUPTQ>, @m401. I'm not pulling the rollback lever here just yet. Let me know if you think I should. Thinking that most users do not use workspaces and that starting clojure-lsp manually is OK while we fix it. I am keen on trying to reproduce the error with the new e2e testing infra that I just put in place.

Thierry13:02:04

@U0ETXRFEW I know, my stepmother is Swedish 😁

👋 2
Thierry13:02:59

In Dutch we have eetsmakelijk

pez13:02:10

That sounds very much like it matches the Swedish idiom.

Thierry13:02:47

Indeed it does. Eet is from eten which is like eat from eating and smakelijk is the exact same word as Smaklig

Thierry13:02:26

We also say Smakelijk eten wich is an exact translation to Smaklig spis

pez13:02:05

Is smakelijk completely missing from English?

Thierry13:02:21

Google says Tasty, but there doesnt seem a direct translation from ours to

pez13:02:28

Nah, that is more how something tastes/that it tastes good/has a lot of flavour.

pez14:02:42

Please add your findings/screenshots etc to that issue, @thierry572.

Thierry14:02:28

will do, on it

Thierry15:02:11

@U0ETXRFEW What do you mean by VS Code Workspace proper ?

pez15:02:57

I mean as opposed to a plain folder.

pez15:02:45

Haha, I didn't realize it was you who had filed that issue, @thierry572 😃

Thierry15:02:48

:face_with_hand_over_mouth:

Thierry15:02:00

Updated my reply and the op.

julienvincent15:02:06

Thanks for the report. @thierry572 can you check the developer tools console to see if there are maybe any relevant errors being logged when you load vscode?

Thierry16:02:41

What exactly do you want me to look for? all console message point to workbench.desktop.main

Thierry16:02:23

this is on 239

julienvincent16:02:00

Hmm I don't think that's related. My guess is you would be getting that same output for 238

julienvincent16:02:27

Ok I will be trying to reproduce and fix later today.

🙌 2
Thierry16:02:34

this comes after it. let me check 238

julienvincent17:02:46

I’m struggling to reproduce this issue. I guess this has something to do with it being on Windows..? I’m not sure how to go about fixing this as I do not have access to a Windows machine if that’s the case.

Thierry17:02:27

anything I can do, test, code, fix, whatever?

Thierry17:02:07

Imho I think it has to do with the differences in path handling between linux and windows?

pez17:02:27

I’m afk. Can you assist @thierry572 to the code option , @m401 ? 😍

julienvincent18:02:02

Happy to but I’m also strapped for time atm - currently in the US for meetings so organising a common time might be tricky. @thierry572 would you be free in a couple hours or tomorrow (your) morning for a pair-programming session?

Thierry22:02:49

Completely missed your message there @m401 going to bed now, have to work in the morning.

julienvincent01:02:32

Ok will see if I can get access to a Windows machine later in the week to test

julienvincent18:02:32

Ok finally got access to a remote windows machine - will try fix :)

🙏 4
pez18:02:21

Let me know if you want some company, @m401. 😃

Thierry22:02:05

Dunno if I did this right, but I copied the contents from the zip/extension folder into the c:\Users\thier\.vscode\extensions\betterthantomorrow.calva-2.0.328\ folder and started VSCode.

Thierry22:02:24

Starts and works

metal 4
clojure-spin 4
Thierry22:02:06

All in its glorious self

Thierry22:02:43

lsp popup looks nice n sorted too

Thierry22:02:12

Kondo started and giving response in the Problems tab

pez22:02:19

> Dunno if I did this right Well, no 😃 You should have used the meatballs menu in the VS Code Extensions pane and selected Install from VSIX (can also be done from command line, but anyway).

Thierry22:02:05

The meatballs menu, new one for me :melting_face:

pez22:02:11

Your way obviously worked. But I think VS Code can get pretty confused about it.

Thierry22:02:27

let me try the correct way

pez22:02:37

I'm a Swede, meatballs everywhere. ¯\(ツ)

😅 2
Thierry22:02:57

made a backup of the contents before starting ofcourse

Thierry23:02:43

right, my browser saved the vsix as zip, thats why

Thierry23:02:01

anyway, installed from vsix and same outcome

Thierry23:02:22

Calva is utilizing cider-nrepl and clojure-lsp to create this VS Code experience.
nREPL dependencies configured: nrepl: 1.0.0 cider-nrepl: 0.28.5 cider/piggieback: 0.5.3 clojure-lsp version configured: latest If you are new to Calva, please see: And please consider the command: **Calva: Fire up the Getting Started REPL** Calva version used: v2.0.330-pull-2060-33b8c7e3 clojure-lsp version used: 2023.01.26-11.08.16 clj-kondo version used: 2023.01.20

Thierry23:02:12

well ill be damned this quote thing

Thierry23:02:14

im going to bed

Thierry23:02:25

thanks for fixing @m401!

😊 2
pez23:02:58

Thanks for being quick to test and confirm, @thierry572!

Thierry23:02:03

you're welcome @U0ETXRFEW,now im really going to sleep

julienvincent00:02:24

Cool! Glad this worked. Love me some 1 liner fixes

pez11:02:28

Dear Calva friends. Current Calva (v2.0.329) broke things for people using Windows without WSL. A release fixing this is now published: https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.330 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2054 • Calva development: https://github.com/BetterThanTomorrow/calva/issues/2058 Please let us know how you fare. Thanks @m401 for all the work with this! A tiny fix, but I know you had to source a Windows machine and figure a lot of Windows things out. 😃 🙏 ❤️

🙌 6
2
gratitude 6
julienvincent15:02:03

Haha thanks for helping me set the machine up! :)

pez16:02:24

@thierry572 I saw you posted this part of the console log in another thread. There are two strange things there. 1. That the deps.clj version file isn't found. 2. That clojure fails. The second one could be legit, maybe you are a lein user, who do not use tools-deps? But the first one should not be like that. We might have a bug.

pez16:02:51

Especially since later in the log it seems that it should create the deps.clj version file just fine, and then you should not see the above log on subsequent starts of Calva...

Thierry16:02:06

I use lein indeed

Thierry16:02:15

on 238 it does the same\

pez16:02:01

Lots of problems there!. It says it fails to download clojure-lsp too. I don't think any of this is new, btw. Might be Windows issues, none of us in the <!subteam^S03BGSAUPTQ> use Windows...

Thierry16:02:47

I have no issues on 238 tho, nor before 238

pez16:02:18

The clojure-lsp error seems extra Windows specific. It says it is a download error, but I think it is the chmod that goes wrong. And then, probably, the chmod is not needed, so you have no issues. But the universe knows that something went wrong, so we need to get it fixed.

Thierry16:02:56

Its always the damn universe

😄 2
kstehn18:02:32

Have the same issue on Windows, but it goes so far That nothing works even navigating with Ctrl arrow or selecting forms. It only See this error and on the bottom left it always says activating extension.

seancorfield19:02:26

When you say "Windows" -- @thierry572 and @UD8TU3HP0 -- are you talking about native Windows with Powershell/cmd and your Clojure files all local? (i.e., not WSL2) (I ask because I'm not seeing any issues on Windows/WSL2 -- but in that setup, VS Code installs Calva into the Linux side so "everything" operates there, except for the UI... the files are all on WSL2 as well)

Thierry19:02:57

Yes, native Windows

kstehn19:02:04

For me yes nativ had only Problems with wsl2

Thierry19:02:33

2 different systems

seancorfield19:02:51

'k... @UD8TU3HP0 Curious about your WSL2 problems but we can follow up on that in a separate thread if you want? I've been using that setup with Calva for ages and loving it.

kstehn19:02:55

Its more a Problem with what and how we develop nothing specific to Calva

pez20:02:35

@UD8TU3HP0 Calva never activates for you?

kstehn20:02:13

Well it does but wehn i start the lsp for one Project something happens end then everything is kind of broken and shortcuts dont work

pez20:02:47

This is with 329? Or even with 328?

kstehn20:02:07

No only with 329, 328 works just fine My guess something with the multi-project lsp and Windows mess something up

pez20:02:25

Please add whatever details you think are relevant to this issue, @UD8TU3HP0 https://github.com/BetterThanTomorrow/calva/issues/2054 If you can describe the workspace layout and project structure that would be great. If it's Workspaces involved, or just plain folders.

pez20:02:04

And of course, if you can try debug it in development mode, that would be awesome.

kstehn20:02:48

Will Do this tomorrow I guess i can spare 1h or so to check this out 👍

❤️ 2
Thierry07:02:39

I was wondering if the new sorting of project choice might have anything to do with it? Or does that not apply to clojure-lsp? Since in 239 the popups to choose a project to start lsp for are not sorted like described in the release commits. In fact the main project is not even at the top in my screenshots?

pez07:02:13

My guess it that those two issues has the same cause. Good clue!

julienvincent14:02:06

Yea there must be some difference with how paths are represented/formatted/something on windows which would affect all of these things.

kstehn14:02:58

Yes That is also my guess, i added my findings to the Ticket also

pez11:02:28
replied to a thread:Dear Calva friends, https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.329 just released: • https://github.com/BetterThanTomorrow/calva/issues/2035 • https://github.com/BetterThanTomorrow/calva/issues/2043 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2032 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2041 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2040 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2038 • Calva development: https://github.com/BetterThanTomorrow/calva/issues/2051 • Calva development, Fix: https://github.com/BetterThanTomorrow/calva/issues/2052 Contributors :pray::heart: :calva: : The usual suspects of recent @m401 and @ahtunget got company from @ferdinand. This release is partly a re-release of the enhanced clojure-lsp support from 2.0.237, with some learnings, but there's also other stuff there. I am very pleased with that #joyride is now used for e2e testing of the Calva VSIX extension package. Thanks to @borkdude for making that possible and for helping me get pass some of my own traps while implementing.

Dear Calva friends. Current Calva (v2.0.329) broke things for people using Windows without WSL. A release fixing this is now published: https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.330 • Fix: https://github.com/BetterThanTomorrow/calva/issues/2054 • Calva development: https://github.com/BetterThanTomorrow/calva/issues/2058 Please let us know how you fare. Thanks @m401 for all the work with this! A tiny fix, but I know you had to source a Windows machine and figure a lot of Windows things out. 😃 🙏 ❤️

🙌 6
2
gratitude 6