Feedback on the PR would be preferable - but here is ok too :)

Kind of curious why spawn multiple clojure-lsp proccess for the mono-repo, currently clojure-lsp uses 2GB ram per process, if the mono-repo has 6 subprojects would spawn 6 process? There are ways that we recommend to configure the lein or deps project in a way you spawn a single clojure-lsp process in the mono-repo root and it uses the classpath for all subprojects in the same process. clojure-lsp project it's a mono-repo itself for example, and you can just start a single clojure-lsp process on the mono-repo root and everything should work

For a mono-repo configured with a root deps.edn or lein project only a single lsp server will be started. If you have a multi-workspace (multiple folders open in vscode) then this adds support for starting lsp servers in each workspace. Additionally / similarly when opening a directory with multiple independent projects (so not a mono-repo necessarily) this adds support for starting lsp servers for each independent project

Also, lsp servers will be started reactively to project files being added/opened. So opening a directory containing multiple projects won’t result in multiple lsp servers being started preemptively

We should probably clarify in the Calva docs that a deps.edn at the monorepo root is to prefer over spawning several servers.

got it, sounds good make that clear on the docs as well, thanks, that sounds like a nice improvement!

Ironically, I could have really used this change a year ago -- when our monorepo had the Clojure code in a subfolder -- but because of the pain of dealing with tooling (not just LSP) we ended up lifting the Clojure "project" up into the root of the monorepo so it is all one big "Clojure project" now with a couple of extra folders/files 🙂 The multi-workspace aspect sounds great -- I may well go back to an "open source workspace" with all my OSS projects loaded into it, once this change hits the main branch.

I don't understand either why it works when you start the REPL with the same command line... If you connect to that nREPL server from Calva, do you get Calva evaluations in the Reveal window?

I just tried that and unfortunately no...

I'll try this myself and see what I can figure out. But tomorrow. Late here now. I know I have had Reveal working before.

Hi there. Just wondering if you had a chance to look at this yet or perhaps it was addressed and I missed it. Thanks!

Oh, thanks for the reminder. I have completely dropped this ball. Will have a look now.

Hello again. As this is hard to reproduce for me, I created a mini-project that works when I try it. Maybe we can learn something if you try it too: https://github.com/PEZ/minimal-reveal-leiningen

If you don't have specific reasons to use Leiningen, I think that a deps.edn project is probably better to start with. We're having some issues with Leiningen support in Calva that we haven't figured out. (Doesn't affect most projects, it seems, but anyway.) So, here's a mini reveal project using tools-deps: https://github.com/PEZ/minimal-reveal-deps

Ok I’ll give it a shot and let you know!

Hi there, I tried it out; 1. Without Calva, worked fine 2. With Calva, not working; see screenshot

That’s very interesting :thinking_face:. Did you try the tools-deps project?

sorry, not sure I understand. Is tools-deps a different repository I should clone and try out?

sorry, I didn't realize you put two repos up above... The screenshot above is using tools-deps; The below screenshot is using the first repo (leiningen). same issue

This is so very strange. There's absolutely no reason that I can think of why it would differ. Can you try connecting Calva to the REPL started in the terminal? This really should be the same as Jacking in (the command lines are copied from what Calva uses) but since things are this weird already, I obviously don't understand this well enough to say something like ”should be the same”.

I tried this with the tool-deps project but no luck. From the terminal, I executed: clojure -Sdeps '{:deps {nrepl/nrepl {:mvn/version,"1.0.0"},cider/cider-nrepl {:mvn/version,"0.28.5"}}}' -A:reveal-nrepl-middleware and then in VSCode, attached to a running REPL but all I got was below.

I am out of ideas what could be going wrong here. Please file an issue. You can use VS Code for it. (From the Help menu.) That will include information about your machine and versions of things and such.

Ok I will do so. Do I file it on VS Code or an extension ? (Incidentally, I tried all of the above on another Mac machine and it worked! so something on my machine presumably)

File it on an extension. Then choose Calva.

That's correct. Hopefully we will be able to fix this eventually. For now there are a few things you can do. You can use Calva's ranges API with Joyride to give yourself some commands to evaluate things like the current form. Joyride has a command for evaluating the selection, but it can be a bit too spartan at times. You can also start an integrated terminal and connect an nREPL client to Joyride's nREPL server. So you'll have a prompt, plus whatever evaluation commands you hack together using Joyride.

CC: @m401. I've been mentioning this in our chats.

Yes I had just gotten to this workaround, remember I was bothering about the escaping of ranges in command snippets, I was trying to reimplement part of that customreplcommand stuff in joyride using the calva ranges so that I can control the escaping

Ah, yes, I remember. 😃

If I can dynamically bind keys in a joyride startup script o should be able to do almost anything fairly ergonomically

You can create functions in startup (activation) scripts and bind shortcuts via the JSON config for that.

VS Code does not have API for dynamically binding keys, afaik.

I was just looking that up

Microsoft are sick they must be stopped

If so, but also if not

https://github.com/microsoft/vscode/issues/1422

closed as won't-address, chews desk in anger

Yeah, it's frustrating.

Doesn't Code reload keybindings automatically when keybindings.json is saved? I expect you should be able to "dynamically" create keybindings by writing them to the file. 💡

yes I wrote half the code to do this last night, it's ugly though, that's not even a JSON file, it autogenerates with comments

I haven't tested/read yet whether it watches that file on disk or needs to be notified that it's changed

It watches it.

You can add keys to the entries, to keep meta-data you might need. (You probably know this, but anyway 😄 )

I didn't know that actually thanks

I think I want all the info in the init code though and great the keybindings as a random serialisation with no brains

Kind of excited about this, who wants to help me reimplement helm?

What's helm?

I think it is some Emacs thing, but even that could be wrong. 😃

Search/navigation module for Emacs, spacemacs integrates is heavily

It*

Key chord as a tree with a buffer displaying your available options as you navigate it

Caveat I think, it's been a while

Ah, yes. Something like that was what I was remembering vaguely.