This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-09-30
Channels
- # announcements (31)
- # aws (17)
- # babashka (26)
- # babashka-sci-dev (8)
- # beginners (16)
- # biff (1)
- # calva (9)
- # cider (5)
- # clj-kondo (3)
- # clj-on-windows (38)
- # cljdoc (2)
- # cljs-dev (9)
- # cljsrn (6)
- # clojure (58)
- # clojure-europe (47)
- # clojure-nl (3)
- # clojure-norway (21)
- # clojure-uk (2)
- # clojurescript (25)
- # conjure (2)
- # data-science (7)
- # datomic (3)
- # emacs (12)
- # events (5)
- # fulcro (5)
- # honeysql (10)
- # introduce-yourself (7)
- # lsp (4)
- # meander (3)
- # nbb (18)
- # off-topic (28)
- # rdf (1)
- # releases (2)
- # sci (5)
- # shadow-cljs (23)
- # sql (5)
- # test-check (3)
With following settings
{"calva.evalOnSave": true,
"calva.testOnSave": true}
Eval is not happenningThanks! Is this something todo with https://github.com/BetterThanTomorrow/calva/pull/1861, @U9A1RLFNV? I seem to recall that evalOnSave (badly named option, btw) was there mainly for the test-runner. Can't see that the PR really changes anything around it, though. But it could be that we need to revisit these two options.
I think I know what's happening now. https://github.com/BetterThanTomorrow/calva/blob/dev/src/extension.ts
We rely on that running the tests are preceded with a file load, and will disregard evalOnSave
if testOnSave
is true. Issue welcome, @U03FADKKGAE!
And PR too, if you feel inclined. 😃
Even if we didn’t disregard evalOnSave, can we be sure that eval (load-file) is run before the tests are run, also triggered by save?
We may need to do something to be sure the test running happens after the loading of the file, but I haven’t yet looked at it to see.
I created an issue for this now: https://github.com/BetterThanTomorrow/calva/issues/1880
> can we be sure that eval (load-file) is run before the tests are run, also triggered by save? Yes, we await the promise before running tests.
Dear Calva friends: https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.305
• https://github.com/BetterThanTomorrow/calva/issues/1876
• https://github.com/BetterThanTomorrow/calva/issues/1878
• Fix: https://github.com/BetterThanTomorrow/calva/issues/1880
• Bump pre-bundled deps.clj.jar to v1.11.1.1165