Fork me on GitHub
#calva
<
2022-09-30
>
k3nj1g11:09:19

With following settings

{"calva.evalOnSave": true, 
 "calva.testOnSave": true}
Eval is not happenning

pez11:09:11

Thanks! Is this something todo with https://github.com/BetterThanTomorrow/calva/pull/1861, @U9A1RLFNV? I seem to recall that evalOnSave (badly named option, btw) was there mainly for the test-runner. Can't see that the PR really changes anything around it, though. But it could be that we need to revisit these two options.

pez11:09:20

I think I know what's happening now. https://github.com/BetterThanTomorrow/calva/blob/dev/src/extension.ts We rely on that running the tests are preceded with a file load, and will disregard evalOnSave if testOnSave is true. Issue welcome, @U03FADKKGAE! And PR too, if you feel inclined. 😃

💡 1
bringe15:09:59

Even if we didn’t disregard evalOnSave, can we be sure that eval (load-file) is run before the tests are run, also triggered by save?

bringe15:09:20

We may need to do something to be sure the test running happens after the loading of the file, but I haven’t yet looked at it to see.

pez18:09:29

> can we be sure that eval (load-file) is run before the tests are run, also triggered by save? Yes, we await the promise before running tests.

🎉 1