Fork me on GitHub
#calva
<
2022-09-26
>
pez16:09:46

If you are good with CI stuff, please help with getting the Calva pipeline running again. ❤️ 🙏

lread17:09:23

One thing about curl is that https://superuser.com/questions/590099/can-i-make-curl-fail-with-an-exitcode-different-than-0-if-the-http-status-code-i. Could it be that you just suffered some sporadic problem on the intertubes?

pez17:09:33

It seems so. But it lasted for 10+ hours.

Eugen20:09:22

I'll can give it a go (on vacation right now) but would like to help if possible

Eugen20:09:43

well, it may be that we don't need to worry that much. It seems that Atom might got the axe https://www.makeuseof.com/atom-text-editor-why-github-is-killing/ . the domains http://atom.io is no longer responing. Nothing to do here IMO, unless there is another part y to build atom and take care of the project forward. Official notice: https://github.blog/2022-06-08-sunsetting-atom/

skylize20:09:09

Why do we need Atom to build for Code? Seems like a weird dependency to begin with. And with Atom being deprecated now, seems like a terrible idea all around.

skylize20:09:28

If it cannot be extracted, you should probably add a compiled binary to the Calva source code instead of continuing to rely on upstream.

Eugen20:09:02

> If it cannot be extracted, you should probably add a compiled binary to the Calva source code instead of continuing to rely on upstream. this might be a solution if you want to continue support for ATOM. I can probably help you out once I get familiar with the setup. We could package atom packages as docker images / store them in another place and get them from there. extra work, but should work fine.

seancorfield21:09:50

All of that is just to test the atom-language-clojure stuff?

pez23:09:30

It seems that the issue has sorted itself out. Some glitch somewhere. Utterly strange.

pez23:09:52

Yes, @U04V70XH6 has it right. The dependency on Atom is for running the TMLanguage grammar tests. This is for VS Code legacy reasons (all VS Code built-in grammars are from Atom, and even built from there). So when I started maintaining my own Clojure TMLanguage grammar I kept the tests and am always using Atom when editing the grammar and tests. It works great and has for years. Only today this strange hiccup. I hope it wasn't a forbearing of troubles to come. If it was, we will have to figure out another way to run the tests.

skylize03:09:55

> All of that is just to test the atom-language-clojure stuff? > --- > Yes, @U04V70XH6 has it right. The dependency on Atom is for running the TMLanguage grammar tests. I might be misreading, but it sounds to me like he is just as surprised as I am, even after working out the reason for it. > I hope it wasn't a forbearing of troubles to come. We already know that Microsoft is dumping Atom. I would definitely take this as an early warning. In the short-term, I still say just pre-build a binary that you know works. Either stick it into Calva source, or host it somewhere reliable. Long term, maybe the Atom community will come through with a viable fork? Don't count on it until it comes true.

Eugen05:09:48

@U0ETXRFEW: let us know what you decide and please let me know if you need help with this further

pez06:09:28

Thanks, @U011NGC5FFY. I am not super worried that this would stop working. As @U90R0EPHA says, we can publish a fixed binary and stuff, should we need to. However, while I do like how the tests here are integrated in Atom (I actually use Atom when hacking on the grammar) it would be great to be able to work with it in VS Code and also great if the tests could be run without firing up neither Atom, nor VS Code. If you think that sounds like fun things to look at, I would be super duper happy to introduce you. Check out https://github.com/BetterThanTomorrow/calva/wiki/How-to-Hack-on-Calva#syntax-grammar for what I've written on the subject so far.

Eugen06:09:49

thanks, I don't think I have time & energy to take that on right now

pez07:09:16

That's cool. The grammar isn't updated often. If worst comes to worst we can remove those tests from the main CI pipeline and do something special for the rare grammar updates.