Fork me on GitHub
#calva
<
2022-05-22
>
pinkfrog01:05:07

Is it possible to navigate the repl history like Ctrl+R does in bash?

pez08:05:17

That particular interaction is tricky to create. But some kind of search should be entirely possible.

Hamid Sadeghian05:05:18

if by "repl history" you mean the output.calva-repl file, and assuming the file content aren't cleared yet, a workaround would be to navigate the file with [ctrl+f] then simply hit [alt+enter] on the desired result to eval it again... a bit too involved, I know

😂 1
armed06:05:10

Hey everyone, I think I found small bug. alt+<up,down> arrow inside map destruction is moving pairs of keys. It treats destruction as map.

armed07:05:26

For example I can’t move b to third position in place of c

(let [{:keys [a |b c d]} my-map]
   ;; ....)
it becomes like this:
(let [{:keys [c d a |b]} my-map]
   ;; ....)

pez07:05:59

Thanks! Can you check if the same thing happens in function arguments?

armed08:05:19

hey, @U0ETXRFEW. function args works as expected

pez09:05:26

Thanks. Please file an issue. I don’t quite understand how this happens but I know where to start looking. Let me know if you wanna have a stab at it!

armed04:05:26

If you give me directions, I can look for fix

armed07:05:13

And btw, it doesn’t happen in function arguments. I guess I found place to look for cursor-doc/parerdit.ts/isInPairsList

pez07:05:46

Yes, I think you've found the right place. Please update the issue with the clues you find, such as it doesn't happening in function args.

pez11:05:32

Thanks! 🙏 So awesome that you do this. I left a comment on the PR about adding tests as well. I should have mentioned those, because I find it particularly rewarding to do this kind of change TDD style.

armed11:05:27

Ah, good to know, I’ll add tests

armed12:05:59

Added

🎉 1
🙏 1
pez12:05:46

If you have some time for it some day, @U34K4458X. There are several cases where dragging could be improved, such as in various cond forms and are. I think it would involve challenging the naïve way this thing is done today, but I honestly don't know. I just expect it to be non-trivial. 😃

pez12:05:30

This PR has some info about the room for improvements: https://github.com/BetterThanTomorrow/calva/pull/1698

armed12:05:59

Ok 🙂 I’ll look into it. Won’t this PR conflict with 1698? https://github.com/BetterThanTomorrow/calva/pull/1606 Seems huge changes.

pez12:05:21

All Paredit changes conflict with that one., right, @U037TPXKBGS? 😃 There is not much we can do about it. Making fundamental changes is tricky, especially in an open source project, where you might need to pause some changes when payed work and whatever competes.

pez12:05:12

To be clear. We can't hold other changes to wait for some big (huge, in this case) change to be done. We'll need to accept that friction in the big-change-branch.

👍 1
pez16:05:53

Dear Calva friends. https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.276 • Fix: https://github.com/BetterThanTomorrow/calva/issues/1735, thanks @edward.partenie! • https://github.com/BetterThanTomorrow/calva/issues/1733`vscode.commands.executeCommand()` The promises fix for Paredit is healthy for Calva in general, and aslo necessary for #joyriders who want to tap into Paredit features in particular. The attached, contrived, example was not possible until now.

catjam 2
👍 1
🎉 1
pez11:05:32

Thanks! 🙏 So awesome that you do this. I left a comment on the PR about adding tests as well. I should have mentioned those, because I find it particularly rewarding to do this kind of change TDD style.