Trust me, it is not a virus 😂

Never saw that, not sure there is anything calva or clojure-lsp can do to avoid that

Maybe that happens because calva downloads a exe automatically

See if you can tell McAfee to ignore it or that it’s okay.

Maybe some virus has been made with GraalVM and the fingerprinting gets close enough? Thanks for letting us know, @U0363NW6C2C. We can't do much about this, but good to know about it happening out there.

It should be configured like so, btw.

"cSpell.languageSettings": [

Slack on mobile…

Looks like there are a number of similar typos in the docs https://github.com/BetterThanTomorrow/calva/search?q=clojurescipt @U0ETXRFEW @U0363NW6C2C You can file issues on the docs in the main Calva repo I think? https://github.com/BetterThanTomorrow/calva/issues (it took me a while to figure out that the docs are in the main repo -- and I'm not certain about it)

Thanks for letting us know @U0363NW6C2C! As @U04V70XH6 said, you can file issues on the Calva GitHub repo. Yes, the docs are in the main Calva repo at docs/site. The docs location as well as information on how to edit the documentation can be found in the wiki, if you’d like to submit a PR for docs changes: https://github.com/BetterThanTomorrow/calva/wiki/How-to-Hack-on-Calva#editing-documentation

How funny that we have three of those. Sort of adds to my suspicion that I am a tiny bit dyslexic. Thanks for reporting @U0363NW6C2C ! And thanks for making that search, @U04V70XH6. How did you figure out that it might be more of those there?

@U0ETXRFEW Whenever I see a weird typo somewhere in a repo, I search for it on GitHub because it's common that if an author's misspells a word once, they will likely do so repeatedly.

(I had a Grammar School education -- and have a "stupid human trick" that I can spot typos in a page of writing without even reading it all)

My school was like Hogwarts -- hundreds of years old, four houses, sorted by academic and sporting ability, very strict, everyone used surnames only 🙂

Yesterday I found out that my spell checker has a weird default setting, showing some “obvious” misspellings through. https://github.com/streetsidesoftware/vscode-spell-checker/issues/345

Maybe I should check the problems count now that I have fixed the configuration.

Thanks, @U04V70XH6. I've filed and issue https://github.com/BetterThanTomorrow/calva/issues/1570

Now fixed. Thanks!

> common that if an author's misspells a word once, they will likely do so repeatedly. Indeed. Someone mispelt a column name in a db we use here, now it's mispelt all over the bloody place, I think I tracked down the culprit.

I do quite a lot of proof reading and author coaching in another part of my life. (I must rely a bit on spell checkers because I have a bit hard to see some obvious spelling errors.) Anyway, despite having done this for decades, I wasn't aware of this that people tend to repeat particular misspellings. Would never have thought of doing a search for that error!

@U0ETXRFEW Peter, did you realize you misspell "Spelling" (as Speling) in the fixes you made in the repo? 🙂 And there is a missing fix, as you can see in https://github.com/BetterThanTomorrow/calva/search?q=clojurescipt

Haha, yes, it's a joke I can't resist making. 😃

And I should fix the README's and such as well. I mostly focused on http://calva.io stuff.

this is what my settings looks like

{
    "telemetry.enableTelemetry": false,
    "git.autofetch": true,
    "sync.autoUpload": true,
    "sync.gist": "895b58b684cbf99ae05554782cdd2405",
    "sync.autoDownload": true,
    "editor.fontFamily": "JetBrains Mono,Menlo, Monaco, 'Courier New', monospace",
    "editor.tabSize": 2,
    "editor.fontLigatures": true,
    "editor.minimap.enabled": false,
    "calva.highlight.bracketColors": ["#aaa", "#f00", "#ffa500", "#ee0", "#0d0", "#0ff", "#f5f5ff", "#ab02ff", "#f3c"],
    "editor.tokenColorCustomizations": {
        "[Darcula]": {
            "textMateRules": [
                {
                    "scope": ["constant.keyword.clojure"],
                    "settings": {
                        "foreground": "#9876aa"
                    }
                }
            ]
        }
    },
    "workbench.colorCustomizations": {
        "statusBar.background" : "#1d3241",
        "statusBar.noFolderBackground" : "#212121"
    },
    "workbench.commandPalette.preserveInput": true,
    "workbench.quickOpen.preserveInput": true,
    "diffEditor.ignoreTrimWhitespace": false,
    "window.openFoldersInNewWindow": "on",
    "calva.clojureLspPath": "/usr/local/bin/clojure-lsp",
    "workbench.colorTheme": "Darcula"
}

Could be that the keywords are not scoped as keywords. There's a developer tool in VS Code for checking what scopes are applied. Something inspect something scopes (I don't quite recall 😄).

seems like it, how can I fix that?

By PR. But I'm not sure about the implications. There are reasons we're not using keyword scope. Iirc most themes make them hard to see by default.

not sure if I understand, we have to change the calva code to get it back?

I was assuming it was there from the docs, its something that changed?

Which docs are you referring to?

https://calva.readthedocs.io/en/bundle-clj-kondo/customizing.html#keyword-highlighting

Oh, wow. That's some old docs site. 😃 I should take it down. It's all on http://calva.io now, FYI.

Anyway, to avoid that all users had to add those settings, I choose another scope to make keywords more visible by default.

variable.other.constant.clojure seems to be the one?

Yes, but I'm guessing from the name that we might be using the same for some literals. So you can't currently target keywords specifically.

You seem to have found some old branch build of the readthedocs, bundle-clj-kondo. Which I can't even remove... Did you find the page from google?

thanks for the info, this one seems to work for now, would be great to have a dedicated one for keywords since they are such an important part of Clojure (and as a Cursive user I got used to have those, to me they help a lot for reading the code)

and yes, I found though Google

Agree it would be great with a dedicated one, but it is a lot to ask of every theme maker that they care about Clojure keywords.

Maybe we can invent a scope, though. I haven't tried that.

we could use variable.other.constant.clojure.keyword

this way it can still fallback to generic other constants when not explicitly defined

I just realized that clojure-lsp might have solved the original problem for us, so we can probably go back to using just constant.keyword.clojure. Not 100% sure, but I do think so. Created an issue for it. https://github.com/BetterThanTomorrow/calva/issues/1571

A new Calva is released with this fix, @wilkerlucio.

@U0ETXRFEW I think I'm having some issue to reach the data from Calva, VSCode says there is an update, but the logo image doesn't load, and on trying to update it fails, any chance something is wrong with the hosting?

(I dunno if the hosting is from Microsoft directly or something else)

manual download worked 🤷

¯\(ツ)/¯

and fix confirmed, highlighting using constant.keyword.clojure 🎉

Awesome. Thanks for bringing this up!

Could it be that there is an evaluation running already that hasn't completed? Try the Interrupt running evaluations command. (Sometimes you might need to issue it twice, I think.

And there are no too beginner of a questions here. 😃

Thanks! I tried that but nothing changed. Also, hovering on any code just shows "Loading..."

Does things like structural editing still work? Try slurp or barf, for instance.

Okay I can replicate this by restarting VS Code. In my project I have a defrecord which uses a protocol. When I change a function on the record from (hc [this] "some hiccup") to (hc [this] [:a {:href "/"} "Something"]) the parens matching and highlighting stops working

Let me try that.

Works here. Probably something else in your file in combination. See if you can minimize the repro.

Let me know if you want a complete source file that replicates the problem

ok

I've been updating the structural editing in the previous release. So if you can try see if you have the problem with version 2.0.246 of Calva, we can see if it is a regression.

great! I was on 2.0.248. After switching to 2.0.246 I don't have this problem

Not good. Even if I'm happy you have a solution. 😃

well thanks anyway!

I really need the repro. If you don't have time to minimize, I can take the whole file.

coming up

Ok, so I started with the contents of core.clj core copy.clj is what I want to change it to When I start typing on line 8 the problem happens.. maybe after the [:a {

Thanks! Let's hope I can figure this out!

you're welcome. thanks for this awesome tool

What OS are you on?

archlinux

Do you have the problems with this text?

(ns example.core)

(defprotocol MyProto
  (hc [this] "some hiccup"))

(defrecord anchor [href title]
  MyProto
  (hc [this] [:a {:href "/"} "Title"]))

yes, the last line

When I change it from (hc [this] "")) to what you posted there.... the problem happens

Did you copy this and paste it?

yes

did you mean when the problem occurred? I was typing when it happened

not copy/paste

There are some funny characters in the text you pasted. I'm trying to figure out if those have anything to do with it.

But I can't reproduce even with those characters still there, so it's probably not what is causing this.

what about just using the two files I uploaded?

That's what I am doing. I think.

If I download the first file instead of copying the text, I don't get the funny characters. But still can't provoke the error...

We know it is there. You don't have the problem with 246 but it's there with 248. But I don't have a clue how to fix it if I can't reproduce... Hmmm.

hmm, would it help to have a screen recording of my repro?

Actually for me it happens when I load up core.clj. Backspace over the double quotes in line 8, then type [ and it happens

So you delete the empty string and start typing the bracket?

I tried that, but things keep working.

Do you have auto-closing brackets on or off, btw?

I am able to reproduce now. If I turn bracket auto-closing off. It starts looking like this and structural editing is completely dead.

This is my smallest repro now:. The vertical bar is the cursor.

([{|)

@U0ETXRFEW are there any specific functions you want me to look at or is it just overall look things over in that file?

It is the backspace function I am mostly suspecting. But I now tried with the commit just before my changes and with your changes still there and then things don't hang, so this regression happens somewhere in my changes.

ahhhh ok

do you want any help debugging?

ok, I was not aware of the auto-closing brackets option. It's probably on the default for 2.0.248

@corasaurus-hex yes, that would be awesome. Though I am getting pretty tired here because late. Can we maybe have a short chat so I can introduce you to the problem area?

sure

so far I'm unable to recreate it

Great! 🙏