Fork me on GitHub
Cora (she/her)04:02:26

making progress on handling nulls is hard, it so deeply factors in everywhere


I can imagine. Let us know if you want to pair on it a bit. Maybe if we can see a way to slice the elephant if we examine it together.

Marc O'Morain11:02:58

Are you working on adding strict checks to the code-base?

Marc O'Morain11:02:14

I’d be happy to help out however I can.

metal 1
❤️ 1
Cora (she/her)14:02:14

I've been doing it off and on! breaking it down into smaller chunks is going to be necessary. hmmm

Cora (she/her)22:03:08

I had a couple false starts figuring out where exactly to start but here's my draft

Cora (she/her)22:03:36

I'm not handling all the strict null checks, and it maintains the current behavior (meaning if the code would have errored because something was missing then I make sure it still errors after these changes).

Cora (she/her)22:03:33

The idea is for people to take on however much of the strict null check work they want while maintaining identical behavior. There is likely to be some work that can't be done without changing behavior but we should save that until the end.

Cora (she/her)22:03:24

You can run npm run watch-with-strict-nulls to start typescript checks with the strict null checks flag turned on

Cora (she/her)22:03:13

or just flip it on in tsconfig.json to get help in your editor. I have to warn you, though, that there are a LOT of issues still. I have a couple branches that got further but I'm going to hold off until this gets merged.

Cora (she/her)22:03:30

@U9A1RLFNV @U02EMBDU2JU if you're interested in having a look, too

👀 1

Awesome! I’ll take a look when I can.

💜 1

To me it looks like the PR is ready to get merged. But I am probably missing something since it is still a draft. 😃


@brdloush Would you mind providing feedback on this PR, since I believe you were the one who worked on the batching of the output window printing?