Fork me on GitHub
#calva
<
2021-10-18
>
Peijing Teh01:10:40

Hi #calva, noob question: how do I see the Clojure documentation within Calva? In Cursive and Chlorine, I was able to refer to the Clojure documentation (or Clojuredocs) within the editor line. This made it really nifty to check if I got the right function or commands using a keyboard shortcut. But i can’t seem to find this within the Calva docs, so it would be great if someone could point me to it please. 🙂 Thanks!

Pratik05:10:52

If you just cmd/ctrl click, it doesn't take you to the clojure docs? For me it does. You can also setup keybindings to have a shortcut to go to the definition

👍 1
pez05:10:53

If it is http://clojuredocs.org examples you are looking for, Calva does not yet provide those. There's this PR where we track this lack. https://github.com/BetterThanTomorrow/calva/issues/689

👍 1
Peijing Teh10:10:11

noted, thanks very much @U0ETXRFEW!

fel-mazo07:10:57

Hi there ! I get a weird bug from time to time where my repl output window doesn't update at all (I've tried refreshing it but doesn't do much) any tips on how I can find the root cause once I get the bug again ?

pez08:10:54

Sounds like something hangs. Have you tried closing the output window and opening it again?

pez08:10:24

That’s for trying to unhang things, for finding the root cause… Do you get inline display of results in the files still, or does that stop working as well?

pez08:10:09

The VS Code dev console might have some clue. (I doubt it a bit, but its worth checking.)

fel-mazo09:10:53

I'll try to check next time. Evaluation works fine but no result is printed (inline nor window) closing the output window and opening it doesn't help either, I generally fix it by running a lein clean on my project and reload vscode (a few times doesn't always work startight away)

pez09:10:16

Sounds awful. Let’s hope we can track this down!

Stuart16:10:28

is is possible you have evaluated something and its taking ages in the background? e.g., if you evaluate an infinite loop, then you won't be able to evaluate anything else. WHen it happens again, you could try right click and try Interrupt Running Evaluation and see if after interupting you can eval stuff again ?? Just a thought

👍 1
fel-mazo08:10:21

thanks for the tip Stuart ! I really don't think so, but I'll check this too

fel-mazo13:10:55

reproduced the bug just now

fel-mazo13:10:25

looked at the console and can't see anything related to this

fel-mazo13:10:16

no long running evals either

valerauko08:10:21

Any idea why Calva's lint tells me aleph.http/post (defined in the library by a macro) is an "unresolved var" while running clj-kondo standalone (with the same config) does not? It complains about occurrences both in app source (`/src`) and in test source (`/test`). If I open the app source while where it complains, it stops complaining about that. However opening the test files (or even running the tests with kaocha from the repl) doesn't have the same effect. Any idea what's going on?

pez08:10:44

Not really. There are a few layers to this. I think @UKFSJSM38 , or someone else #lsp savvy probably has a better idea.

😢 1
ericdallo12:10:55

@UAEH11THP are you using latest clojure-lsp, we fixed a issue related to this recently, also try removing .lsp/.cache and restarting vscode

valerauko12:10:24

how recently is this? i started from a fresh install on friday. where can i check lsp's version?

ericdallo13:10:03

It prints on calva says output I think

ericdallo13:10:24

The most recent is the version from 30/September

ericdallo13:10:33

Anyway, try the cache removal as well

pez13:10:12

Calva defaults to using the latest version. And yes, printed in the Calva says output channel at startup.

valerauko13:10:53

It says latest. I cleared cache and restarted vscode, still the same.

valerauko13:10:38

i can help you debug this if you tell me what to look at. i literally installed vscode for the first time on friday so i have no idea how any of it works

pez13:10:08

When clojure-lsp has started Calva reports the version used. latest is rather the setting.

valerauko13:10:17

ah, that! clojure-lsp 2021.09.30-15.28.01 clj-kondo 2021.09.25

ericdallo13:10:45

the unresolved-var linter is a linter from kondo that If contains cache about that namespace it checks if the function is known or not, running clj-kondo manually only in your project, will make clj-kondo known only your namespaces and not the external dependencies, but with clojure-lsp it scan both

ericdallo13:10:09

I suspect you have a really unresolved-var 😅 could you share your code? or make a tiny repro with the issue?

valerauko13:10:19

(ns lsp-repro
  (:require [clojure.test :refer :all]
            [aleph.http]))

(deftest repro
  (testing "aleph.http is required..."
    (with-redefs [aleph.http/post (constantly (future {:status 200}))]
      (is (= 1 1)))))
if i explicitly :refer [post] it, it then complains about it in the require as well.

ericdallo13:10:12

looks valid to me, but I don't know what is post in that namespace, could you make a minimal repro in a repo? so I can test it as well

ericdallo13:10:40

def-http-method is a macro and clj-kondo doesn't know it defs a symbol in this case

ericdallo13:10:09

you need to configure it via clj-kondo configuration, more details here: https://github.com/clj-kondo/clj-kondo/blob/master/doc/config.md#unrecognized-macros

valerauko13:10:44

i need to do that config for an external library? 😮

ericdallo13:10:51

probably adding this to your .clj-kondo/config.edn will solve it:

{:lint-as {aleph.http/post clojure.core/def}}

ericdallo13:10:59

unless that library exports clj-kondo config, yes

ericdallo13:10:06

and I think this lib doesn't

ericdallo13:10:32

you can open a PR on that lib to export the clj-kondo configu, similar to this lib: https://github.com/nubank/state-flow/blob/master/resources/clj-kondo.exports/nubank/state-flow/config.edn#L1

valerauko13:10:10

alright i'll consider doing that

ericdallo13:10:21

@UAEH11THP I just remeber clojure-lsp has a action for that

valerauko13:10:31

on another note though why does it work when running clj-kondo standalone?

ericdallo13:10:32

if you apply the code action resolve macro as

valerauko13:10:17

sorry i don't know what a code action is?

ericdallo13:10:07

in calva I think the shortcut is ctrl + . ?

valerauko13:10:27

i'll go read the docs haha

bringe04:10:11

@UAEH11THP With your cursor over the macro you can try running the Calva command “Resolve macro as” (ctrl+shift+p brings up the VS Code command palette and you can search there for it).

👍 2
introom15:10:50

Is it possible to by default unfold the outline entries?

pez16:10:35

No idea. ¯\(ツ)

pez16:10:20

A quick settings search says there isn’t.

Fabricio Cozzarolo19:10:59

hello guys! i noticed the last version changed rainbow colors in VSCode.... is there a way to get the old ones?

pez20:10:50

It did? Hmmm, is rainbows part of semantic tokens, @UKFSJSM38?

ericdallo20:10:05

nope, semantic tokens don't touch on parens

ericdallo20:10:42

if so, it could be a issue on vscode-languageclient lib

ericdallo20:10:13

or in Calva if it create the rainbows manually

pez20:10:58

Yes, Calva creates the rainbows very manually. But zero changes made there. Have you activated the built-in rainbows, maybe, @U02EDDCK800?

seancorfield20:10:14

VS Code recently implemented rainbow parens natively -- and after the last Calva update, things did look a bit different to me. Let me double-check my settings (since I thought I had turned things off in Calva since the native stuff was added).

pez20:10:54

The native stuff is fast and all, but not as Clojure aware as Calva’s. So I def think Calva wins as long as you are not editing some huge EDN (in which case Calva croaks anyway).

seancorfield20:10:50

I turned off the Calva highlight indent and that seems to have resolved whatever weird conflict I was seeing -- even tho' the built-in stuff isn't as good as Calva's, it's wicked fast and the speed is more important to me than the look TBH.

pez20:10:50

Did you experience slowness with Calva’s rainbows? You really shouldn’t have…

seancorfield20:10:38

I'd say it "contributes" to some lagginess overall but it's hard to point to just the Calva stuff and say, yeah, it's slow. We certainly have a few large files with a lot of nesting where the shifts in bracket color as you type is "noticeable".

pez20:10:12

Interesting. And you didn’t tell me! 😃

pez20:10:31

It is noticable if you have large structures, though. That is a known fact. For normal Clojure functions, even large ones, it shouldn’t be. It’s single digit milliseconds, allowing for 6o FPS even on quite slow machines.

pez20:10:57

This is good for someone running with Calva’s rainbows to know. If they turn slow for Clojure code, I want to know.

seancorfield20:10:36

We have had a discussion about this but it wasn't a big deal -- and like I say I can't definitively point at this specific feature of Calva and say it is slow. But all these things contribute a little.

seancorfield20:10:11

If I could identify a specific file where just this specific Calva feature could be clearly seen as a problem on its own, I'd share the file with you 🙂

💪 1
Fabricio Cozzarolo20:10:44

may be i expressed myself wrong... i meant by rainbow both the parenthesis and the symbols.... before update i was seeing the keywords in blue and after that in purple. i guess parenthesis are equal than before. i haven't changed anything in vscode config.... but now you mentioned could it be a vscode update that's causing the change?

ericdallo20:10:51

Now it makes sense, yes, this is indeed semantic tokens and it's using the default tokens of vscode for your theme (which I think it makes sense), if Calva wants to customize that it's possible as well

Fabricio Cozzarolo20:10:00

i can barely notice that when i open a file it has blue keywords and changes very quickly to purple... i guess that's an styling config overriding calva's one?

ericdallo20:10:30

yeah, maybe it's a good idea calva customize the keyword one to be similar to when there is no semantic tokens so this flash would not happen

pez20:10:06

I don’t think there is a way for Calva to customize this?

pez20:10:37

But how should Calva know what some theme will be using?

ericdallo20:10:49

it doesn't need to, you just say "use keyword color for this kind of token"

ericdallo21:10:17

For example, this is how Dart/Flutter vscode extension is doing: https://github.com/Dart-Code/Dart-Code/blob/master/package.json#L1452-L1476

seancorfield21:10:56

Ah, that explains what I thought I was seeing today (after the Calva update): keywords changing color. But I wasn't sure whether it was just doing it slower than before or something had actually changed.

pez21:10:04

So what is “this kind of token” that I should say use keyword color for?

ericdallo21:10:47

the token returned from clojure-lsp, which I think is "keyword"

seancorfield21:10:33

Is Calva's highlighting something we can disable?

seancorfield21:10:42

(for me, keywords seem white by default and switch to purple when Calva catches up which is pretty distracting)

pez21:10:59

Nope. Calva provides the language grammar for Clojure. You can only disable the extra highlighting done, like rainbows.

pez21:10:41

You can either disable semantic tokens or wait for us to solve the most glaring flicker issues.

☝️ 1
pez21:10:28

I just need to understand what I should do. So far I don’t get it at all. I should map from something to something, but both those are unknowns for me. I stare at that config and don’t know what is being mapped to what. 😃

pez21:10:16

                   "keyword": [
                        "keyword"
                    ],
What on earth could that be doing?

Fabricio Cozzarolo21:10:17

the flicker is because vscode style is delayed or the inverse is happening?

ericdallo21:10:39

hahah, about vscode me too 🤷 what I know: server return tokens following the LSP spec, for example for :some-foo clojure-lsp returns that token is a keyword , now client can apply a different highlight for that token, for example:

keyword": [
   "entity.name.function.member"
]
this means color the keyword tokens with the vscode "entity.name.function.member" whatever this means in vscode haha

pez21:10:18

@U02EDDCK800 First the built-in (Calva’s) style is there. Then the semantic tokens from clojure-lsp kicks in.

❤️ 1
ericdallo21:10:29

AFAIK "entity.name.function.member" means a color for a function member of the current vscode theme, which could be white for a theme or red for other

pez21:10:10

“property declaration” is a semantic token?

ericdallo21:10:16

Therefore, we just need to know what vscode highlighting the Clojure default uses and make the 1:1 for semantic tokens

pez21:10:43

I know exactly what the clojure defaults are. I wrote them. 😃

ericdallo21:10:21

Good! so you will know better than me what to use :) this is the table for semantic tokens: https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#predefined-textmate-scope-mappings

pez21:10:34

And you wrote the semantic token stuff. Between us we should be able to fix this.

ericdallo21:10:42

you just need to remap for those you want to change

ericdallo21:10:49

> And you wrote the semantic token stuff. Between us we should be able to fix this. Yes !

pez21:10:04

That table is nice, but I’ll need to know what clojure-lsp is using for what clojure construct. Then map to what the Textmate grammar is using for the same construct.

ericdallo21:10:38

you can easily see that with the LSP command cursorInfo :)

pez21:10:05

Also, the textmate grammar does not so far distinguish between alias or ns and symbol. So we won’t be able to map this fully.

ericdallo21:10:06

@U0ETXRFEW I think the biggest differente ATM is the keywords and macros/functions only

ericdallo21:10:26

mapping those should remove almost all blink

pez21:10:16

I don’t know how to run that lsp command.

pez21:10:40

Should I add the command to Calva?

ericdallo21:10:46

I think Calva only implements the serverInfo

ericdallo21:10:01

yes, just follow the same @U9A1RLFNV did for serverInfo

pez21:10:36

So, you can’t just tell me instead? 😃 .

ericdallo21:10:32

haha there is nothing special, you just need to call the lsp command cursorInfo with your cursor on the symbol you wnat to get info :man-shrugging:

ericdallo21:10:44

how to call that command on Calva/vscode, I'm not sure

ericdallo21:10:57

that's why I suggested checking how @U9A1RLFNV implemente it on calva for serverInfo

pez21:10:46

Yes, I can implement that command. Seems like a lot of work where you could just tell me instead. But maybe there is something I don’t get here still.

ericdallo21:10:14

I can say what tokens clojure-lsp return for a specific code as well, is just that if you want to change too much things the safest would be to check what clojure-lsp return

ericdallo21:10:22

but for a piece of code or another I can help :)

pez21:10:45

Actually I don’t need to add this command to Calva. VS Code has something built in:

ericdallo21:10:16

that's what I thought and that's why I told to use the command, nice!

ericdallo21:10:45

oh this is not the command, looks a nice vscode thing

pez21:10:12

Yes, but it is showing funny stuff for the textmate scopes…

pez21:10:25

But that’s all my. own fault. I wanted defs to look special. Which they don’t do any longer with semantic tokens, so I got confused. Hmmm. Maybe we should disable semantic tokens until we (well I) understand what’s going on better. Right now it feels like I lose control over Calva’s UI/Ux.

ericdallo21:10:00

Sure, Feel free :)

seancorfield21:10:52

FWIW, I changed Settings > Editor > Semantic Highlighting: Enabled to false and that "solved" the problem. /cc @U02EDDCK800

🙌 1
seancorfield21:10:43

It would be nice to have it configuredByTheme and not have Calva mess with it but... 🙂

pez21:10:44

Don’t know what you mean with configuredByTheme? The themes only provide the looks, right?

pez21:10:18

Actually you should be able to just set it to configuredByTheme and that should fix it as long as your theme does not have semantic token support.

seancorfield21:10:09

It was configuredBytheme -- that what caused the conflict with Calva.

seancorfield21:10:23

(well, once LSP got updated)

seancorfield21:10:32

I can do a screenshare with you, if you're interested?

pez21:10:03

I see it on my machine. 😃 I just don’t frame it as a conflict or Calva messing with anything.

pez21:10:26

If you tried it with a clojure-lsp only extension you would see the same thing. With Calva at least we have the possibility to soften the flicker.

seancorfield22:10:10

Given that, with that setting as false, I see variables (symbols) and keywords as white -- is that Calva's default colors? And when I enable that setting and see variables (symbols) and keywords switch to light blue and purple respectively, that's the theme's semantic highlighting, driven by LSP? So the "lag" is with the running of LSP and the editor changing the code colors to match?

pez22:10:47

Calva doesn’t have default colors. But, yes. Otherwise I think you summarized it like I how I understand things.

pez22:10:23

What we can do is to tell VS Code that when Calva has given something scope X it is to be treated by the theme the same as semantic token Y.

pez22:10:33

Then the theme would render things pretty similar in the two systems, and the only change we would see is when the semantic tokens are richer in their understanding of the code than the textmate grammar is. E.g. clojure-lsp knows when something is a macro, so we can have that show once LSP has provided the info.

seancorfield22:10:54

Currently, does Calva set symbols (such as local bindings) and keywords to the same "color" or are they semantically different?

pez22:10:33

Actually it doesn’t. It is your theme that colors them the same.

seancorfield22:10:02

(with semantic highlighting, they are different colors, but I haven't managed to find a theme where they are different colors without semantic highlighting -- which is why I asked)

pez22:10:44

For me they color different with bot Light + and Dark +, as well as with the Github themes.

seancorfield22:10:54

Is that with that semantic highlighting enabled? Or disabled?

pez22:10:12

Disabled.

pez22:10:31

Semantic tokens changes everything. 😃

pez22:10:59

Interesting. Let me check my settings…

seancorfield22:10:31

With semantic highlighting ENABLED (configuredByTheme):

seancorfield22:10:22

Pale blue symbols. Purple keywords. Also and -- a macro -- changes from yellow (like a function above) to blue.

ericdallo22:10:29

All of those could be changed on calva (or clojure-lsp if clojure-lsp is returning a really odd token )

seancorfield22:10:31

That's on macOS if it makes a difference. Latest VS Code, latest Calva, latest LSP.

pez22:10:34

How did you get all those settings on the same screenshot?

seancorfield22:10:39

I filtered settings by theme

seancorfield22:10:18

I prefer the different colors so I'll probably keep the configuredByTheme semantic tokens enabled and live with the laggy change in colors.

pez22:10:50

Here’s what it looks like on my mac.

pez22:10:59

Maybe you have some other Clojure extension that provides highlighting grammar?

seancorfield22:10:01

I am pretty sure I do not.

seancorfield22:10:10

Clover doesn't contribute highlighting.

seancorfield22:10:27

Do you perhaps have anything custom in your settings.json file?

pez22:10:45

Nope. Only thing in that direction I have is

"workbench.colorCustomizations": {
        "terminal.ansiRed": "#ff7a5a"
    },
Which I can recommend. Makes error text readable in the terminal.

seancorfield22:10:03

I don't use the built in terminal for anything 🙂

pez22:10:46

¯\(ツ)

ericdallo22:10:17

what's the issue with @U04V70XH6 when disabled? I checked the print but I couldn't figure it out

seancorfield22:10:43

@UKFSJSM38 with semantic highlighting disabled, symbols and keywords look the same (white -- in the dark+ theme); with semantic highlighting configuredByTheme, symbols and keywords look different (pale blue and purple respectively)

pez22:10:26

Compare with my screenshot and you should see it.

ericdallo22:10:41

got it, that's really odd, my vscode with disabled semantic tokens looks the same of @U0ETXRFEW

pez22:10:09

Yes, I have not seen that issue before.

seancorfield22:10:05

FWIW, the colors are exactly the same on my Windows/WSL2 setup -- which has settings/extensions sync'd with my Mac.

seancorfield22:10:33

(and the behavior with semantic highlighting disabled vs configuredByTheme is identical too)

seancorfield22:10:34

@U0ETXRFEW you showed how to get VS Code to tell you what a symbol is/what styles are applied to it? What was that? Maybe I can debug why I don't see blue keywords locally?

pez22:10:39

Command palette -> Developer: Inspect Editor Tokens and Scopes

seancorfield23:10:53

OK, here's what I see for a keyword (white -- semantic highlighting disabled):

seancorfield23:10:14

And here's what I see for a local sy,bol:

pez23:10:29

The default theme colors keyword the same as symbol which is why Calva’s grammar uses the scope variable.other.constant.clojure for keywords. Not happening for you, but anyway.

seancorfield23:10:11

I disabled all my other extensions and keywords turned blue 🙂 So now I just need to figure out which one is causing this...

pez23:10:49

There is an extension disect feature I think…

seancorfield23:10:16

Ugh! It's something in Clover, apparently. I didn't think that contributed anything to code coloring 😞

pez23:10:43

I don’t think it does. Not directly. But it might trigger the built-in Clojure extension to provide its grammar.

pez23:10:00

Not at all sure about this, but the built-in extensions are special.

pez23:10:30

We can win over VS Code if @U3Y18N0UC picks up Calvas textmate grammar json and places it in Clover. 😃 We will need to sync now and then when we update the grammar, but that is very seldom.

ericdallo23:10:34

For now you could disable syntax changing in clover? Is there any setting to disable that in clover?

pez23:10:51

Probably not. Clover is not contributing syntax, I think. This is VS Code being stupid.

mauricio.szabo23:10:58

Hey @U0ETXRFEW, just tell me how to do it and I'll do 🙂. I'm quite unfamiliar on how to make this things work...

pez23:10:46

Hi @U3Y18N0UC! 👋 🙏

pez23:10:33

Calva has this in it’s “contributes” map in the manifest:

"grammars": [
            {
                "language": "clojure",
                "scopeName": "source.clojure",
                "path": "./clojure.tmLanguage.json"
            }
        ],

pez23:10:57

If Clover has the same and you pluck out the clojure.tmLanguage.json from Calva, I think it won’t matter which of the extensions wins the race.

seancorfield23:10:09

(! 676)-> find ~/.vscode/extensions -name clojure.tmLanguage.json
/Users/sean/.vscode/extensions/betterthantomorrow.calva-2.0.218/clojure.tmLanguage.json
/Users/sean/.vscode/extensions/mauricioszabo.clover-0.2.5/clojure.tmLanguage.json

pez23:10:04

Ah, so maybe Clover does provide grammar?

seancorfield23:10:11

I copied Calva's file to Clover's install and problem is solved! 🙂

🎉 1
pez23:10:43

Aha 😃

seancorfield23:10:43

There were quite a few differences in patterns and what they resolved to.

pez23:10:56

I think it is best to also provide that piece in the manifest.

seancorfield23:10:18

@U3Y18N0UC So I guess the Calva version of the textMate grammar is more recent than Clover's? (and maybe Chlorine's too?)

seancorfield23:10:30

Clover has

"grammars": [
			{
				"language": "clojure",
				"scopeName": "source.clojure",
				"path": "./clojure.tmLanguage.json"
			}
		],

seancorfield23:10:01

I just didn't see it in VS Code's list of what an extension contributes...

pez23:10:06

I see. Well, then a solution is to remove that. Depends. But it might be super similar to the VS Code built in one (which is built from Atom’s default Clojure grammar), so removing it would make things look the same for Clover only users, and let Calva + Clover users have Calva’s.

pez23:10:20

Haha, well, maybe there was a very good reason. But also maybe it is a remnant from when @U3Y18N0UC and I tried to bring over some Calva static things to Clover.

seancorfield23:10:34

For now I have a solution, until Clover gets updated.

pez23:10:35

A night full of TILs for me here.

😄 1
pez23:10:07

Anyway, lots of threshing from my side. But knowing what we now know. Just refreshing Clover’s copy of the grammar file might be the way to go, @U3Y18N0UC. It has since been removed from source control, but it’s there in the Calva extension folder.

pez23:10:02

There’s some Calva prompt shenanigans in the grammar, but it’s quite tricky to type the prompt manually so should not cause any troubles.

ericdallo23:10:19

Code-wise LGTM

pez23:10:57

@U02EDDCK800, @U04V70XH6, can you test this VSIX and see if it makes most of the flicker go away? Let me know which things still change visibly, and we might be able to fix some of those too. https://15333-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.219-1348-token-scope-map-250a7ec6.vsix

seancorfield00:10:56

Big improvement! Keywords "stay" blue, local symbols change from white to pale blue.

seancorfield00:10:15

Macro invocations switch from yellow (function-like) to blue (per known, built-in macro usage like let, if etc).

seancorfield00:10:52

(I tested with Clover disabled, just in case that might affect Calva's grammar/highlighting but it doesn't seem to now that both are the same)

seancorfield00:10:57

Also, aliases in qualified names change from yellow to green (at least in a function call -- where yellow is the default for a function call).

pez00:10:25

This change should be the same with our without Clover as long as you have copied that grammar file. I didn't update the grammar, just provided a mapping from semantic tokens to grammar scopes. It took me quite a while to understand the concept, but now it makes sense to me. 😀

seancorfield00:10:32

The local symbol change is a bit jarring but white to pale blue isn't too bad. The other changes are fine.

pez00:10:58

Some changes are inevitable. Not sure if we can fix the local symbols. It's probably jarring in some themes...

pez00:10:17

If you examine the scopes and tokens, maybe you can see if a mapping can fix it. I'm afk now.

seancorfield00:10:02

Yeah, I understand that some semantic changes are always going to be delayed until LSP has had a chance to run. I'm at the end of my work day here. Might look at it tomorrow.

pez00:10:20

Me too! Talk tomorrow. Thanks for all the help!

Fabricio Cozzarolo01:10:34

changing Settings > Editor > Semantic Highlighting: Enabled to `false` worked for me too, it looks exactly the same as before. 😃

mauricio.szabo12:10:17

Ok, so what should be the best course of action here? Do I remove the clojure.tmLanguage.json or do I update with the Calva's latest version? WDYT @U0ETXRFEW @U04V70XH6? I have to say, I'm still grasping all these "grammar" and "VSCode API" things, so the answer for "why things are like this" will probably be "because that's what worked at the time" :rolling_on_the_floor_laughing:

pez12:10:29

Haha, yes, it’s a lot like that. 😃

pez12:10:05

Let’s see. Clover probably has two categories of users: 1. They use only Clover 2. They use Clover together with Calva, possibly inspired by @U04V70XH6’s config, and by that proxy clojure-lsp. If you remove Clover’s grammar contributions, category 1 will get VS Code default Clojure syntax highlighting. And category 2 will get Calva’s + clojure-lsp add-ons. If you keep the grammar contrib, category 1 will get Calvas syntax highlight, and category 2 will get Calva + clojure-lsp.

pez12:10:24

I think that points at removing. The differences between built-in and Calva’s highlighting are maybe not big enough to carry the extra maintenance burden.

mauricio.szabo12:10:20

Ok, I'll remove it 🙂. Thanks for the help!

mauricio.szabo13:10:54

Published today a new version of Clover without the grammar contributions, so it'll play nice with Calva 🙂

🎉 3