Fork me on GitHub
#calva
<
2021-04-13
>
pez06:04:59

This will soon be default with Calva Jack-in. But you can use it right now by temporarily changing your jack-in dependency settings. It would be nice if some of you tried that and let us know how you fare. Of course, if you use Calva Connect, you are encouraged to test this as well. 😃

pez13:04:33

Please try this out, Calva and clojure-lsp friends.

calva 6
❤️ 6
clojure-lsp 4
ericdallo13:04:46

@U9A1RLFNV The way I implemented the custom snippets was a little tricky, It'd be nice to check if everything works on Calva side indeed

👍 2
pez14:04:41

I don’t get any snippet completion. Do I need to do something to enable it? Or do we maybe need to do something in Calva to enable it?

ericdallo14:04:02

the only validation clojure-lsp does, is the suggested by the https://microsoft.github.io/language-server-protocol/specification#textDocument_completion about checking if client has support for that via the boolean snippetSupport

ericdallo14:04:13

you may need to check if you are sending that as true

pez14:04:54

Will do. We might want to do this opt-in for the users.

👍 2
seancorfield21:04:09

I noticed that indentation of multi-line docstrings changed recently. It used to be like this:

(defn foo
  "This is line one and when you press enter
  you got this indentation, aligned with the quote"
  [args]
  42)
but now you get this:
(defn foo
  "This is line one and when you press enter
   you get three spaces and you're aligned with the word instead"
  [args]
  42)
Is this a deliberate change and, if so, what is the justification for it?

bringe21:04:51

> justification No pun intended? 😄 Really though, I'm unaware of anything that changed that, but @U0ETXRFEW might know since he's recently added some paredit changes/improvements.

seancorfield21:04:05

No pun intended 😞

🙃 2
pez04:04:59

This could be a side effect from when we added an option to prevent unbalanced closing at quotes. I'll have a look.

seancorfield05:04:24

FWIW, VS Code prompted me to restart for an update — and now I can’t reproduce it: docstrings seem to be working just fine, exactly as they were before.

seancorfield05:04:22

And maybe I’m having that kind of day: my Canary builds of Microsoft Edge were also doing weird things, so I reported bugs to MS, then restarted to pick up a new version and the bugs all went away 👀

🙂 3
pez05:04:54

Funny it only hit docstrings. Happy it got resolved! I was utterly without clues. 😀

seancorfield05:04:16

So am I at this point :face_with_rolling_eyes:

seancorfield21:04:23

(pretty much all the Clojure code I’ve seen uses that first indentation style so that’s why this stood out as a noticeable change and it “looked weird”!)