Fork me on GitHub
#calva
<
2021-01-24
>
roelof10:01:08

he, from today I see this error :

roelof10:01:27

no idea if it's a calva issue

pez13:01:01

Anyone testing out the fix for line-comments should be using this VSIX instead of the one above: https://10367-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.154-971-language-configuration-5e4302e3.vsix And if you have used the one above you should uninstall it. This is because the above one uses a release version number. I’m sorry about that, but Circle CI was down yesterday and I missed a step when building the VSIX locally.

agold14:01:08

Although the link is to a vsix, when I download I get a zip file containing many things but not a vsix. Do I just change the extension to vsix? And by the way, is there any harm to keeping the version I downloaded yesterday, which is working well. It did install as 2.0.154, but I'm not sure what the implications of that are.

pez16:01:59

I didn't know it would download as a zip, but changing file extension should work. No harm in keeping the one you have other than that I am unsure how it will behave when we release the real 154, which probably will contain other changes. But maybe we will find out soon.

agold16:01:46

ok, no problem. Thanks again!

bringe19:01:41

Yeah, the CircleCI vsix downloads starting coming down as .zip some time ago, and every time I have to change the file extension to .vsix.

6
pez19:01:36

Have we updated the wiki about this?

bringe19:01:25

Just did 😃

roelof13:01:06

can happen

6
roelof18:01:35

@pez Did you see my error. It happens when starting up calva

ericdallo18:01:55

It's related with clojure-lsp , where it failed to lookup the classpath, we had some issues with windows users on this, but it was fixed recently

ericdallo18:01:04

are you using latest Calva version?

roelof18:01:24

look like it I have 2.0.153

roelof19:01:52

oke, I tested it more

roelof19:01:10

and I see it only on 1 project which uses clokure cli

roelof19:01:54

the edn file looks like this :

{:source-paths ["src"]

 :dependencies [[binaryage/devtools "0.9.10"]
                [proto-repl "0.3.1"]
                [reagent "0.8.0"]]

 :nrepl        {:port 3333}

 :builds
 {:app {:target :browser
        :output-dir "public/js"
        :asset-path "/js"

        :modules
        {:main
         {:entries [giggin.core]}}

        :devtools
        {:after-load  giggin.core/main
         :http-root   "public"
         :http-port   3000}}}}

roelof19:01:38

Should I put this project on github so you calva experts can take a look at it

ericdallo19:01:06

Yeah and link it on that issue would be super helpful 🙂

bringe19:01:01

Another thing that would be really helpful is looking in /tmp/clojure-lsp.out for the error that occurred during classpath lookup. It should contain "classpath" so you can search for that. If you add that to the issue that would be great.

roelof19:01:19

you mean the issue you linked me too

roelof19:01:51

found the error

java.io.IOException: Cannot run program "shadow-cljs" (in directory "/home/roelof/learn-reagent-course-files/giggin"): error=2, No such file or directory

roelof19:01:16

wierd. that is package and not a file

bringe19:01:47

It means you need to install the shadow-cljs command line tool

bringe19:01:05

See the shadow-cljs docs for how, but I think it's just a global npm package install

bringe19:01:27

It's trying to run shadow-cljs to get the classpath, but if you don't have it installed, it won't work

bringe19:01:33

@UKFSJSM38 Do you think it would be too verbose to add the error message to the warning message sent from the server? It may save some confusion/questions/time

bringe19:01:50

Or even a link (can links be placed in those?) to docs explaining where to find the error and how to fix

bringe19:01:23

Not sure if either are a good idea

ericdallo19:01:38

links are not supported for all clients so I'd avoid, but if a error message is simple and easy to get, we can add it, but I'd prefer to keep that on clojure-lsp.out and warn user to check that file on the error message, WDYT?

bringe19:01:24

Yeah, I think pointing them to that would be good for sure

👍 3
bringe19:01:55

I do wonder if the global shadow-cljs is the best way to get the classpath for those projects. Some people may not have it installed but may use npx shadow-cljs or something else. Not sure how else this can be done but if it can be done via clj or lein in conjunction with shadow that might be a more broadly working solution

bringe19:01:53

Another idea is having fallback options for shadow, but this adds complexity that I'm not sure is a good idea. Like try shadow-cljs - if this fails try npx shadow-cljs etc

ericdallo19:01:27

I see, there are too many ways indeed, it'd be cool if clojure-lsp would be smart to just make it work , and maybe provide an option/flag to specify the shadow-cljs command, then calva could just make a bridge for that settings too

ericdallo19:01:41

I don't know too much about shadow-cljs though

roelof19:01:13

hmm, I thought it was installed

roelof19:01:19

but I will do it again

roelof19:01:20

installed it but the error still appearing

bringe19:01:35

Hmm yeah an issue and your repro steps would be great

roelof19:01:25

moment.repro steps? How do you mean that

bringe20:01:20

Thanks! I just meant what steps lead up to the error, but what you provided is good

roelof20:01:08

happy to hear

roelof20:01:26

hope it can be solved soon

roelof20:01:21

if you need more info im happy to give

👍 3
clyfe18:01:26

> Classpath lookup failed in clojure-lsp. Some features may not work correctly. I started seeing it too; it does not show on all projects. Shows with https://github.com/nextjournal/clojure-mode-demo/ for example

bringe19:01:48

If you look in /tmp/clojure-lsp.out you can see what the error was when it failed. In some cases it means the command line tool clojure-lsp is using to get the classpath is not installed, so the command is not found, like shadow-cljs

👍 6
clyfe19:01:52

> " (|)" + backspace = ""; should yield " " (& 2nd backspace to delete the space) A change for calva? Or for my calva-extras?

pez20:01:32

There are a few more things in how editing behaves inside strings that we should note down in an issue. Please start it off by creating an issue for this.

grumplet22:01:16

Any progress on a better workflow for cljs+figwheel-main + webpack jack-in? I did send in a docs PR a while ago explaining my get around for this, but it’s a sub-optimal approach and I think that PR got left behind when you moved the docs github. Those docs are still in https://github.com/gmp26/calva-docs if you want to take another look.

pez22:01:17

Oh. good that you reminded about it. We will pull in the docs enhancements. Work on the actual jack-in is not really on my schedule right now. But I would welcome an issue about it so that I or someone else can pick it up when we have time and knowledge enough.