Fork me on GitHub

Yeah it works 😍 🎉❤️calva I found it impressive to see how you and the nice people from clojure-lsp have worked together on this, well done!!!

❤️ 3

Thanks! We've enjoyed working with them


@pez I see this behaviour when aborting a jack-in in versions since 2.0.134 (which I keep reverting to - it just works better than the clojure-lsp versions). Control-C no longer cleans up the Jack-in process neatly.

clojure -Sdeps '{:deps {nrepl/nrepl {:mvn/version "0.8.3"} cider/cider-nrepl {:mvn/version "0.25.7"} cider/piggieback {:mvn/version "0.5.2"}}}' -A:fig -m nrepl.cmdline --middleware "[cider.nrepl/cider-middleware cider.piggieback/wrap-cljs-repl]"
Downloading: cider/cider-nrepl/0.25.7/cider-nrepl-0.25.7.pom from clojars
Downloading: cider/cider-nrepl/0.25.7/cider-nrepl-0.25.7.jar from clojars
WARNING: When invoking clojure.main, use -M
nREPL server started on port 50359 on host localhost - 
2021-01-22 10:55:00.178:INFO::nREPL-session-1b6b6926-626d-4c3c-a54b-f6a1a8b06996: Logging initialized @35479ms to org.eclipse.jetty.util.log.StdErrLog

^CKilling the Jack-in process
Jack-in process exited. Status: 143
^CKilling the Jack-in process
^CKilling the Jack-in process


Is it not cleaning it up or is it just bad at showing you that it is cleaned up? (iirc I don’t check for if the process is alive before giving that message.)


Well, in 2.0.134 ^C will allow the terminal to be reused. In clojure-lsp versions, the termnal does not return to a usable state and has to be closed.


2.0.134 behaviour was:

Terminal will be reused by tasks, press any key to close it.
Doing so allows the terminal to be reused.


In both I see

; Jack-in done.
; nREPL Connection was closed
in output.calva-repl.


The terminal does get reused if there is a fresh jack-in, but is unavailable for command entry.


Sounds like it behaves as intended, but is a bit confusing in how it works and communicates. It is a very limited terminal there. It is a pseudoterminal where I have implemented only the minimal amount of input handling (ctrl+c and that’s it). I probably should mimic that behaviour with closing the terminal on any further input.


OK thanks - I’ll give the latest another go. I’m very glad to see that those pesky clojure-lsp startup messages seem to have disappeared. At first it felt really clunky having to cancel those in every window for no perceivable benefit over clj-kondo.


Yeah, it is supposed to give its enhancement without all that shouting. Even if the enhancements are quite huge.


@pez @brandon.ringe This should fix some issues from clojure-lsp, I'll check the issues related and comment, it'd be really helpful if you do some tests from Calva side too 😄

❤️ 3
metal 3

After upgrade to 2.0.153, typing a quotation mark (") in a cljs file no longer closes the quote with a matching quotation mark. I believe this is a change. Was it deliberate? How do I get back the matching pair behavior? Parentheses and brackets still pair correctly.


works for me on v2.0.153


I've tried to track this down with no luck. I changed editor.AutoClosingQuotes to always from "language defined", but this did not work. Quotes are autoclosing in Python, but not in cljs since upgrade to 2.0.153. Is there a Calva setting that affects this? Parens and brackets still autoclose.


Auto close quote is working correctly on my Mac with 2.0.153 but not on Linux(Ubuntu/WSL), as outlined above.


I'm on Ubuntu


@UCCHXTXV4 Do you know any setting that might affect this behavior?


No. Try to comment all the users settings see if it works.


Tried it, no joy. This is baffling. Thanks for help.


How about if you uninstall Calva?


Uninstalled, still no auto close quote, reinstalled, no change.


This is probably the same issue as this one:


Please add a comment to that issue @U2CR1J4UV


Where is the Calva PR template set up? I wanted to show it to some people because I think it's really good. I was expecting to find it here but apparently not...


Nice! It’s in the docs directory.

Robert Randolph18:01:27

I just installed Calva and is it correct that Evaluate Top Level Form (defun) is mapped to enter? If so, how is that supposed to work?



Robert Randolph19:01:40

alt-enter works but, the hotkey is listed as enter everywhere in vs-code


It's a context thing I believe. If your cursor is in the output/repl window and after the last form after the prompt, then enter will eval the form. If your cursor is elsewhere, it won't


To make the prompt eval behave more like a terminal repl prompt

Robert Randolph20:01:13

The problem for me is that in the command palette and in key bindings, it only shows as enter. So there's no path to discoverability that I can see.

Robert Randolph20:01:27

it doesn't matter which window is focused, visible or that the cursor is over


Oh wow, I see that too... if you wouldn't mind creating an issue so we can track this, that would be great.


It sounds like a VS Code issue. I would start with looking what had been reported there.

Robert Randolph17:01:23

This is strange, I just looked on another computer and it's showing option-enter. I don't (yet?) understand the difference between these machines. Will look at it at work tomorrow.


@ericdallo When I get around to it in the coming days/week I'll test each issue related to that kondo PR.

❤️ 3

Nice! It'd super helpful!