Fork me on GitHub
#calva
<
2021-01-22
>
Stefan06:01:57

Yeah it works 😍 🎉❤️calva I found it impressive to see how you and the nice people from clojure-lsp have worked together on this, well done!!!

❤️ 3
bringe20:01:08

Thanks! We've enjoyed working with them

grumplet11:01:48

@pez I see this behaviour when aborting a jack-in in versions since 2.0.134 (which I keep reverting to - it just works better than the clojure-lsp versions). Control-C no longer cleans up the Jack-in process neatly.

clojure -Sdeps '{:deps {nrepl/nrepl {:mvn/version "0.8.3"} cider/cider-nrepl {:mvn/version "0.25.7"} cider/piggieback {:mvn/version "0.5.2"}}}' -A:fig -m nrepl.cmdline --middleware "[cider.nrepl/cider-middleware cider.piggieback/wrap-cljs-repl]"
Downloading: cider/cider-nrepl/0.25.7/cider-nrepl-0.25.7.pom from clojars
Downloading: cider/cider-nrepl/0.25.7/cider-nrepl-0.25.7.jar from clojars
WARNING: When invoking clojure.main, use -M
nREPL server started on port 50359 on host localhost - 
2021-01-22 10:55:00.178:INFO::nREPL-session-1b6b6926-626d-4c3c-a54b-f6a1a8b06996: Logging initialized @35479ms to org.eclipse.jetty.util.log.StdErrLog

^CKilling the Jack-in process
Jack-in process exited. Status: 143
^CKilling the Jack-in process
^CKilling the Jack-in process

pez12:01:31

Is it not cleaning it up or is it just bad at showing you that it is cleaned up? (iirc I don’t check for if the process is alive before giving that message.)

grumplet14:01:36

Well, in 2.0.134 ^C will allow the terminal to be reused. In clojure-lsp versions, the termnal does not return to a usable state and has to be closed.

grumplet14:01:29

2.0.134 behaviour was:

^C
Terminal will be reused by tasks, press any key to close it.
Doing so allows the terminal to be reused.

grumplet14:01:44

In both I see

clj꞉user꞉> 
; Jack-in done.
clj꞉user꞉> 
; nREPL Connection was closed
in output.calva-repl.

grumplet14:01:55

The terminal does get reused if there is a fresh jack-in, but is unavailable for command entry.

pez14:01:17

Sounds like it behaves as intended, but is a bit confusing in how it works and communicates. It is a very limited terminal there. It is a pseudoterminal where I have implemented only the minimal amount of input handling (ctrl+c and that’s it). I probably should mimic that behaviour with closing the terminal on any further input.

grumplet22:01:44

OK thanks - I’ll give the latest another go. I’m very glad to see that those pesky clojure-lsp startup messages seem to have disappeared. At first it felt really clunky having to cancel those in every window for no perceivable benefit over clj-kondo.

pez22:01:57

Yeah, it is supposed to give its enhancement without all that shouting. Even if the enhancements are quite huge.

ericdallo13:01:12

@pez @brandon.ringe This should fix some issues from clojure-lsp, I'll check the issues related and comment, it'd be really helpful if you do some tests from Calva side too 😄

❤️ 3
metal 3
agold13:01:36

After upgrade to 2.0.153, typing a quotation mark (") in a cljs file no longer closes the quote with a matching quotation mark. I believe this is a change. Was it deliberate? How do I get back the matching pair behavior? Parentheses and brackets still pair correctly.

clyfe14:01:19

works for me on v2.0.153

agold16:01:29

I've tried to track this down with no luck. I changed editor.AutoClosingQuotes to always from "language defined", but this did not work. Quotes are autoclosing in Python, but not in cljs since upgrade to 2.0.153. Is there a Calva setting that affects this? Parens and brackets still autoclose.

agold16:01:24

Auto close quote is working correctly on my Mac with 2.0.153 but not on Linux(Ubuntu/WSL), as outlined above.

clyfe17:01:55

I'm on Ubuntu

agold17:01:55

@UCCHXTXV4 Do you know any setting that might affect this behavior?

clyfe17:01:55

No. Try to comment all the users settings see if it works.

agold18:01:07

Tried it, no joy. This is baffling. Thanks for help.

clyfe18:01:56

How about if you uninstall Calva?

agold18:01:28

Uninstalled, still no auto close quote, reinstalled, no change.

pez03:01:56

This is probably the same issue as this one: https://github.com/BetterThanTomorrow/calva/issues/971

pez03:01:36

Please add a comment to that issue @U2CR1J4UV

plexus14:01:15

Where is the Calva PR template set up? I wanted to show it to some people because I think it's really good. I was expecting to find it here but apparently not... https://github.com/BetterThanTomorrow/calva/tree/dev/.github

pez15:01:36

Nice! It’s in the docs directory.

Robert Randolph18:01:27

I just installed Calva and is it correct that Evaluate Top Level Form (defun) is mapped to enter? If so, how is that supposed to work?

clyfe18:01:18

alt+enter

Robert Randolph19:01:40

alt-enter works but, the hotkey is listed as enter everywhere in vs-code

bringe20:01:49

It's a context thing I believe. If your cursor is in the output/repl window and after the last form after the prompt, then enter will eval the form. If your cursor is elsewhere, it won't

bringe20:01:16

To make the prompt eval behave more like a terminal repl prompt

Robert Randolph20:01:13

The problem for me is that in the command palette and in key bindings, it only shows as enter. So there's no path to discoverability that I can see.

Robert Randolph20:01:27

it doesn't matter which window is focused, visible or that the cursor is over

bringe21:01:39

Oh wow, I see that too... if you wouldn't mind creating an issue so we can track this, that would be great.

pez03:01:30

It sounds like a VS Code issue. I would start with looking what had been reported there.

Robert Randolph17:01:23

This is strange, I just looked on another computer and it's showing option-enter. I don't (yet?) understand the difference between these machines. Will look at it at work tomorrow.

bringe21:01:54

@ericdallo When I get around to it in the coming days/week I'll test each issue related to that kondo PR.

❤️ 3
ericdallo21:01:44

Nice! It'd super helpful!