Fork me on GitHub
#calva
<
2020-12-31
>
bringe02:12:31

Calva version 2.0.143 is out with the following changes. Windows users, please try out navigating into a jar dependency (Go to Definition), and try out one of the new https://calva.io/refactoring/, and let us know if you have any issues. • Update clojure-lsp to include https://github.com/clojure-lsp/clojure-lsp/issues/223 • Fix: https://github.com/BetterThanTomorrow/calva/issues/911https://github.com/BetterThanTomorrow/calva/issues/815

👍 3
practicalli-john04:12:27

Is there a way to disable clojure-lsp in Calva? I just updated Calva and am experiencing several Gb of RAM being used by the clojure-lsp process on one project. The project code is not that complicated although I believe the 4 dependencies have quite a few dependencies themselves. It seems to be taking quite a time to process too, although at least its not blocking.

👍 3
pez17:12:44

No way to disable it currently, @jr0cket. Please file an issue about it.

bringe17:12:51

@jr0cket I've been thinking lately this would be requested due to memory usage, and maybe some people just don't want it to start for certain projects

bringe17:12:40

I think a simple setting would be good to enable/disable. Haven't thought it through yet though

ericdallo17:12:02

We could also add a flag in clojure-lsp to do not scans jars early (which take most of the time to start)

bringe17:12:19

That's an interesting idea

bringe17:12:41

But if a user tries to navigate to a jar dep after lsp has started, but before the dep has been scanned, what would/should happen?

ericdallo17:12:22

THat's what we need to test it 😅

👍 3
😄 3
ericdallo18:12:21

Good news, I tested and reduced a lot the startup time... I'll try to find the drawbacks of doing this.. Another aproach is no async crawling jars using clojure.async

ericdallo20:12:17

Well, I managed to make the crawling jars async using clojure.async , I'm adding it behind a flag async-scan-jars-on-startup? . While the jars are not scanned, it's not possible to go to a jar or something like that, but I think it's more important for users to scan the project and then later scan the jars... wdyt?

ericdallo20:12:35

I was wondering also if the default of this flag should be true or false

ericdallo20:12:13

I have plans in the future to improve this code later to use more clojure core async to crawl source dirs and clj-kondo

bringe20:12:00

I think making it false by default (like current behavior) would be good for now at least

ericdallo20:12:45

Ok, I'll open a PR soon, would you mind helping test with Calva also?

bringe20:12:56

Sure, np

👍 3
bringe21:12:37

sweet, I'll get to this when I can, it may be a little while

👍 3
practicalli-john17:12:03

@pez ouch, its not very welcoming to add a feature that consumes large amound of memory with no option to disable. I'll downgrade Calva to an earlier version for now until its possible to run without clojure-lsp

pez17:12:43

We weren’t quite aware of the memory consumption, @jr0cket. But we try to be quick to fix problems we create by being quick to develop Calva. We’re not like Facebook. It’s rather Move fast. Be quick to fix things if they break, 😃

practicalli-john17:12:57

I am afraid this gives me less confidence in recommending Calva

practicalli-john17:12:29

@pez oh, I though it was a well known problem with clojure-lsp. I've discussed this many times with people using clojure-lsp with Emacs, which is a far worse situation as clojure-lsp didn't run as a background process. Although clojure-lsp is a very promising approach, for myself I consider it an optional tool until it matures and becomes more efficient. I was going to invest time to learn Calva better in 2021, but not if "have" to use clojure-lsp without a choice, sorry.

bringe18:12:56

Thanks for the feedback, @jr0cket. You have very valid points, and I'm going to prioritize this.

practicalli-john18:12:39

Thank you. I dont like to be negative, but feel this is a big change to the Calva experience and wouldn't want anything to detract from the amazing work done so far. Thanks again.

❤️ 3
bringe18:12:51

I started this issue to track the memory issue https://github.com/clojure-lsp/clojure-lsp/issues/229

👍 3
pez23:12:16

Happy New Year, friends! (We just celebrated here in Sweden). 2021 is the year of Clojure, I am sure. And the Calva team shall be here, offering VS Code people tools they need to join and enjoy the ride. Cheers!

🎉 18
🎆 9
roelof23:12:54

@pez Same wishes to you

roelof23:12:01

happy new year

❤️ 3