Fork me on GitHub
#calva
<
2020-03-07
>
sogaiu03:03:44

it seems like the order could matter here: https://github.com/BetterThanTomorrow/calva/blob/master/src/cursor-doc/clojure-lexer.ts#L52 in node \r\n doesn't seem to match because \r matches first. if the behavior is the same in vscode, perhaps it's better to put \r\n first.

pez08:03:55

That's strange. But it might not matter b/c vscode doesn't work with files using only \r line endings anyway. I'll have a look anyway.

sogaiu11:03:10

ok, thanks

sogaiu11:03:12

@pez i've made some further changes and tested w/ a built vsix -- it may be that #577 and #578 are fixed. perhaps you could take a brief look?

pez12:03:08

I'll have a look now.

sogaiu12:03:37

ah, i guess the CHANGELOG may be conflicting?

pez12:03:36

It's not up to date with latest dev. Might wanna rebase.

sogaiu12:03:15

right. not sure i have time today. thanks for taking a look!

sogaiu12:03:41

@pez is it acceptable to squash the commits, reword, and push?

pez12:03:34

Yeah, I usually don't do that, but there is nothing I can see that speaks against it.

pez13:03:14

The changes look good, and also work. 😃 Many thanks for the help!

sogaiu13:03:43

thanks for your guidance and help. i tested the built vsix a bit and it seemed to work ok.

pez16:03:08

Dear Calva-friends a new Calva is out. Mostly grammar fixes, for syntax, rainbows and for Paredit. Thanks to @sogaiu for both spotting and fixing problems! ## [2.0.80] - 2020-03-07 - Fix so that Paredit treats symbols containing the quote character correctly. - [Fix: Parameter hints popup should be off by default](https://github.com/BetterThanTomorrow/calva/issues/574) - [Fix: nil followed by comma not highlighted correctly](https://github.com/BetterThanTomorrow/calva/issues/577) - [Fix: The syntax highlightning fails with symbols named truesomething/falsesomething](https://github.com/BetterThanTomorrow/calva/issues/578) - Fix so that Paredit does not consider ^ to be part of a symbol name.