This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # announcements (17)
- # aws (1)
- # babashka (68)
- # beginners (88)
- # calva (85)
- # chlorine-clover (10)
- # cider (5)
- # cljsrn (4)
- # clojure (99)
- # clojure-android (1)
- # clojure-denmark (1)
- # clojure-europe (15)
- # clojure-italy (5)
- # clojure-nl (3)
- # clojure-spec (1)
- # clojure-uk (67)
- # clojurescript (44)
- # core-async (44)
- # cryogen (4)
- # cursive (22)
- # data-science (2)
- # datascript (10)
- # datomic (29)
- # duct (11)
- # editors (2)
- # emacs (2)
- # events (1)
- # fulcro (28)
- # ghostwheel (7)
- # graalvm (8)
- # instaparse (6)
- # java (34)
- # jobs (9)
- # jobs-discuss (71)
- # juxt (12)
- # luminus (3)
- # malli (15)
- # meander (9)
- # nrepl (4)
- # off-topic (44)
- # pathom (13)
- # reagent (22)
- # schema (1)
- # shadow-cljs (39)
- # spacemacs (2)
- # test-check (1)
- # tree-sitter (5)
- # xtdb (5)
- # yada (1)
@pez i was looking at the tm grammar and started wondering why nil is handled differently from true and false: https://github.com/BetterThanTomorrow/calva/blob/master/clojure.tmLanguage.json#L71 https://github.com/BetterThanTomorrow/calva/blob/master/clojure.tmLanguage.json#L75 perhaps an accident of history? or may be some other reason? it appears that if you put a comma after a nil, (<- like that) highlighting goes away, though that doesn't happen for true and false (which i guess is preferred?)
Good observation! Most of that grammar is inherited from Atom’s clojure language. The issue with comma after nil should be fixed.
It's all pretty well coverd by tests, so I it is reasonably easy and safe to experiment with it.
W/o having looked at it, from your description, it sounds like we should treat it much more like we treat booleans.
when you say tests, do you mean something different from: https://github.com/BetterThanTomorrow/calva/wiki/Smoke-Testing ?
Yeah, I mean this: https://github.com/BetterThanTomorrow/calva/blob/dev/src/calva-fmt/atom-language-clojure/spec/clojure-spec.coffee
ah, ok, i guess how to do that is described here: https://github.com/BetterThanTomorrow/calva/wiki/How-to-Hack-on-Calva
You'd guess that. But: https://github.com/BetterThanTomorrow/calva/wiki/How-to-Hack-on-Calva#syntax-grammar
TLDR: If you are hacking on that, please holler at @pez on the Clojurians slack, and I will give you some starting points.
i think i may be missing something as i get an error:
index.js:129 Error: Cannot find module '/home/user/src/calva/spec'
1. Open the
src/calva-fmt/atom-language-clojure directory in Atom.
2. Run Package Specs
3. Update the grammar (I do that in VS Code, because I love VS Code): https://github.com/BetterThanTomorrow/calva/blob/master/src/calva-fmt/atom-language-clojure/grammars/clojure.cson
4. In Atom Run Package Specs
You probably need to update the specs too, depending on the change: https://github.com/BetterThanTomorrow/calva/blob/dev/src/calva-fmt/atom-language-clojure/spec/clojure-spec.coffee
sounds good 🙂 ok, changed the .cson grammar and then tests passed. just to make sure i also changed it to something incorrect and verified the tests would fail then. the clojure-spec.coffee file appears to mention nil only here: https://github.com/BetterThanTomorrow/calva/blob/dev/src/calva-fmt/atom-language-clojure/spec/clojure-spec.coffee#L88_L90 may be this is a case of not having to change the specs file?
i'll see what i can do -- i'm neither a coffeescript writer, nor a spec writer, but am willing to learn
btw, the text here doesn't quite look right:
Made sure I am changed the default PR base branch, so that it is not `master`.
I agree. Just wasn't sure it was what didn't look right. I've struggled quite a bit to not have to have that text at all.
i think i can probably build a vsix and test it here. puzzled a bit by:
without submitting the pr, i presume i don't seen any of that. does that sound right?
You'll find the artifacts by clicking _Show all checks_ in the CI section of the PR page, and then _Details_ on the `ci/circleci: build` test.
so the idea here is to submit the pr, but the checklist is not supposed to be completed until after i guess?
Right, it is part or the PR template... You are welcome to edit that too of course. But I have made a note about both errors, so will fix'em.
It was a very long time ago a working VSIX built locally didn't mean it also worked from CI. But since that is what is going to be what is released, I think I want to keep that check step.
However. CircleCI makes it really hard to find that artifact. I should update the instructions for that as well. That, or move to Github Actions.
yes, it makes sense to actually test what is going to be released. if we had reproducible builds, i'd much prefer to install what i built locally though.
@pez FWIW, for babashka I made a script which posts the artifact links to #babashka_circleci_builds
Very cool! But the fact that this is needed serves to convince me it is time to leave CircleCI...
@pez i've looked for an example of: "Referenced the issue I am fixing/addressing in a commit message for the pull request." -- didn't find one in a brief search. do you have an example i could emulate?
They look like so: https://github.com/BetterThanTomorrow/calva/commit/52019700cc4ce3ff6a26e0c637c19e5da212b530
ah, i see -- ty. so you put the fixes and issue number in the body, not the first line.
Yeah. It creates a nice trail on GH (but you probably have figured that that is why this is done).
i'm trying to do the new ui experience thing -- confused by selecting the organization step. does that matter?
It is totally confusing... What I do these days is that I edit the URL for one of the other tabs in the old UI.
So in this case: https://circleci.com/gh/BetterThanTomorrow/calva/4319#artifacts/containers/0
lol -- well, after choosing the new ui experience and going through the oauth2(?) dance, i went back to the pr and followed links from there.
Please help put some attention on this issue btw: https://discuss.circleci.com/t/artifacts-tab-not-showing-unless-logged-in/32433
i have made some progress on the tree-sitter clojure grammar. but iiuc, getting the grammar to work with themes in vscode is not really going to work atm.
the pr is vaguely related in that i'm studying highlighting and found a minor issue in the current tm grammar.
@pez Posted a reply in that thread. Also informed @marc-omorain
What I meant by process-wise prices was that you ask when you wonder something. Sometimes I suspect people just throw up their hands and never lets me know when I have been unclear.