This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # announcements (66)
- # aws (1)
- # beginners (60)
- # boot (6)
- # calva (80)
- # cider (3)
- # clj-kondo (14)
- # cljdoc (4)
- # cljs-dev (27)
- # clojure (65)
- # clojure-dev (24)
- # clojure-europe (13)
- # clojure-gamedev (3)
- # clojure-italy (3)
- # clojure-nl (21)
- # clojure-uk (35)
- # clojurescript (98)
- # cursive (25)
- # data-science (3)
- # datomic (10)
- # dirac (16)
- # duct (2)
- # events (2)
- # fulcro (39)
- # jobs-discuss (1)
- # malli (2)
- # other-languages (1)
- # pedestal (26)
- # re-frame (61)
- # reagent (1)
- # reitit (7)
- # shadow-cljs (230)
- # specter (1)
- # tools-deps (28)
- # vim (1)
- # yada (4)
@agold (and all Calva-friends, really): Here are the docs Calva w/o it’s own linting reporter and w/ clj-kondo bundled: https://calva.readthedocs.io/en/bundle-clj-kondo/index.html (the
bundle-clj-kondo part of the URL is just pointing out the version of the docs, so the link is to the start page). These docs go with this README https://github.com/BetterThanTomorrow/calva/tree/bundle-clj-kondo. You can find the whole PR here: https://github.com/BetterThanTomorrow/calva/pull/426 and a VSIX package here: https://1577-125431277-gh.circle-artifacts.com/0/tmp/artifacts/calva-2.0.54-bundle-clj-kondo-7369cf10.vsix
Maybe this is interesting to add to the README for Windows users? https://twitter.com/borkdude/status/1187622954236071936
Maybe the clj-kondo extension can also emit this information on startup. I'll try this
Let’s see if I get this correctly. That is not needed for using the extension on Window’s, right? It is mainly a way to get a clj-kondo command working?
I'm not planning to support this in my clj-kondo extension (since it's not an IDE like Calva)
Where should I link for more info on this? (I’d like to keep it minimal in the Calva docs).
If Calva can assist with linting the entire classpath/project, I’d like an issue about it.
and then you can use this information while visiting files, then the clj-kondo extension will pick up on this
No, Calva doesn’t really know about the classpath. It might be able to inform itself about it via nREPL? In any case, I am not promising to add that support, but if I have an issue with some helpful info about what it entails, I’d at least have it on my radar.
@pez this looks good to me: https://github.com/BetterThanTomorrow/calva/commit/b6bd93653ac97c46c75ffd1a7a0d34a0a7d2b2d4 thanks!
Haha, you found it quickly! Can also be seen here: https://calva.readthedocs.io/en/bundle-clj-kondo/linting.html
is this the server mode in https://marketplace.visualstudio.com/items?itemName=borkdude.clj-kondo or something else?
I ask because you were inquiring with snoe on whether the two projects should join forces, at least on the lsp front
clojure-lsp already has integration for emacs, so if clojure-lsp would integrate kondo, I wouldn't have to figure the emacs lsp stuff out and write a separate emacs package. there still could be one though, but my highest priority with the LSP stuff was VSCode since I suspect Clojurians on Windows would use mostly that
tbh as a vscode user it just sounds like christmas came early, all the tooling, zero hassle
I don't know clojure-lsp and Calva well enough to say that it would be a good marriage, I'll leave that between snoe and PEZ 🙂
We haven’t had the time to investigate how Calva could leverage clojure-lsp. @slack1038 made a vscode extension using clojure-lsp, and it was quite mindblowing how all that Clojure IDE power just came pouring up from the server. There has also been some discussions in the Dev Tooling Task Force about using nREPL to start the server and then wether we should add a layer of nREPL api to it, for non-lsp clients.
I think a lot of that is a bit stuck today because everybody thinks there are two many ASTs built, in too many ways and that we want to solve that first. Just that we need a lot of time, and noone has a lot of time. lol
but I understand the problem of integrating between multiple parties, that's always tricky and time consuming
OK. so I see the commit message now. Well, it was just a very quick test. I don’t think the Windows story necessarily is closed.
e.g. if I downloaded and exposed the lsp server in the
clj-kondo package as a bin
I’m pretty happy with letting the clj-kondo extension do the linting. Maybe I don’t understand the question. 😃
In theory, the kondo LSP server could live in the same JVM process as the Calva REPL, so save one JVM instance. But then you could also have dependency conflicts or when your REPL crashes you would not have linting anymore
And also no linting until you have the repl. I think it could be pretty tricky to try start the repl inside a given jvm process.
I mean the other way around. Calva starts the REPL and inside that REPL launches the server.
I’m super happy with that the story now becomes Install Calva and you have excellent linting. It’s worth a java process.
And Calva v2.0.54 is out. Bundling the clj-kondo extension. Many thanks to @borkdude for clj-kondo, the clj-kondo extension, and for going the extra mile to spark joy in VS Code land. ❤️
PSA: I just fixed a bug in the borkdude.clj-kondo vscode extension. The server would not shutdown when you closed the editor or changed workspaces.