Fork me on GitHub
#calva
<
2019-09-23
>
pez09:09:09

@harmmatan: You’re lookinng for resources on vscode extension development? It’s a bit lacking, I would say. The API docs are both good and bad. I can recommend joining the vscode dev slack and the extension channel there: https://vscode-dev-community.slack.com/messages/C74CB59NE

Janne Sauvala09:09:24

I was thinking about helping out Calva and taking some issues. Do you still think https://github.com/BetterThanTomorrow/calva/issues/89 is an easy one or do you have some other recommendations, Peter?

pez10:09:46

I don't think it is particularly easy, actually. But it would be awesome to have it done.

Janne Sauvala14:09:26

I could take a look at this 👀 Do you have insights how I could approach this?

pez14:09:12

@janne.sauvala Oh, sorry, with your anon avatars I thought your question came from @harmmatan... and was about the issue he had mentioned. Confusion. So those compiler errors... might be a good first issue, actually.

pez15:09:40

Take a look at the test runner to see how we squiggle things there. And then it will be a matter of reading that ex-data to pick up file path and line numbers and such. Might be that the biggest problem is figuring out when to clear the problem marks...

Janne Sauvala15:09:59

Slack apparently changed our avatars to be even more confusing 😄 I’ll take a look at that then, thanks!

gerred16:09:55

i don't have println in any of my tests, so was just an observation @pez

pez16:09:58

@gerred: But I don’t follow what it means “I don’t have println in my tests”…

gerred16:09:10

I was using his example (deftest foo (is (= (println 1) (println 2) (println 3) (println 4) (println 5))))

gerred16:09:19

and then used Calva: Run current test

pez16:09:33

gotcha. trying it now

gerred16:09:34

since I just default to that chord while I'm developing

gerred16:09:43

(instead of doing what he did, which was (foo))

gerred17:09:07

i don't think I'd want to see the printlns though, so I think this is behaving as I'd expect it to.

pez17:09:17

For me it prints:

Running test: foo…
1
2
3
4
5

1 tests finished, all passing 👍, ns: 1, vars: 1

gerred17:09:21

really? odd

gerred17:09:33

clearing my console to make sure I'm not red herring myself.

pez17:09:38

Can you try with latest release build? Or dev.

gerred17:09:48

oh, it sure does.

pez17:09:36

I had to Google that 😃

gerred17:09:51

@pez i've been doing some thinking about the whole REBL in Calva thing, since not everyone has REBL necessarily.

ozimos10:09:12

@gerred I think I have Calva Jack In working with REBL. Details are in this issue https://github.com/BetterThanTomorrow/calva/issues/240

pez11:09:15

That's awesome! Can you create a wiki page about it?

pez07:09:57

Would you say that this resolves the issue, @UKKAMGG05?

ozimos08:09:50

@pez It does

❤️ 1
pez08:09:14

Closed it and linked to the new page: https://github.com/BetterThanTomorrow/calva/wiki/Using-with-REBL Thanks for the help! Extra cool that the custom connect sequences could help with this, wouldn't you say, @UD8TU3HP0? 😄

kstehn08:09:18

Yeah its awesome :D

gerred17:09:31

it'd be nice to be able to configure (dunno if there's a ~/.clojure/deps.edn way to do this?) additional nrepl middleware in Calva

pez17:09:30

@gerred need to run. Will get back to you.

pez18:09:39

I think it should be a setting in Calva, a path to the REBL.jar and some way to choose if it should be included in the jack-in, then Calva injects everything that is needed. (Even if it looks like a huge dependency list for deps.edn…)

pez18:09:43

I need to either find some time to experiment with it or get a demo of how it works when it is set up manually. Then I might understand enough to know about how to do it and wether Calva should have some more support, beyond channeling evaluations like that.

pez18:09:49

The whole thing would benefit from you spearheading it, anyway, @gerred. Just sayin’. 😄

gerred18:09:00

I actually just forked to play with it 😉

pez18:09:09

Awesome.

gerred18:09:21

hey side note, if you sign up for Github Actions, I'd happily port over my workflow that generates builds on every commit for the dev branch.

pez18:09:24

I’m available for a zoom session if you like.

gerred18:09:43

and then we could add them as draft/preview releases to kick out the vsix

pez18:09:49

I need to google Github Actions now.

pez18:09:20

We already have builds for every commit though.

gerred18:09:24

oh do you?

pez18:09:34

Circle CI.

pez20:09:36

summoning admin (just a test)

gerred18:09:34

oh via circle

pez18:09:36

We create github releases and even publish to the marketpkace with circle as well.

gerred18:09:41

oh perfect.

gerred18:09:04

yeah I think there's a separate "evaluate and send to REBL" command as well. I have REBL starting up just fine, but that's the next step, thankfully @seancorfield has a great command for that over in his Atom setup with Chlorine, so I was able to at least spike it out and test it while jacked in.

pez18:09:19

Yeah, It is so sweet. Very new, and I am still just in love with it.

gerred18:09:19

though the nrebl middleware is just magical.

pez18:09:30

I’d love to see it in action.