Fork me on GitHub
#calva
<
2019-07-08
>
cheatex15:07:18

@pez Hi. I'm hitting another bug. In calva editors Esc doesn't close search box. I believe it worked in thursday. Could it be related to #244?

pez15:07:24

I don't think it is related to that. But the timing is suspicious, of course, if you remember correctly. This is the when clause used for ESC:

"when": "editorLangId == clojure && !sideBarFocus && !panelFocus && !editorReadOnly && !suggestWidgetVisible && !hasOtherSuggestions && !editorHasMultipleSelections"

pez15:07:42

But, now checking the commit. This was indeed borked by #244. I'll restore it ASAP. Thanks for alerting me!

pez15:07:00

There, 2.0.22 is out, fixing that issue. Thanks again!

✔️ 1