Fork me on GitHub
#calva
<
2019-06-16
>
pez08:06:41

@slack1038 can you merge latest upstream and see if my patch for fixing a bug with .bat executables on windows doesn’t mess anything new up?

pez08:06:38

If anyone would want to test this package before I publish it, I would be much more comfortable. (Or more informed, in case there is something funny with it.)

kstehn08:06:44

what did you change? so i can know what i should test and watch out for 🙂

kstehn08:06:57

when i try to jack-in i get a new error

kstehn08:06:22

nvm had to clone again because i could not run the cljs task but now it works

pez08:06:25

Oh, not good! Is that from your own build our from the package I uploaded?

pez08:06:10

Can you try the package too? For good measure.

kstehn08:06:42

yes will do now 🙂

pez08:06:33

The change I made was to blindly guess where the error @brandon.ringe reported yesterday had crept in. In jack-in.ts where we check for integrated terminal setting. I think it was undefined/null on @brandon.ringe's machine and then the endsWith crashed.

kstehn08:06:31

yeah makes sense didnt thought about that when i added this part 😅

kstehn08:06:49

the package works fine for me

pez08:06:46

Thanks for helping with this. I'll release the fix a bit later today.

minhnn09:06:10

can we clear repl window @pez

pez09:06:36

Only by closing it and then opening it again.

minhnn09:06:49

haha, I do It too

😄 1
pez11:06:51

@minhnhat10bk can you try this build for me? I added a keyboard shortcut to the repl window for clearing it, ctrl+l (that’s lowercase L). There is no undo… Please tell me what you think about it.

minhnn11:06:20

ok, I will try it now

❤️ 1
pez13:06:18

Cool. I'll double check the code some to make sure I'm not doing something too stupid. But you can run with that build until it is published. 😀

minhnn13:06:25

I have a trick to work with repl window is vscode cmd focus editor group(map it to some key) so I can switch between repl and editor

👍 1
pez13:06:51

We should mention that on the wiki somehow.

pez16:06:39

Very cool. I have my finger on the eviction trigger for Calva's linter. Will instead bundle this one with Calva. But it'll be something to decide about together @marc-omorain

Marc O'Morain18:06:11

I need to add a cache directory, and somehow merge the JSON setting into the users config file somehow.

borkdude18:06:38

@marc-omorain I think I would add --cache to the args and let the users make a .clj-kondo directory in the root of their projects. That’s how I do it in emacs.

borkdude18:06:01

Then clj-kondo will store the cache in that .clj-kondo dir automatically

borkdude18:06:39

The cache needs to be unique for each project, or you can get namespace conflicting things in there

borkdude18:06:16

If clj-kondo can’t find a .clj-kondo directory, clj-kondo just won’t use the cache, so it’s pretty harmless

Marc O'Morain18:06:43

To merge the JSON setting, I’m thinking of the following (I might be over cooking this) - find the closest .clj-kondo working up the directory hierarchy - load the config.edn if one exists - assoc in the JSON setting to ensure that it’s true. - serialize the new settings to an edn string - pass —config with the serialized edn string

borkdude18:06:04

that’s what clj-kondo already does 🙂

borkdude18:06:00

oh you mean to override JSON always

Marc O'Morain18:06:27

btw, the JSON output is amazing

borkdude18:06:29

that also already works, since the --config arg is prioritized over the .clj-kondo/config.edn

borkdude18:06:17

the config is merged, but --config wins

borkdude18:06:59

sweet! 🙂

Marc O'Morain18:06:53

Yeah, it means that I don’t need to parse or validate anything.

Marc O'Morain18:06:02

And no regex 😭

borkdude18:06:41

I currently emit one linter at the :info level, which is the unresolved symbols linter

borkdude18:06:55

I chose :info for that because it might overwhelm people 😉

borkdude18:06:37

TypeScript actually doesn’t look that horrible

😃 1
lspector19:06:40

FWIW I've discovered that the REPL window can get a bit sluggish and wonky when I paste in large values (was just working with lists of around 600 vectors, each with 18 small integers). Pasting can take many seconds, etc. I'm guessing this is just a fact of life but I thought I'd mention it in case there's something that could easily address it

pez19:06:01

^ It might be something for @mseddon to take a look at ^