Fork me on GitHub
#calva
<
2019-06-12
>
pez09:06:06

I have created a wiki page about code evaluation. Please check it out and help improve it (you know you can edit Calva wiki pages, right?). https://github.com/BetterThanTomorrow/calva/wiki/Code-Evaluation-Tips

lspector13:06:44

On the wiki about code evaluation (not making the changes myself because I'm not sure you'll think this is a good idea or that I'll get it right), I think "Sending it to the REPL window from a file editor" should be in the first section ("Evaluation in a File Editor") rather than in "Evaluating in a REPL window," because this is about evaluating code that's in a file editor, and as far as I know the only way to do that and to get all and only the output printed somewhere. Not sure if the "Pretty printed" option (to Calva says) should also say that it will print extra newlines, or if that's a behavior that will change. Also, it says "you can also choose what should happen with the results" and it would be nice if it said how you can choose (I don't know how).

pez13:06:53

Thanks! I hesitated on what goes where. Maybe I should try another structure even. About pretty printing, it only is applied to the results, not the side effects, so Calva does not add any extra newlines for that. (And also, the extra newlines for stdout stuff is a bug, so I'd rather fix it than include it in the documentation. 😄 )

pez13:06:55

About ”you can choose”, is it clear that it is a headline to the four different options? And what you are asking for is that we should tell how it is done?

lspector14:06:27

Sounds good. On "you can choose" yes, it's clear that that's a headline to four options, but it's not clear how one selects among them (is it using different commands? If so then maybe the specific commands can be provided... or maybe the choice is made in some different way?)

pez16:06:50

It is commands. I am myself a heavy user of the search/filter feature of the command pallette, so was thinking it was enough to provide search terms. I'll clarity those a bit. Good catch!

tbrooke19:06:29

Anybody ave Clj-Kondo working with Calva yet?

pez20:06:27

@tbrooke, not sure what it means getting Clj-kondo to work with Calva?

borkdude20:06:22

@tbrooke there are a couple of people thinking about it here: https://github.com/borkdude/clj-kondo/issues/145

pez20:06:11

@tbrooke OK, thanks. I think you could get it to work somewhat by configuring vscode tasks, but Calva does not have any explicit support. Yet. It should be quite easy to support as an alternative to the Joker support we have today, but I a hesitating to do that, because I am rather planning to evict the linter from Calva. There are some initiatives on making separate extensions for that.

borkdude20:06:57

@pez if you’re already supporting joker, supporting clj-kondo might be trivial and it could be opt-in

borkdude20:06:31

or splitting that out into a separate extension, like calva-linters

pez20:06:14

Yeah, I think it might be trivial even. 😃

pez20:06:07

I think @marc-omorain were planning to make a separate extension.

pez20:06:23

I much rather have it solved that way. Linting deserves some good focus of its own. Within Calva it will not get that focus.

Marc O'Morain20:06:27

I’ve started on it yesterday

borkdude20:06:36

that’s awesome. is cloure-lint a typo?