Fork me on GitHub
#calva
<
2019-05-06
>
slipset08:05:52

@pez: figured out the tools.reader problem. Our project had a super-old version of tools-reader. I upgraded that, and no need for exclusions.

👍 4
pez10:05:26

I started to think a bit about that actually and wondered if maybe such settings are better handled in the project definitions than in jack-in injections. But, yeah, even better to not include super-old ones 😃

nooga11:05:19

I just installed calva extensions on a relatively clean vscode 1.33.1 (no other exts except for golang)

nooga11:05:02

looks like syntax highlighting for clojure and clsj is broken - does not highlight keywords, punctuation etc.

nooga11:05:32

I'm using the default vscode theme and don't see any errors in the logs so I'm puzzled as to why no highlighting

nooga11:05:39

anyone encountered that problem?

pez11:05:26

@xnooga: Welcome! No highlighting whatseover?

nooga11:05:04

hi pez, only strings, numbers and special forms are highlighted

nooga11:05:20

like defn, let, 0, "foo"

nooga11:05:24

the rest stays the same color

nooga11:05:38

no matter the theme I try

nooga11:05:24

my guess is that vscode uses some default highlight mode and manages to find "keywords" (aka special forms) and basic literals

nooga11:05:52

but no clojure specific highlighting at all, keywords (:like-that) stay the same color as the rest

pez11:05:07

I am unsure about what else you are missing. So don't know if something is wrong or maybe just not implemented.

nooga11:05:48

I osmehow missed that documentation, sorry to bother you and thank you @pez 🙂

pez11:05:56

No worries. This channel is your friend either if it is you or I who have missed something. 😃 And I should probably make that a bit more visible...

pez12:05:42

Here's a new dev build of Calva 2, I'd like help with testing. Added since last build is: 1. Jack-in starts with asking you about project types it think matches and if Figwheel or Figwheel Main should be started. 2. Jack-in opens the browser for you after having started Figwheel (like Fighweel Main does by itself). 3. Jack-in does not inject CLJS dependencies unless you have asked it to start CLJS things. Also the REPL window indicates REPL type (CLJ or CLJS) a bit clearer and for Leiningen and shadow-cljs you even get some more visual clues. Thanks in advance for help with testing it!

bananadance 12
slipset13:05:28

Hmm, there is some strange stuff happening.

slipset13:05:46

I can only report symptoms right now, haven’t had the chance to dig into it.

pez13:05:56

Symptoms are fine!

slipset13:05:24

Since I removed our dep on the ancient tools.reader I’m now able to jack in.

slipset13:05:34

Which is good 🙂

pez13:05:40

There's that at least. 😃

slipset13:05:53

Then our app requires us to run a function in the user-ns, reset

slipset13:05:07

When I run reset two strange things happen

pez13:05:11

So, right after jack-in?

slipset13:05:36

1) The prompt in the repl window never returns

pez13:05:43

oh, noes

slipset13:05:23

2) arrow keys stop working in my clojure buffers.

pez13:05:43

Other keys work?

slipset13:05:03

Here’s the fun part

slipset13:05:23

calling (reset) returns an error 🙂

slipset13:05:14

as in, when I jack-in with Cider, and I call (reset) Cider will report that the it failed

slipset13:05:22

This is expected behaviour.

pez13:05:35

The REPL window binds some keys so might be it hangs and doesn't update the context so that the editor can bind them... If so we can probably make that a bit more robust by updating the context on some editor event.

pez13:05:11

ex or err?

slipset13:05:23

hang on….

pez13:05:54

With some luck this is the same problem as with the cljs repl hanging on println. But I am seldom lucky with these things. I guess my luck in love grabbed my full share of luck.

pez13:05:53

If you close the REPL window, do you get the keys back?

slipset13:05:19

I wrote you some stuff in private…

claudiu18:05:52

is there anything I need to configure to have #_(form...) displayed similar to ; (form ...) ?

pez18:05:46

There is nothing you can configure for that, unfortunately. If you're good with regexps you can pick up my branch where I try to fix this, though. I spent quiet some time with it, but got stuck on something, don't remember what right now.

pez18:05:57

^ edited for borked message. I blame Gboard. ^

pez18:05:06

Here’s the branch: https://github.com/BetterThanTomorrow/calva/tree/wip/grammar-comment-expression . I just merged latest dev on top of it.

pez18:05:05

I will return to it eventually, @claudiu, but it will take a while before I can prioritize it.

pez18:05:11

I was aiming a bit higher then merely ;, though. I wanted to make it syntax highlight as regular code, but just add italics to it so you could see it was disabled.

claudiu18:05:01

thank you 🙂 Need to finish up a freelance project this week and the will try to play with it a bit. Not sure I can solve it (just installed vs code for the first time this week) , but could be fun for learning and getting the hang of things 😄

pez18:05:12

Cool. I will be hoping you find some time for it. It is more TextMate rules and regexp than vscode really. Holler my way when you want to take a look at it and I’ll try to remember how it worked.

pez18:05:26

One of my colleagues at work would scream and giggle like a happy 5-yo girl if we fix this. He hates that he does not see the #_ stuff clearly.

claudiu18:05:53

ok 🙂 will give it a shot when I have some time. Been using cursive for a while now, was just goofing around with atom & vs code. Really surprised how nice it is (able to be productive and enjoying it as my main editor after 1 day of setup). Thank you for calva 🙂

metal 4