Fork me on GitHub
#calva
<
2018-12-21
>
mseddon09:12:16

I don't think VSCode eats that much cpu for that purpose ๐Ÿ™‚

pez09:12:01

Good news. I got help from a real programmer to climb up out of the hole I had dug myself down in when it comes to the nrepl socket connection. So now the nrepl client code looks like so: https://github.com/BetterThanTomorrow/calva-lib/blob/talky-socket/src/calva/repl/client.cljs I have kept the API towards the Calva extension and only removed all the opening and closing of the sockets that previously embedded every message sent. That's in this branch: https://github.com/BetterThanTomorrow/calva/tree/keep-socket-open

pez09:12:38

Thanks, @pedrorgirardi! โค๏ธ

pez09:12:31

There are still two issues, one which makes me hesitate to merge this into the main branches.

pez09:12:20

(Two issues that I am aware of and that bothers me enough to mention them, that is. I am sure there are still tons of issues hiding in there. ๐Ÿ˜„ )

mseddon09:12:47

"It's only 93 lines, how many bugs could there possibly be?" ๐Ÿ™‚

pez09:12:02

For all the bugs and issues that were there with the previous implementation it is surprising how solid the nrepl messaging was. But there is a change that the issue with people's terminals hanging could have been one of them. I certainly hope so, but I know it could be a vain hope.

pez09:12:32

Anyway, the โ€sort of stopperโ€ is that I can see that I sometimes build up cruft in the atom keeping track of which response goes with witch request. This is not enough to tidy out all that needs to be tidied out: https://github.com/BetterThanTomorrow/calva-lib/blob/talky-socket/src/calva/repl/client.cljs#L61

mseddon09:12:29

huh, yeah. that will ruin all the things

pez09:12:36

I need to learn a bit more about nrepl to know what to do with :status ["state"] messages for one. Calva has never used them, so just disregarding them might be the way to go.

pez09:12:20

I guess to get this thing out of the door, avoiding that perfect gets in the way for better, is to keep track of which messages we consider handled and never accumulate them again in the *results atom. Then have it on the TODO to handle things properly.

pez09:12:35

The other, less pressing, issue is that I currently have kept the super-naive bencode decoding strategy. Which might have bugs in it, even. A moment after the connection is established I get quite a lot of decoding errors. nrepl seems to send a LOT of things to me, none of which I see the relevance in (probably because of my lack of understanding, but anyway).

pez09:12:34

Shipping this new socket handling would in this respect keep this bencoding decode quality at the same low level. ๐Ÿ˜ƒ

mseddon09:12:08

yeah, I think the next big thing on the list after I get this formatter sane is to look at exactly how nrepl is used by cider

mseddon09:12:26

stepping through their implementation on real sessions

pez10:12:17

Re: bencode, I think the time is better spent shifting to use EDN transport. Or at least add that too the ways Calva can communicate.

mseddon11:12:11

it would be easier to debug edn and then backport to bencode later.

mseddon11:12:33

I am not sure how much benefit bencode gives you over a local connection anyway

pez12:12:43

None, probably. And there is transit transport as well.

mseddon12:12:17

hmm, am I calling this correctly? (reformat-string "(foo\nz\na\nb\nc)" {:alias-map '{foo [[:inner 2]]}})

mseddon12:12:42

can't seem to alter the formatting for foo

mseddon12:12:01

oh, doh. :indents not :alias-map

mseddon13:12:32

so, on return I now walk up the tree, working out what argument position we're at, the head of the current list, and collect the indent rules along the backbone of the whole expression tree

mseddon13:12:29

but this is carefully limited so we don't tank performance with large files- so you can configure it to only look up so many lines, and only up so much depth, and it will fall back to heuristic indentation in that case

mseddon13:12:31

also currently this is purely for indentation only, although I can obviously correct whitespace issues too later.

pez13:12:29

To me it makes sense to do the indenting with your stuff there and do formatting with cljfmt and zprint. What do you think about that?

mseddon14:12:04

Yeah, I think so. emacs' reformat commands are more precise than the much simpler format on type stuff

mseddon14:12:34

in fact, though emac's formatting rules are far simpler anyway- they don't nest deeply like cljfmts, so they have it even easier ๐Ÿ˜‰

mseddon14:12:16

(and I am perfectly happy with just those, in my day to day coding, personally)

mseddon14:12:37

right, I am out for a bit, but hopefully I will have a demo up later tonight

mseddon14:12:16

Although currently you can see the function collectIndentState, which is working correctly to retrieve all the information required to compute the next indent.

mseddon15:12:29

Okay! Have at it! the restartable-formatter branch has a prototype working implementation!

mseddon15:12:25

it'll do stupid stuff if its search bails at this point probably, but in general it should indent the same as cljfmt so long as its search covers enough!

mseddon15:12:14

so yeah, need some simple 'indent to same as last sibling expression' sort of heuristic for when that happens.

mseddon15:12:36

I will probably also treat any parent list on column 0 as the start, to prevent scouring too far above. I assume your code is mostly correctly formatted... otherwise you should use the proper reformatting tools

mseddon15:12:44

incremental calva-fmt indentation, in typescript, in 70 lines total (except for the rules of course).

mseddon16:12:46

paredit can be ported over to use this, too.

pez16:12:58

Yay! Can't wait to test this. (But I'll have to. On my way to a glรถgg-party with my family.)

pez16:12:46

If someone has some time to put my latest talky-socket for a spin, I'd be most happy. (You'll have to build it yourself from the branches mentioned above. But that's quickly done.)

mseddon17:12:19

@pez yeah it's a bit hectic my end for now, so I'll have to take a look later, too ๐Ÿ˜‰