Fork me on GitHub
#calva
<
2018-11-28
>
slipset07:11:07

Not in the terminal, but it sure makes it much better in the source window 🙂

slipset07:11:11

Thank you!

pez07:11:42

Well, you did the right thing and opened two issues. 😃

slipset07:11:51

🙂

slipset07:11:25

I still believe you have enough info in the compilerException to make a red squiggly under the offending form.

slipset07:11:51

But I understand that is more work.

slipset07:11:31

Having said that, in Clojure 1.10, the error messages are much better and they relate to your code a lot better than before.

pez07:11:54

I will look for what I have there. In fact it seems Calva does not pick up enough about errors as it is, because sometimes it is just like nothing at all happens when you evaluate something.

pez07:11:57

It is pretty easy to get those red squigglys in place, it is just a matter of extracting the info. But do you mean you would want these squigglys when you evaluate something inline?

slipset07:11:59

Hmm, I can’t send you an image here…

slipset07:11:23

(defn delete-by-source-id! [datasource-store ctx source-id]
  (->> {:source-id source-id}
       (query-one! datasource-store ctx)
       core/id
       (delete! datasource-storex ctx)))

pez07:11:44

I can send images…

slipset07:11:10

In emacs/Cider the form which is (delete! datasource-storex ctx) is marked by a red squiggly, since datasource-storex is not defined.

pez07:11:49

Ah, I see. Yes, that would be really good.

slipset07:11:52

And I’d imagine you’d get the file line and col from the compiler exception

pez07:11:04

Can I ask for a new issue with just that suggestion? I don't know when I might have time to look at it, but it's good to have such issues for when I do have some times. They are fun. And also, maybe someone else finds it a fun feature to add.

pez08:11:20

A thing is that when you evaluate something, you really only give nrepl a chunk of code, so whoever is cooking the error messages can't really know about the file. But the file is a given anyway, so it is a matter of if you get the relative line and col and can work with that.

slipset08:11:01

It used to be like that in Cider many years ago (that you only got the /tmp/blabla/line thingy

slipset08:11:32

I’m sure @bozhidar can give you a hint or two 🙂

slipset08:11:09

BTW do you want issues directly on Github or do you prefer to discuss them here first?

slipset08:11:37

Also, don’t be shy on closing my issues if you don’t want to implement them.

pez08:11:42

Oh, I don't know. I think it I'd like the issue on Github and then link pasted here. The discussions here vanish, which is sometimes a good thing, but most often I want to have the reference still there.

pez08:11:28

I'll have a look at those tips too. I am actually thinking on writing something on the issue of maintaining OS projects.

pez08:11:00

Now my day job calls. I'll be unresponsive. 😃

slipset08:11:34

Fully understood. At dayjob myself 🙂 Have a nice day!

pez20:11:41

Now I started to read the maintainrers’ article. I wish I had those problems described there! 😃