Fork me on GitHub
#calva
<
2018-09-13
>
dijonkitchen18:09:11

@pez were you able to find anything with the terminal showing up all the time?

dijonkitchen20:09:47

@mattly I think I found the culprit! If you disable Calva: Sync Repl Namespace To Current File in the settings, you shouldn’t get the REPL on tab switch anymore!

dijonkitchen20:09:00

I can’t tell if this was recently enabled or not

pez20:09:08

@dijonkitchen: what you can do is to disable … yeah, you found it.

pez20:09:59

It was recently added. I will try to figure out if I can keep the terminal from popping up even with the feature enabld.

4
dijonkitchen20:09:33

Thanks! Maybe just have it disabled by default until that’s figured out?

dijonkitchen20:09:04

Interestingly enough, I think I’ve found another bug: my cljfmt no longer runs on save… =(

pez20:09:41

That is a VS Code issue, very intermittent.

dijonkitchen20:09:05

I can’t get it to run at all anymore. Doesn’t seem intermittent.

pez20:09:24

Could be something else then, but have you tried with a very small file?

dijonkitchen20:09:15

Ah yeah, so it works for 100 lines, but not for 200 lines. Those don’t seem THAT big though, haha.

pez20:09:52

No, it really should work. Calva is using cljfmt which isn’t super fast, but not all THAT slow either.

dijonkitchen04:09:23

OK, so the problem is it doesn’t work for “large” files (aka over 100 lines) now.

pez07:09:19

Or it only works sometimes for small files. 😃

pez07:09:42

The Parinfer people have even more problems making it work for VS Code.

dijonkitchen16:09:41

So should this be an issue in cljfmt?

mattly20:09:42

hm, would disabling this setting make the behavior of evaling code from different namespaces work not as expected?

pez20:09:02

@mattly you will have to sync the repl namespace manually (Default key binding ctrl+alt+v alt+n)

mattly20:09:13

aha, thanks

pez20:09:45

Also, it really only is about the Terminal REPL. I should change the description of the setting.

dijonkitchen20:09:46

Eeek, that’s right, no good. Guess it’ll still have to be fixed.

pez20:09:26

Calva didn’t have this auto sync before. That’s why this popping up of the terminal started to happen.

pez20:09:26

The issue with the formatting on save is that VS Code gives up a bit too fast on the formatting.

dijonkitchen20:09:25

Would linking into VSCode’s format on save be better?

dijonkitchen20:09:36

Might not need to build your own

pez20:09:39

It is sort of linked there. But the actual formatting has to be done by something that understands how to format Clojure code.

4
dijonkitchen16:09:41

So should this be an issue in cljfmt?