This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2019-01-31
Channels
- # aws (1)
- # beginners (70)
- # boot (12)
- # calva (45)
- # cider (45)
- # clara (1)
- # cljdoc (10)
- # cljs-dev (133)
- # clojure (315)
- # clojure-dev (2)
- # clojure-europe (2)
- # clojure-italy (16)
- # clojure-nl (1)
- # clojure-spec (23)
- # clojure-uk (19)
- # clojurescript (48)
- # cursive (11)
- # data-science (5)
- # datomic (18)
- # figwheel-main (3)
- # fulcro (18)
- # graphql (14)
- # jackdaw (1)
- # juxt (1)
- # kaocha (1)
- # off-topic (10)
- # other-languages (3)
- # pathom (2)
- # pedestal (7)
- # re-frame (23)
- # reagent (1)
- # reitit (4)
- # ring-swagger (12)
- # rum (4)
- # shadow-cljs (26)
- # specter (6)
- # speculative (12)
- # tools-deps (44)
- # vim (8)
- # yada (2)
So I’m using a boot task that has a dependency that doesn’t work on Clojure 1.9+. How do I fix this? I could either deploy a patched version of both libs to clojars and point to those or could I use with-call-in to replace the deps within the pod?
@jayzawrotny i would deploy a patched version, then make a PR on the original and when they merge/deploy switch to it and nuke your fork
an alternative is to make a wrapper task that runs the offending task in a pod, yes
the latter is probably more expedient, but doesn't address the root problem
Ok great, fortunately I already made the pull request with the fix first but it may not be deployed for a while. I think in this case a deployed patch might be a good idea for now.
Thanks for the explanation. Should I learn how to wrap the task and change the deps in a pod anyway?
@jayzawrotny can't hurt 😄
@jayzawrotny you could also improve the boot task, ideally the tasks should use pods to keep the libraries isolated
Yes, although if the problem is 1.9+ Alan is right that the root problem should really be fixed.
But a custom task that uses pods is another solution
Makes sense. Created PR fix https://github.com/hashobject/sitemap/pull/7, which was merged but not released, and created an issue on the parent boot task that uses the lib https://github.com/hashobject/perun/issues/221. So when its released and updated I’ll just nuke my fork as Alan suggested. That way it can be fixed for others as well.