Fork me on GitHub
#boot
<
2019-01-31
>
Eccentric J07:01:54

So I’m using a boot task that has a dependency that doesn’t work on Clojure 1.9+. How do I fix this? I could either deploy a patched version of both libs to clojars and point to those or could I use with-call-in to replace the deps within the pod?

alandipert18:01:32

@jayzawrotny i would deploy a patched version, then make a PR on the original and when they merge/deploy switch to it and nuke your fork

alandipert18:01:21

an alternative is to make a wrapper task that runs the offending task in a pod, yes

alandipert18:01:02

the latter is probably more expedient, but doesn't address the root problem

Eccentric J20:01:27

Ok great, fortunately I already made the pull request with the fix first but it may not be deployed for a while. I think in this case a deployed patch might be a good idea for now.

Eccentric J20:01:01

Thanks for the explanation. Should I learn how to wrap the task and change the deps in a pod anyway?

flyboarder21:01:06

@jayzawrotny you could also improve the boot task, ideally the tasks should use pods to keep the libraries isolated

Eccentric J21:01:03

Like make a pull request to fix the boot task?

flyboarder21:01:23

Yes, although if the problem is 1.9+ Alan is right that the root problem should really be fixed.

flyboarder21:01:46

But a custom task that uses pods is another solution

Eccentric J22:01:04

Makes sense. Created PR fix https://github.com/hashobject/sitemap/pull/7, which was merged but not released, and created an issue on the parent boot task that uses the lib https://github.com/hashobject/perun/issues/221. So when its released and updated I’ll just nuke my fork as Alan suggested. That way it can be fixed for others as well.