This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-08-29
Channels
- # aws (1)
- # beginners (78)
- # boot (27)
- # cider (16)
- # clara (15)
- # cljs-dev (84)
- # cljsjs (13)
- # cljsrn (19)
- # clojure (65)
- # clojure-france (10)
- # clojure-italy (8)
- # clojure-russia (35)
- # clojure-spec (34)
- # clojure-uk (124)
- # clojurescript (50)
- # clojutre (3)
- # core-async (16)
- # data-science (18)
- # datascript (1)
- # datomic (9)
- # emacs (2)
- # flambo (3)
- # fulcro (55)
- # graphql (3)
- # hoplon (4)
- # jobs (2)
- # juxt (21)
- # keechma (6)
- # lumo (73)
- # off-topic (4)
- # om (10)
- # onyx (5)
- # parinfer (1)
- # pedestal (3)
- # re-frame (60)
- # reagent (19)
- # specter (24)
@juhoteperi I am working on a patch for @anmonteiro's lumo and was wondering if there is a way to disable source maps now, given the bit here https://github.com/boot-clj/boot-cljs/blob/a182013465bcd36504f48b9bf4a950b656cbf851/docs/compiler-options.md#source-map
in lumo
we have :optimizations :simple
but we don't want the js.map
file...I know I could filter it out
just set :source-map
to false
?
yes that's the right answer, but it does not seem to work:
Released java.util.concurrent.Semaphore@163424e3[Permits = 1]...
• lumo.js
CLJS options:
{:output-dir
"/home/arichiardi/.boot/cache/tmp/home/arichiardi/git/lumo/47a/3gucn3/lumo.out",
:closure-defines
{cljs.core/*target* "nodejs", lumo.core/*lumo-version* "1.7.0"},
:static-fns true,
:dump-core false,
:optimize-constants false,
:cache-analysis true,
:optimizations :simple,
:parallel-build true,
:verbose true,
:output-to
"/home/arichiardi/.boot/cache/tmp/home/arichiardi/git/lumo/47a/3gucn3/lumo.js",
:asset-path "lumo.out",
:fn-invoke-direct true,
:source-map
"/home/arichiardi/.boot/cache/tmp/home/arichiardi/git/lumo/47a/3gucn3/lumo.js.map",
:compiler-stats true,
:main boot.cljs.main2673}
hmm true, the logic on boot-cljs is competely nonsense
If there is :source-map
option provided, but the not doing simple optimization, source-map is always enabled
well, I think you can remove the source-map task option, and instead just set source-map on the compiler-options instead
then boot-cljs doesn't do any additional logic
it is there already
probably it is merged upstream that function
aha, the source-map logic is done after merging compiler-options
this will need fix in boot-cljs, no workaround for now
ok, I can patch that, should I put if (:source-map opts)
on that line
it seems that the contains only would not be a good check there
There is probably some reason why it is written like that
yep true, it was an tentative patch 😄
I'll add tests for the source-map logic and see how it can be fixed
k cool, let me know what I can do there
@richiardiandrea https://github.com/boot-clj/boot-cljs/commit/345137ed6673d9c560ff725c2cf60f8cde3d073e does this look correct to you?
looks perfect now:
• main.js
CLJS options:
{:output-dir
"/home/arichiardi/.boot/cache/tmp/home/arichiardi/git/lumo/7xd/-pr3thn/main.out",
:closure-defines
{cljs.core/*target* "nodejs", lumo.core/*lumo-version* "1.7.0"},
:static-fns true,
:dump-core false,
:optimize-constants false,
:cache-analysis true,
:optimizations :simple,
:parallel-build true,
:verbose true,
:output-to
"/home/arichiardi/.boot/cache/tmp/home/arichiardi/git/lumo/7xd/-pr3thn/main.js",
:asset-path "main.out",
:fn-invoke-direct true,
:source-map false,
:compiler-stats true,
:main boot.cljs.main2675}
yes looks good, and I will try that locally
I'll push a new release
awesome