Fork me on GitHub
#boot
<
2017-07-14
>
kommen12:07:00

@richiardiandrea should reloading for target nodejs work with boot-figreload?

mbertheau12:07:00

The built-in notify task isn't making any sound for me. Is it correct to place it after watch before reload, cljs-repl, cljs-devtools and cljs? Also I'm calling it like this (notify :audible true). Is this correct?

richiardiandrea14:07:06

@kommen I did not test node and it was in the to-do list in the readme so thanks for trying and PR-ing

kommen14:07:47

@richiardiandrea looks really good here

richiardiandrea14:07:20

Awesome @kommen you could even tick the node box in the readme in the pr

kommen14:07:43

just one note: I tried rebasing https://github.com/bhauman/lein-figwheel/pull/537 onto the current lein-figwheel master, but this causes crashes in in boot-figreload: Illegal argument exception handled for <boot cache path>/cljs_deps.js

richiardiandrea14:07:57

kommen: ok so it is a no go then

richiardiandrea14:07:10

kommen: I have to speak with Bruce on that one

kommen14:07:07

ok, fwiw, I also get a warning with the current PR as it is now, and with the rebased PR this seems to escalate into a crash: Illegal argument exception handled for <boot cache dir>/cljs_deps.js

kommen14:07:37

I’m happy to serve as your Guinea pig if you have something to test, we’ll be using that stuff internally already soon

richiardiandrea14:07:54

Ok I will tell you whn I have something, but it can be next week or later because I am going to EuroClojure

kommen14:07:46

then let’s have a beer at EuroClojure? I’ll be there as well 🙂

richiardiandrea14:07:39

ok cool nice! We will for sure I hope you can recognize me from the picture, I think I won't be able to recognize you from your avatar 😄

kommen14:07:05

looks like its really hard to find a current picture of me online, I consider this as a success 🙂

grzm14:07:53

Is there a boot idiom comparable to leiningen's :global-vars {*warn-on-reflection* true}

alandipert15:07:16

@grzm (set! *warn-on-reflection* true) is a way, in build.boot or repl

grzm15:07:07

Cheers I tried that, and didn't see any warnings when running my tests. I don't think my code is that clean.

alandipert15:07:03

are you using boot-test? if so, it’s probably because boot-test runs your code in a pod… and you’d need to use boot-shim.clj to see an effect

grzm15:07:21

ah. That makes sense. Thanks.

alandipert15:07:32

interesting, looks like test also takes a startup function argument. you could point that at a function that turns on reflection warnings

alandipert15:07:41

i think that’s preferable to boot-shim.clj

grzm15:07:48

I've been using alt-test, too. I'll check if there's something similar.

geoffs16:07:29

@mbertheau: from what you describe, it sounds like your usage of notify is correct. I don't know why it wouldn't be playing any sound. Maybe try using one of the other themes and see if that makes a difference?