@micha: any chance you have an idea for a quick fix? or also how to fix the jar task?

Has anyone tried advanced compilation with latest boot-cljs?

@martinklepsch: i'll have a look

@juhoteperi: i have, works fine for me

Strange. None works fine for me but adv breaks.

actually maybe i'm not on latest latest

one sec i see

what's latest version?

1.7.48-2

testing

trying

clojure.lang.ExceptionInfo: java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: No implementation of method: :-compile of protocol: #'cljs.closure/Compilable found for class: nil

@juhoteperi: that’s what you expected? (build worked with -0)

Okay, I’m seeing the same

something isn't right, but no exceptions

multiple builds problems again

ugh

it's like that movie The Fly

i have a brundlefly page now

a weird merging of both things

@micha: What are you using multiple builds for?

i have index.js and test.js

Okay

not using ids

https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L1669-L1671 this does something different with optimizations

It tries to search for the main namespace in classpath.

And that is created to the temp dir and is not commited yet

hahaha

well played, cljs

I need to probably separate main ns writing from compile-1 so I can run that first for all builds, do the commit and then run all compilations

we need to special case this right?

like adding to classpath will break :none if we do that across the board

I don’t think it would break none?

that would be great

most of the namespaces are already in classpath, it’s just the main ns which is not

yeah

lol you got rid of my sweet macro

assoc-or or whatever

Yes 😄

hahaha

luckily i saved it on a post-it note on my refrigerator

in case i need it

You should have a utility function lib (everyone should have one)

yeah it's tricky though

because of dependencies

Yeah for boot tasks

i mean like i make a lot of things

and if i use my utility library in all of them i need to keep them all to the same version

and so on

We have a utility lib we use in app projects. For libraries we copy the necessary parts.

yeah i make mostly libraries really

all applictions tend to become libraries if they're useful enough

But the utility lib is good place to keep all the useful functions and test them.

yeah that's a good point

[micha/refrigerator-post-its "0.1.0-SNAPSHOT"] here we come

haha 😄

that might be a good use case for something like mranderson

but instead of static rewrite magic do it dynamically with eval

We have metosin/potpuri. It's medley in Finnish (weavejester’s utility fn lib is medley).

with the version number in the artifact id perhaps

(:require [potpuri-0-1-0.core :as pp])

It isn’t as easy to add main ns files to classpath as I thought

I didn’t remember each build has separate tmp-src

It would kill parallelism if we had to change classpath between each build

we just need to change the classpath of the pod

i.e. create with added :direcotries

Oh right

that should be easy

💥 ™️

pods ftw

https://github.com/adzerk-oss/boot-cljs/commit/58d0b5b446cffcc06db87d05bead073ab8c9d3f6 works for me now

very nice

i like that it can just get things from the classpath

Would be better if it could do everything with classpath 😄

yeah

totally

we have great tools for setting up classpaths

@micha: Do you know what was the problem with your project? Did you test with fixed version?

i haven't tested, 1.7.48-3?

Didn’t make a release yet

ok i can pull master

is it fixed on your end?

Yeah

It’s slow but I don’t think it unusually slow

Was there any changes to uberjar building yet? Advanced cljs build is 1min and the whole package task takes 2min

uber not yet optimized

we havea branch for it though

partially implemented

the idea is to cache the exploded contents of jars using the modtime of the associated jar file in .m2 to invalidate the cache

and storing them in such a way that they can be merged directly into the fileset

without copying anything

should be really fast

once the jar is caches

Cached where? Boot cache dir?

yeah

remember the persistent cache thing we implemented a while ago?

gonna use it now

Yeah

Is the bottleneck really decompressing the jars?

i think so

Interesting.

also a change we want to make is to have the jar task remove things it added to the jar from the fileset by default

or i mean add an option for that

a lot of time is spent writing out to target unnecessarily

so we could add an option to the jar task to suppress that, remove files it added to the jar from the fileset

move them to source paths probably

if you could profile your build that would be awesome too

Will the uber task be separate from jar in future too?

maybe you have some insight

yeah i think so

i think we can make it fast without needing to merge it into all the packaging tasks

caching will be a big help i think

I remember there was some speculation that a solution would be to add dependency jar contents directly to jar in jar task

so that fileset wouldn’t need to handle all the files in deps

yeah that was one plan

not so great though imo

but we need to do something

i want to see if caching works first though

the caching thing will be pretty useful generally too i think

(-> fileset (add-resource foo :cached? true) ...)

or something like that