Clojurians
#boot-dev
<
2018-01-07
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

bhagany18:01:59

oh! hey! there are two implementations of the fileset diffing

bhagany18:01:30

and the one that I'm having trouble with isn't the one I changed, so I am at least temporarily off the hook :slightly_smiling_face:

richiardiandrea20:01:32

@bhagany are there really?

richiardiandrea20:01:23

your tests seemed thorough to me at the time, maybe I have some blame on me as well :wink:

bhagany22:01:43

I don't think the second one needs to be modified in the same way, though. It only ever diffs on :time, and my modifications were only needed for diffing on nested data

bhagany22:01:19

@richiardiandrea meant to ping you :slightly_smiling_face:

bhagany22:01:31

right now, I think that sync-user-dirs! is working fine, but I don't really understand why we need it where it is in the task chain

bhagany22:01:18

it results in a mismatch between the filesystem and the fileset during the post-wrap phase, if boot/mv or (sift :move) are used

bhagany22:01:11

and that probably isn't usually a problem, because people are generally using target and the end of their task chain, but it does its thing before sync-user-dirs! runs, and thus before the mismatch occurs

bhagany22:01:07

however, if you're doing something like serving files from the fileset, then files that you've moved will exist until sync-user-dirs! runs, but then get moved back to their original positions afterward