Clojurians Log v2

Is there a way I could reproduce that command? With this in deps.edn:

{:deps {com.rpl/rama {:mvn/version "0.22.0"}
        com.biffweb/biff #:git{:url "", :sha "1570ccc", :tag "v1.8.29"}}}

$ clj
Error building classpath. Could not find artifact com.rpl:rama:jar:0.22.0 in central ()

{:deps {com.rpl/rama                   {:mvn/version "0.22.0"}
        better-cond/better-cond        {:mvn/version "2.1.4"}
        buddy/buddy-sign               {:mvn/version "3.4.333"}
        cider/cider-nrepl              {:mvn/version "0.51.1"}
        clj-http/clj-http              {:mvn/version "3.12.3"}
        com.nextjournal/beholder       {:mvn/version "1.0.2"}
        com.xtdb/xtdb-core             {:mvn/version "1.23.1"}
        com.xtdb/xtdb-jdbc             {:mvn/version "1.23.1"}
        com.xtdb/xtdb-rocksdb          {:mvn/version "1.23.1"}
        info.sunng/ring-jetty9-adapter {:mvn/version "0.17.2"}
        jarohen/chime                  {:mvn/version "0.3.3"}
        lambdaisland/uri               {:mvn/version "1.13.95"}
        metosin/malli                  {:mvn/version "0.16.1"}
        metosin/muuntaja               {:mvn/version "0.6.8"}
        metosin/reitit-ring            {:mvn/version "0.6.0"}
        nrepl/nrepl                    {:mvn/version "1.3.1"}
        org.clojure/tools.deps.alpha   {:git/url ""
                                        :sha "8f8fc2571e721301b6d52e191129248355cb8c5a"}
        org.clojure/tools.logging      {:mvn/version "1.2.4"}
        org.clojure/tools.namespace    {:mvn/version "1.4.4"}
        org.postgresql/postgresql      {:mvn/version "42.6.0"}
        refactor-nrepl/refactor-nrepl  {:mvn/version "3.6.0"}
        ring/ring-defaults             {:mvn/version "0.3.4"}
        rum/rum                        {:mvn/version "0.12.11"
                                        :exclusions [cljsjs/react cljsjs/react-dom]}
        com.biffweb/config             {:git/url ""
                                        :git/tag "v0.7.25"
                                        :git/sha "7e920b2"
                                        :deps/root "libs/config"}
        hawk/hawk                      {:mvn/version "0.2.11"}}}

Include this in your deps.edn

:mvn/repos {"rama" {:url ""}}

That'll allow you to grab Rama. This should allow you to start a REPL. Then, trying to evaluate a simple file like this:

(ns mynamespace
  (:use [com.rpl.rama]))

But thanks for the dependency list! That might be a good way to further narrow things down

Looks like it's the jetty adapter:

{:deps {com.rpl/rama                   {:mvn/version "0.22.0"}
        info.sunng/ring-jetty9-adapter {:mvn/version "0.17.2"}}
 :mvn/repos {"rama" {:url ""}}}

Apparently not; I still get the error from this:

{:deps {com.rpl/rama            {:mvn/version "0.22.0"}
        ring/ring-jetty-adapter {:mvn/version "1.14.1"}}
 :mvn/repos {"rama" {:url ""}}}

If you run clj -Stree with that deps.edn file and look for the Xs, you can see which dependencies from rama got overridden. I am seeing that rama uses an older version of jetty (9.4.31) and ring... actually looks like rama depends on ring/ring-jetty-adapter 1.8.2. So if we make biff use that, maybe that'll work.

Hang on... Just putting rama and

info.sunng/ring-jetty9-adapter {:mvn/version "0.17.2"}

cider/cider-nrepl              {:mvn/version "0.51.1"}

But then, putting

nrepl/nrepl                    {:mvn/version "1.3.1"}

very curious

So, the logging between nrepl, the adapter, and the apache slf4j provider creates weird problems..

Yeah sounds like it... I've also been a separate class not found exception for com.google.common.io.MoreFiles depending on which libs I include/exclude. That apparently comes from guava. So there might also be some issue with one of biff's dependencies using a different guava version or something.

problem seems to be fixed if I just include these two dependencies:

ring/ring-jetty-adapter {:mvn/version "1.8.2"}
        com.google.guava/guava {:mvn/version "29.0-jre"}

So, do you think if I add exclusions for the jetty9 adapter and guava, and then manually add those two, would Biff still work?

no need to exclude anything. I just ran the biff starter app with those two dependencies (and rama) added and it does run, and I can require com.rpl.rama. There is one last issue: trying to load the home page in the browser doesn't work because the rama dep has a public/index.html file in its resources, which is... not what a library should be doing. However we can get around that by hacking biff's middleware so it tries requests against its own reitit routes first before checking for static resources:

diff --git a/starter/src/com/example/middleware.clj b/starter/src/com/example/middleware.clj
index 4162bbe..66966af 100644
--- a/starter/src/com/example/middleware.clj
+++ b/starter/src/com/example/middleware.clj
@@ -1,8 +1,11 @@
 (ns com.example.middleware
-  (:require [com.biffweb :as biff]
+  (:require [clojure.string :as str]
+            [com.biffweb :as biff]
             [muuntaja.middleware :as muuntaja]
             [ring.middleware.anti-forgery :as csrf]
-            [ring.middleware.defaults :as rd]))
+            [ring.middleware.defaults :as rd]
+            [ring.middleware.resource :as res]
+            [ring.middleware.content-type :refer [wrap-content-type]]))
 
 (defn wrap-redirect-signed-in [handler]
   (fn [{:keys [session] :as ctx}]
@@ -31,6 +34,20 @@
       (def response* response)
       response)))
 
+(defn wrap-resource [handler]
+  (fn [{:biff.middleware/keys [root index-files]
+        :or {root "public"
+             index-files ["index.html"]}
+        :as ctx}]
+    (let [response (handler ctx)]
+      (if (not= (:status response) 404)
+        response
+        (or (->> index-files
+                 (map #(update ctx :uri str/replace-first #"/?$" (str "/" %)))
+                 (into [ctx])
+                 (some (wrap-content-type #(res/resource-request % root))))
+            response)))))
+
 (defn wrap-site-defaults [handler]
   (-> handler
       biff/wrap-render-rum
@@ -54,7 +71,7 @@
 (defn wrap-base-defaults [handler]
   (-> handler
       biff/wrap-https-scheme
-      biff/wrap-resource
+      wrap-resource
       biff/wrap-internal-error
       biff/wrap-ssl
       biff/wrap-log-requests))

With that last change in place though everything seems to work perfectly, even the websockets.

Hmmm. It seems to be working fine when I put all those in 1 deps.edn, but I had it so that the biff project was in a separate deps.edn which is imported through a

:local/root

Got It! Thank you so much!

I still have a little bit to go to get everything set up, but I hope I can get past any further hurdles now

interesting re: the :local/root thing. maybe something to do with clj's dependency resolution... e.g. I think any version that aren't in the top-level deps.edn are basically suggestions. Good luck in any case! Let me know if you get stuck on anything and I can try to poke around a bit more.

@foo or @xarlyle0 can you post a gist or example code of this integration?

I think what I ended up was to add this to your deps.edn:

{:deps {...
        com.rpl/rama            {:mvn/version "0.22.0"}
        ring/ring-jetty-adapter {:mvn/version "1.8.2"}
        com.google.guava/guava {:mvn/version "29.0-jre"}}
 :mvn/repos {"rama" {:url ""}}
 ...}