Fork me on GitHub
#biff
<
2023-09-09
>
Jacob O'Bryant15:09:24

Biff v0.7.11 is out. See the https://github.com/jacobobryant/biff/releases/tag/v0.7.11 for full changes and upgrade instructions. The biggest things are: - Some changes to the template project to make stuff (middleware and the on-error handler) easier to modify. - A new https://biffweb.com/docs/api/utilities/#s3-request function--handy for use with e.g. digitalocean spaces without needing to bring in all of amazonica/the cognitect aws lib. - bb deploy now uses rsync (if available) instead of git push. I also fixed the rsync command so that it actually works on Mac (previously bb soft-deploy / bb prod-dev didn't work on Mac, at least not on mine... not sure if lots of people were hitting this and just didn't mention it, other than one person, or if most people just do bb deploy instead of bb prod-dev).

8
㊗️ 2
Martynas Maciulevičius17:09:12

I have a question. Why would I want to .gitignore the file config.edn? My actual secrets are put into secrets.env so the actual secrets should be good, right? I'm thinking about uncommenting that gitignore line and pushing the config :thinking_face:

Jacob O'Bryant18:09:19

you can add it to git. I might change that to the default at some point. the only reason I can think of to not commit it is if it's an open-source app that might be deployed by different people.

Martynas Maciulevičius05:09:07

What I did to my app was to split the variables into SESSION_SECRET_DEV and SESSION_SECRET_PROD. This way I have only one config and don't mess with it all the time :thinking_face: I didn't migrate the semi-public secrets of recaptcha but I probably will move them fully out of the EDN file.

👍 2
Martynas Maciulevičius09:09:43

Hm. I'm currently thinking about having a postgresql DB backend and there is a problem. I can't really take my config.edn file and move some of the env vars into the secrets.env. Do you think it's a good idea to resolve env variables automatically? Because currently it's hardcoded which ones are resolved. And then it's not known where I need to call secrets or where I can use the variable as-is. Basically it's hardcoded all over the place. https://github.com/jacobobryant/biff/blob/6428c7f00540b5f15bec1dbbdf84d717fe2a7ef7/src/com/biffweb/impl/xtdb.clj#L72 It's also the same for captcha pubkey. I don't like that it's an inconsistent approach and it won't work if for some stupid reason I'll decide to have two different DB nodes at some point.