The function is just:

(defn annual-balance-update                                                                                                 
  [balance]                                                                                                                 
  (bigdec                                                                                                                   
    (+ balance 
       (* 0.01 (.abs balance) (interest-rate balance)))))

The other failing test is:

; FAIL in (annual-balance-update-huge-positive-balance-test) (NO_SOURCE_FILE:57)                                            
; expected: (= 920352587.26744292868451875M (interest-is-interesting/annual-balance-update 898124017.826243404425M))        
;   actual: (not (= 920352587.26744292868451875M 920352587.267443M))      

I've tried turning everything in that fn to a Big Decimal and such but my answer isn't changing.

Doubles are contagious, so interest rate returning a double will cause imprecise double math to be used for the whole expression

Interesting. The exercise required the interest rate to return a double. When I convert the interest rate to a BigDecimal in the annual-balance-update fn I still get the same incorrect precision.

have you tried with-precision?

i will either do that or define an appropriate EPSILON and have a equal-within-tolerance? test helper.

This may or may not be helpful user=> (* 0.1 0.2) 0.020000000000000004 user=> (bigdec (* 0.1 0.2)) 0.020000000000000004M user=> (* (bigdec 0.1) (bigdec 0.2)) 0.02M user=> (= (* (bigdec 0.1) (bigdec 0.2)) (bigdec 0.02)) true

Yeah, the solution was to multiply by 0.01M instead of 0.01 which I was sure I had tried early on in the process. Thanks folks.

you can use option :unexceptional-status to specify that 422 should be treated as OK response https://github.com/dakrone/clj-http#exceptions

there are other options as well. for example: with :throw-exceptions false instead of exception thrown from clj-http you will get normal ring response if you want to handle status yourself

v0.4.9 tag is available, still got that error - https://github.com/seancorfield/deps-new/releases/tag/v0.4.9

Tried with v0.4.8 and got same error. Something wrong on my side? clojure -Ttools install io.github.seancorfield/deps-new '{:git/tag "v0.4.8"}' :as new Execution error (ExceptionInfo) at clojure.tools.deps.alpha.extensions.git/coord-err (git.clj:45). Library io.github.seancorfield/deps-new has invalid tag: v0.4.8

Are you on windows using cmd ?

if you are, see https://clojurians.slack.com/archives/C053AK3F9/p1642530603498900

Yes, installed CLI via scoop.

Thank you. It was quote issue. This one worked - clojure -Ttools install io.github.seancorfield/deps-new '{:git/tag ""v0.4.9""}' :as new

Ah this seems rather enlightening https://lambdaisland.com/blog/2020-06-12-logging-in-clojure-making-sense-of-the-mess

(read-string (slurp url))

(read-string "(slurp \"\")") just returns the form for me

it can construct arbitrary Java classes using # or run arbitrary code with #=

I mean the string passed to read string will call read string on a slurped file

Letting you load arbitrary code from outside. Fun :)

(read-string "#=(launch-missiles)")

here’s a very concrete example with arbitrary shell access

(read-string "#=(clojure.java.shell/sh \"echo\" \"hi\")")

That ClojureDocs page still holds up well. The Clojure version numbers mentioned seem pretty old now 🙂

Concrete example:

$ clj                                                                                                                                                                                                 Clojure 1.10.3
user=> (read-string "#=(java.lang.System/exit 1)")

$

Veery good to know. Thanks team!

The problem is the macro in my getting started example!

Perhaps you can add a hook to an exported clj-kondo which expands in a :refer [x y z] thing so clj-kondo knows what vars are imported from SICMUtils

I think we discussed this issue before, somewhere, not sure

We did! I avoided it as an emacs user, https://github.com/sicmutils/sicmutils/issues/378 but this was the ticket

In emacs you will have the same problems I think.

but yes, the approach described in the issue would still be what I would recommend, or hardcode (programmatically perhaps) the vars in the hook expansion. that would be even more robust.

I should have said, as an emacs user with an old pre-clj-kondo config :)

I will bump this way up! And turn on kondo for myself

ok let me know if you need help, we will fix it

off to bed now 💤

Hold up, made a new project with the exact same deps.edn file and the issue seems to have magically solved itself (image of my .clj file linked) :thinking_face:. I have the suspicion the bug is on the Calva extension side, unless I did something different I haven't noticed yet.

Yup, on my other file the linting error is like stuck somehow.

!!

very strange, @easturiano! well, I still have some tidying to do with my clj-kondo integration so I wouldn’t be surprised if you hit more stuff. but this is good news!

@easturiano also would love to hear what you’re up to with #sicmutils, ask any Qs and feel free to chat whenever!

Thanks!

I was following one of the begninner's tutorials so in my src/playground.clj file I only typed in (ns playground) (require '[sicmutils.env :as env :refer :all])

From the tutorial I additionally made a deps.edn file on the same directory and copy pasted {:paths ["resources" "src"]  `:deps {org.clojure/clojure {:mvn/version "1.10.3"}`         nrepl/nrepl {:mvn/version "0.9.0"}         sicmutils/sicmutils {:mvn/version "0.20.1"}}}

Interesting, :refer :all should totally work. I have that issue when I use (require '[sicmutils.env :as env]) (env/bootstrap-repl!)

I can try to recreate when I get to a machine, but it would be great if you could paste the full contents of the file that causes those linting issues

My file is src/playground.clj and its contents are

(ns playground)

(require '[sicmutils.env :as e :refer :all])

(comment
  (- (* 7 (/ 1 2)) 2)
  (asin -10)
)

It is not quite that, it is this macro I created to simulate :refer :all for cljs users :(

Good news is that is not needed in clj only, so I can help here

Thank you so much for the answer but I in my case I wouldn't like to execute the code of the data-readers, for example:

(set! *data-readers* (assoc *data-readers* 'foo (fn [x] (list 'clojure.core/+ 1 1))))

(fn []
{:a #foo 1})
=> {:a #foo 1}

{:a 2}

I don't really know if it's possible since as far as I know the reader step is made before the evaluation. But I don't have sure about that

@U0NCTKEV8 I don't know if I was clear enough, please let me know if I need to elaborate the question a little bit more.