Just to be clear, you’re trying to exclude keys from the response of the GET call? or is exclude part of the GET schema and it’s not working?

I try to exclude keys from the respons

but I see now this message

missing value for key "alerts"

can maybe wrap your response with dissoc?

(dissoc (ajax/GET...) "minutely" "current" "daily" "alerts")

(-> (ajax/GET ...)
    (dissoc "minutely" "current" "daily" "alerts")  

hmm, is it then a part of the call

it looks not to me

or do I misunderstood you

maybe I’m misunderstanding you.. if you want to remove keys from the response map you got back from calling axios/GET you can wrap that call with dissoc.

(defn get-forecast! []
  (-> (ajax/GET ""
                {:params {"q" (:postal-code @app-state)
                          "units" "metric" ;; alternatively, use "metric"
                          "appid" "xxxxxx"
                          "alerts" "xxxx"}
                 :handler handle-response})
      (disocc "minutely" "current" "daily" "alerts")))

no, On the website of openweather api is stated that I can use exclude to exclude parts of the respons

but when I try it i see a error message

According to https://openweathermap.org/api/one-call-api the arguments to "exclude" should be "a comma-delimited list (without spaces)".

Does something like this work for you?

{"q" postal-code
 "units" "metric"
 "appid" "xxxxxx"
 "exclude" "minutely,current,daily,alerts"}

Using clj-http this call works perfect

(client/get url
            {:accept :json
             :query-params {"lat" 41.3888
                            "lon" 2.159
                            "exclude" "minutely,current,daily,alerts"
                            "appid" api-key}}))

onecall does not accept q as param

chips, then I have to find a way to convert a place to the lat and long 😞

and why is longtitude still not resolved here :

(defn get-forecast! []
  (let [latitude (:latitude @app-state)]
       [longtitude (:longtitude @app-state)]
  (client/get ""
              {:accept :json
               :query-params {"lat" latitude
                              "lon" longtitude
                              "exclude" "minutely,current,daily,alerts"
                              "appid" api-key}})))

It's hard to tell without seeing the rest of your app. The question is why @app-state doesn't have :longitude (notice the spelling).

it has :

(ns ^:figwheel-hooks learn-cljs.weather
  (:require
   [goog.dom :as gdom]
   [reagent.dom :as rdom]
   [reagent.core :as r]
   [clj-http.client :as client]))


(defonce app-state (r/atom {:title "WhichWeather"          ;; <1>
                            :latitude 0 
                            :longtitude 0 
                            :temperatures {:today {:label "Today"
                                                   :value nil}
                                           :tomorrow {:label "Tomorrow"
                                                      :value nil}}}))

(defn handle-response [resp]
  (let [today (get-in resp ["list" 0 "main" "temp"])
        tomorrow (get-in resp ["list" 8 "main" "temp"])]
    (swap! app-state
           update-in [:temperatures :today :value] (constantly today))
    (swap! app-state
           update-in [:temperatures :tomorrow :value] (constantly tomorrow))))

(defn get-forecast! []
  (let [latitude (:latitude @app-state)]
       [longtitude (:longtitude @app-state)]
  (client/get ""
              {:accept :json
               :query-params {"lat" latitude
                              "lon" longtitude
                              "exclude" "minutely,current,daily,alerts"
                              "appid" api-key}})))

Thanks for sharing 🙂 So now it works?

nope, still a red line under longtitude on both places on the get-forecast method

Oh, I see. There is a syntax error in the let binding. Combine the two binding vectors into one

Instead of (let [x val1] [y val2] ...) it should be (let [x val1 y val2] ...)

thanks

now I have to think how to store things the best way in the atom. There will be 4 times a hour and four times a temperature

but first lunch

PI is not an instance method of Math , so (.PI Math) fails. The former works, because (. class member) is a special form. See https://clojure.org/reference/java_interop for detailed explanation. Also, it would be more idiomatic to use Math/PI for static fields.

ahh.. I can’t do it because Math isn’t an instance, it’s a Class.. got it

=> (def p (java.awt.Point. 10 20))
=> (.x p)
=> 10

(defn sec-subsec [x]
  {:sec (long (Math/floor x))
   :subsec (mod x 1)})

thank you! WHy is it always so obvious once someone points it out 😄

mod x 1 Ain't there just a use for everything

Or, if you care about the float drift:

(defn sec-nanos [x]
  {:sec (long (Math/floor x))
   :nanos (-> x (* 1e9) (mod 1e9) (long))})

Rich Hickey has a talk called "Are we there yet" on InfoQ that is highly recommended. Uncle Bob has a mixed reception on these forums but we all love Clojure so that's cool.

Thank you! I'll take a look at this.

Vector of maps? Atoms can hold any value.

Are you sure you need an atom, though?

i think so, the lessons I follow uses a atom

till now I have only learned to write clojurescript like this : https://www.learn-clojurescript.com/section-1/lesson-8-capstone-weather-forecasting-app/

@UJY23QLS1

how are you finding that site for learning clojurescript ?

till now good

but I think they misss the part to teach to solve the part to display a 4 hours prediction

@U013YN3T4DA

its not clear to me from that site how the api works... (get-in resp ["list" 0 "main" "temp"]) = today, (get-in resp ["list" 8 "main "temp"]) = tomorrow... The only thing different is the 0 > 8, but I can't see why 8 = tomorrow...

ah, ok, so from the site:

You can search weather forecast for 4 days (96 hours) with data every hour by city name

https://openweathermap.org/forecast5

^ it looks like the zipcode API returns a sorted list; each entry is every 3 hours; so 8*3 = 24 hours ahead 😅

What's happening here is

(get-in resp ["list" 0 "main" "temp"])

the hourly forecast looks to be a different api endpoint: https://openweathermap.org/api/hourly-forecast

(note /forecast/hourly?q= vs /forecast?q=)

(group-by #(get % "dt_text") (get resp "list"))

@U0EGWJE3E I just realized if these are your first steps with CLJS, I suspect the intention of the exercise is to just replace the API forecast endpoint with the forecast hourly endpoint; and change handle-response function to take into account the first 4 entries from "list" instead of the ones that are now defined as today and tomorrow.

Feel free to post some code if you get stuck :]

I do also not see where the 8 is coming from

I see this a json

{"coord":{"lon":6.7931,"lat":52.2658},"weather":[{"id":804,"main":"Clouds","description":"overcast clouds","icon":"04d"}],"base":"stations","main":{"temp":285.4,"feels_like":284.82,"temp_min":284.71,"temp_max":286.69,"pressure":1015,"humidity":82},"visibility":10000,"wind":{"speed":1.79,"deg":192,"gust":4.47},"clouds":{"all":92},"dt":1635177482,"sys":{"type":2,"id":2010748,"country":"NL","sunrise":1635142540,"sunset":1635178671},"timezone":7200,"id":2754394,"name":"Hengelo","cod":200}

yeah, the 8 is just an index

oke

the challenge I try to solve is this :

Modify the app to display a forecast for the next 4 hours

and within this call I cannot do this

yeah, like we've ssaid, you need to change the api call to get hourly

then just take the first 4 items

so as far as I see I need to call this api key}

oke, so you are saying I only have to store 4 temps

have you seen (get-in) before ? Here is where the 8 is coming from (I've tried to simplify a bit)

(let [resp {"list" [{:main {:temp 55 :rain false}}
                    {:main {:temp 33 :rain true}}
                    {:main {:temp 22 :rain false}}]}]
  (get-in resp ["list" 1 :main :temp]))

yep, I see

This api looks like the one you want: key}

where in "list" it returns a vector of items, one per hour

oke, so I use the wrong api call

https://openweathermap.org/api/hourly-forecast vs https://openweathermap.org/forecast5

aha, I use the free one

oh, I didn't realize one of them was paid...

np

I think I can use the forecasr5 one

oke, but still one thing I do not see

> Modify the app to display a forecast for the next 4 hours Well, I suppose you could "interpret" this to mean: take the first and second entry in the "list" - that will give you time now and 3 hours from now

^ using the free forecast5

in the orginal one this is used

defonce app-state (r/atom {:title "WhichWeather"          ;; <1>
                            :latitude 0
                            :longtitude 0
                            :temperatures {:today {:label "Today"
                                                   :value nil}
                                           :tomorrow {:label "Tomorrow"
                                                      :value nil}}}))

how do I change it so it can store 4 temps

So, first consider where you will get 4 temps from? Because the forecast5 returns a forecast for every 3 hours

Are you connected to a REPL?

oke, if it's right I can also "store" the current one and the one for 3 hours

you mean a figtweel repl or a "standard" one

I my head I have to display the current one , over 1 hour, over 2 hours and so on

but I think if I understand the current one and over 3 hours I can adapt things

Try to run something like this on the response:

(map #(get % "dt_txt") (get resp "list"))

You'll notice the API returns something every 3 hours; so either you need a different API endpoint or to re-think the problem

moment, I have to rewrite my call

im going crazy

`

clj꞉learn-cljs.weather꞉>(get-forecast!)
; Syntax error compiling at (output.calva-repl:38:25).
; Unable to resolve symbol: get-forecast! in this context

im in the right namespace

(ns ^:figwheel-hooks learn-cljs.weather
 (:require
   [goog.dom :as gdom]
   [reagent.dom :as rdom]
   [reagent.core :as r]
   [clj-http.client :as client]))


(defonce app-state (r/atom {:title "WhichWeather"          ;; <1>
                            :latitude 0
                            :longtitude 0
                            :temperatures {:today {:label "Today"
                                                   :value nil}
                                           :tomorrow {:label "Tomorrow"
                                                      :value nil}}}))

(defn handle-response [resp]
  (let [today (get-in resp ["list" 0 "main" "temp"])
        tomorrow (get-in resp ["list" 8 "main" "temp"])]
    (swap! app-state
           update-in [:temperatures :today :value] (constantly today))
    (swap! app-state
           update-in [:temperatures :tomorrow :value] (constantly tomorrow))))

(def api-key "fa9930ab5e2a87f9770d1c90d68f9da1")

(defn get-forecast! []
  (let [latitude (:latitude @app-state)
        longitude (:longitude @app-state)]
  (client/get ""
              {:accept :json
               :query-params {"q" "hengelo"

Make sure you evaluated the file

I do not did that

are you in Calva? > Do this with Load Current File and Dependencies, ctrl+alt+c enter.

yep, im in calva on a deps.edn and figwheel repl

did it work to load file and run the function?

nope

Evaluating file: weather.cljs
; Syntax error (FileNotFoundException) compiling at (weather.cljs:1:1).
; Could not locate goog/dom__init.class, goog/dom.clj or goog/dom.cljc on classpath.
; Evaluation of file weather.cljs failed: class clojure.lang.Compiler$CompilerException

brb

so, the problem is Calva thinks it is compiling Clojure code, not ClojureScript code

this usually means that something went wrong with how the editor connected to the repl

I don't use Calva (or figwheel) myself, but this description in the README may be helpful: https://github.com/PEZ/fresh-figwheel-main#note-about-using-this-with-calva

I know this may seem like swimming upstream, but I encourage you to try to sort out the environment issues and get a working REPL in Calva first - it will make the rest of your learning journey far more enjoyable. There is also a #calva channel where you can ask questions if you get stuck.

im crazy now

No such namespace: clj-http.client, could not locate clj_http/client.cljs, clj_http/client.cljc, or JavaScript source providing "clj-http.client" (Please check that namespaces with dashes use underscores in the ClojureScript file name) in file src/learn_cljs/weather.cljs

   1  (ns ^:figwheel-hooks learn-cljs.weather
   2    (:require
   3     [goog.dom :as gdom]
   4     [reagent.dom :as rdom]
   5     [reagent.core :as r]
   6     [clj-http.client :as client]))
          ^---
   7  
   8  
   9  (defonce app-state (r/atom {:title "WhichWeather"          ;; <1>
  10                              :latitude 0
  11                              :longtitude 0

What does your deps.edn look like?

got it working

use ajax.core again

oke, I see now

(get-forecast!)
#object[Object [object Object]]

so I think I have to use str

brb

np

even this is not helping

require '[clojure.pprint :as pp]
                #_=>          )
nil
learn-cljs.weather=> (pp/pprint(get-forecast!))
#object[Object [object Object]]

@U0EGWJE3E OK, so here's the thing

your function (get-forecast!) is probably returning a promise

but let's take a step back

in your weather.cljs file add a comment form:

(comment

  (+ 2 2)

#__)

and try to eval that (+ 2 2) via ctrl+enter - does that work for you?

you can even make sure it's evaling in JS by doing something silly like: (+ "2" 2)

I do not think so , I never see 4 as answer

> Evaluate Current Top Level Form (defun), alt+enter.

hmm, do you see an error?

I did now got the repl with clojure -A:fig:build

OK, so you can eval in the repl window, but not in the file directly?

looks like it

But this works? > Do this with Load Current File and Dependencies, `ctrl+alt+c enter`.

Have you tried this, where you don't start a repl in the terminal - but instead you allow Calva to start it for you and follow these instructions: https://github.com/PEZ/fresh-figwheel-main#note-about-using-this-with-calva

I will try that

moment

then I see this in my repl

clj꞉user꞉> 
; Evaluating file: weather.cljs

and no prompt anymore

maybe because of this

; Execution error (FileNotFoundException) at user/eval5624 (REPL:1).
Could not locate figwheel/main/api__init.class, figwheel/main/api.clj or figwheel/main/api.cljc on classpath.

yeah, that would do it;

what does your deps.edn look like?

`

{:deps {org.clojure/clojure {:mvn/version "1.10.0"}
        org.clojure/clojurescript {:mvn/version "1.10.773"}
        reagent {:mvn/version "0.10.0" }
        cljs-ajax {:mvn/version "0.8.1"}}
 :paths ["src" "resources"]
 :aliases {:fig {:extra-deps
                  {com.bhauman/rebel-readline-cljs {:mvn/version "0.1.4"}
                   com.bhauman/figwheel-main {:mvn/version "0.2.11"}}
                 :extra-paths ["target" "test"]}
           :build {:main-opts ["-m" "figwheel.main" "-b" "dev" "-r"]}
           :min   {:main-opts ["-m" "figwheel.main" "-O" "advanced" "-bo" "dev"]}
           :test  {:main-opts ["-m" "figwheel.main" "-co" "test.cljs.edn" "-m" "learn-cljs.test-runner"]}}}

that is the one given in the course

So, figwheel is there under aliases:

com.bhauman/figwheel-main {:mvn/version "0.2.11"}

> then I see this in my repl > clj꞉user꞉>  > ; Evaluating file: weather.cljs

^ which step in the process is this?

after #1 - #5 following that guide?

after #5 and I choose the dev I see the error message

the part you posted is after doing ctrl+alt+c enter``

after # 5 of course

I notice that repo has this file: https://github.com/PEZ/fresh-figwheel-main/blob/master/dev.cljs.edn

perhaps you need to add something like to your project?

just change {:main fresh-figwheel-main.core} to your namespace

so: {:main learn-cljs.weather}

yep

that one looks like this : `

^{:watch-dirs ["src"]
  :css-dirs ["resources/public/css"]
  :auto-testing true
   }
{:main learn-cljs.weather}

Yep, seems dev.cljs.edn is a figwheel-main thing: https://figwheel.org/

he, I miss here the core part

yep, as in it worked; or it was already there? :)

(I'm doing a lot of guessing as a non-calva and non-figwheel user :P)

no idea, i added it

now

OK, let's hope that's what was missing to get #5 to work

I will start up a repl again

yep; do it per the instructions via Calva start + jack-in and not from the terminal

yep, and no luck

same error?

yep and a second time it seems to work

> Connected session: cljs, repl: dev ??

Or Connected session: clj

and 3th time no luck

Connected session: clj
; TIPS: 
;   - You can edit the contents here. Use it as a REPL if you like.
;   - `alt+enter` evaluates the current top level form.
;   - `ctrl+enter` evaluates the current form.
;   - `alt+up` and `alt+down` traverse up and down the REPL command history
;      when the cursor is after the last contents at the prompt
;   - Clojure lines in stack traces are peekable and clickable.
clj꞉user꞉> 
; Creating cljs repl session...
; Connecting cljs repl: deps.edn + Figwheel Main...
;   The Calva Connection Log might have more connection progress information.
; Starting cljs repl for: deps.edn + Figwheel Main...
; Execution error (FileNotFoundException) at user/eval5624 (REPL:1).
Could not locate figwheel/main/api__init.class, figwheel/main/api.clj or figwheel/main/api.cljc on classpath.
; Failed starting cljs repl
; Jack-in done.
clj꞉user꞉> 

I choose that one because there is no choice clojure + figwheel main

hmmmm

OK, https://github.com/BetterThanTomorrow/calva/issues/728

it looks like that may have changed in the meantime and figwheel is explicitly required

Does Calva give an option where you can in fact specificy deps aliases?

If so, let's do the opposite of: > 3. Don't pick an alias <- This trips many people up, the :fig alias doesn't start things in the way Calva needs And let's tell it to use alias :fig (which includes the correct dependency)

Perhaps that will work? 🤞

you are a genius

; Starting cljs repl for: deps.edn + Figwheel

finanly

clj꞉cljs.user꞉> 
; Evaluating file: weather.cljs
nil

nice

Can we eval some code in a (comment ...) in our file?

yep, that one gives nil

and if I only do the (+ 2 2) part I see 4

right, evaling (comment (+ 2 2)) will give nil, but if you put your cursor anywhere inside (+ 2 2) and run alt+enter you should see 4

but this :

(def api-key "xxxx")

(defn get-forecast! []                                     ;; <3>
  (let [postal-code (:postal-code @app-state)]
    (ajax/GET ""
      {:params {"q" postal-code
                "units" "imperial" ;; alternatively, use "metric"
                "appid" api-key}
       :handler handle-response})))

(get-forecast!)

still gives a object 😞

awesome; as an up-and-coming Clojure developer you can now remember: no one writes code directly in the REPL window; you should just work in the files and namespaces directly; and things like (get-forecast!) keep inside a (comment ) so it doesn't get evaluated accidentally

oke

so, we've come full-circle and can now work on our problem :)

and when I do this in repl

(pp/pp (get-forecast!)) 
; WARNING: Use of undeclared Var learn-cljs.weather/  at line 1 <cljs repl>
; #object[SyntaxError SyntaxError: missing name after . operator]
; figwheel$repl$eval_javascript_STAR__STAR_@http://localhost:9500/cljs-out/dev/figwheel/repl.js:767:24
; @http://localhost:9500/cljs-out/dev/figwheel/repl.js:815:56
G__12961__2@http://localhost:9500/cljs-out/dev/cljs/core.js:36159:106
G__12961@http://localhost:9500/cljs-out/dev/cljs/core.js:36426:20
figwheel.repl.ws_connect.cljs$core$IFn$_invoke$arity$variadic/</<@http://localhost:9500/cljs-out/dev/figwheel/repl.js:1069:30
goog.events.EventTarget.prototype.fireListeners@http://localhost:9500/cljs-out/dev/goog/events/eventtarget.js:285:23
goog.events.EventTarget.dispatchEventInternal_@http://localhost:9500/cljs-out/dev/goog/events/eventtarget.js:383:26
goog.events.EventTarget.prototype.dispatchEvent@http://localhost:9500/cljs-out/dev/goog/events/eventtarget.js:196:34
goog.net.WebSocket.prototype.onMessage_@http://localhost:9500/cljs-out/dev/goog/net/websocket.js:114:8

REPL is probably in the wrong namespace; but feel free to ignore that - just eval code from the file and Calva keeps track of which namespace it should be in

oke, so we getting some I think json which we destruct with the handle method

exactly

so here is my suggestion:

(comment
  (def raw-data (atom nil))
)

let's eval something like that

then we can change our function handler to something like this:

:handler (fn [resp] (reset! raw-data resp))

that gives

#'learn-cljs.weather/raw-data

after you change the function, eval it as well

(that will update the definition of the function)

and then we can add some more code:

(comment
  (get-forecast!)
  
  @raw-data
)

so evaling the first thing will now run our new version of the function

and evaling the second should deref our data and we should see everything the API was returning

does that make sense? did it work?

the handler change gives this :

#'learn-cljs.weather/get-forecast!

yep; just the compiler reporting that it updated the var

moment

this is not working

(comment
  (get-forecast!)
  
  @raw-data
)


(defn get-forecast! []                                     ;; <3>
  (let [postal-code (:postal-code @app-state)]
    (ajax/GET ""
      {:params {"q" postal-code
                "units" "metric" ;; alternatively, use "metric"
                "appid" api-key}
       :handler (fn [resp] (reset! raw-data resp))})))

on the comment get-forecast and @raw-data is unknown

on the get-forecast raw-data is now not known

try something like this:

(def raw-data (atom nil))

(defn get-forecast! ..)

(comment

  (get-forecast!)

  @raw-data
)

I think Calva clojure-lsp linter is complaining about order of things in the file

^ just make sure you always eval the top-forms when you add them so the REPL also knows about them

yep

this is given nil

(comment
  (def raw-data (atom nil)))
  

(defn get-forecast! []                                     ;; <3>
  (let [postal-code (:postal-code @app-state)]
    (ajax/GET ""
      {:params {"q" postal-code
                "units" "metric" ;; alternatively, use "metric"
                "appid" api-key}
       :handler (fn [resp] (reset! raw-data resp))})))

(comment
  (get-forecast!)
  
  @raw-data
)

when evaling the comment right? but what about when evaling the forms inside the comment?

also

try (def raw-data without the comment

and make sure you eval it first, then get-forecast!

so it updates the right pointer

(def raw-data (atom nil)) ;; <1>
  

(defn get-forecast! []                                     ;; <2>
  (let [postal-code (:postal-code @app-state)]
    (ajax/GET ""
      {:params {"q" postal-code
                "units" "metric" ;; alternatively, use "metric"
                "appid" api-key}
       :handler (fn [resp] (reset! raw-data resp))})))

(comment
  (get-forecast!)  ;; <3>
  
  @raw-data   ;; <4>
)

<order of eval>

then I see this error on #3

; #object[Error Error: No protocol method IDeref.-deref defined for type undefined: ]

ah! it must have failed on @app-state

maybe start by reloading the the entire file

and then do 1 - 4

ah, I know the problem..

i did that on see on the get-forecast a object

and on @raw-data nil

perhaps you need to wait a bit and try to eval @raw-data again

it's an asynchronous http request, right?

I think so because it s from a ajax lib

you can always try something like:

:handler (fn [resp] (println "Done!") (reset! raw-data resp))

so now I have to wait till I see done

BTW, there is also an :error-handler if things go wrong, that by default should be printing to the browser console

https://github.com/JulianBirch/cljs-ajax

hmm,. I still do not see done

do you see anything in the browser Console window?

btw, you can test if you will see anything by just running (println "hello") and seeing if it shows up in the REPL or in the browser console window

nope, I see only this as last in the repl or browser console #object[Object [object Object]]

OK, try to run this: (enable-console-print!) and then test hello again

then I see something on the repl console

nice, so you can try running (get-forecast!) and seeing if DONE shows up

then I see : hello world nil

on the repl console

also this is a good time to mention: you can just always add (enable-console-print!) to your CLJS project (e.g. your main function) to make sure printing works as expected

nope

I see then only

cljs꞉learn-cljs.weather꞉> 
#object[Object [object Object]]

I have a sneaking suspicion, something may be going wrong with the request; let's add

:error-handler (fn [{:keys [status status-text]}] (println "error: " status " " status-text))

nothing changed

if I change app-state by a city I see output

a very very big json fie

ah, so it must have been returning a valid 200 response; but no data

https://gist.github.com/RoelofWobben/a4f3432be7a627c7a268490213de66e5

awesome; so that's our raw data

as long as you don't refresh the entire file, you can work and experiment on it without calling the API again

just by always derefing @raw-data

and I know that the dt is a unix time stamp

now I have to figure out which one I need

i need 1 and maybe 21

but to come back to my orginal question

can I then both do

(swap! app-state
           update-in [:temperatures :today :value] (constantly today))

but that means if I want to store 5 temps I also need 5 seperate places in my atom

not very good if I ever want to change it to for example show 21 temps

I'd take a step back and first consider the kind of data I want to parse; I'd probably start with this:

(map-indexed (fn [idx item] [idx (get item "dt_txt")]) (get @raw-data "list"))

that should easily tell you what the data distribution looks like (without the big JSON blob)

oke, and where schould I place that ?

just in a (comment ...) and eval it :)

under the second comment instead of @rawdata ?

anywhere after you define raw-data is fine

since it's in a comment field it won't be normally evaled, so think of it like your personal scratchpad for taking notes and thinking through the problem

then I see all normal dates instead of unix times

yeah, you can use "dt" if you prefer the epochs, but the normal dates seem nicer to work with

so you can answer questions like: how many items were returned and which one of these am I interested in?

there are 39 entries

it explains why originally index 0 and 8 was used; but then the question is which one of these makes sense for me now?

oke, in 4 hours from now it's 26-10-2021 0:14

so 9 or 10

9 is midnight and 10 is 3 o clock in the eveing

this is working in blocks of 3 hours so I think not the right api

erm, isn't it the second entry for midnight?

nope

[0 "2021-10-25 21:00:00"]
 [1 "2021-10-26 00:00:00"]
 [2 "2021-10-26 03:00:00"]
 [3 "2021-10-26 06:00:00"]
 [4 "2021-10-26 09:00:00"] 

and it's now 21:18

but to come back to my original question

if iI find the right api I can update the handler and I have solved this challenge according to you

yep, or perhaps the original intention was not to look for a different API but to answer the question: what is the prediction now and in roughly 3-4 hours (vs in 24 hours)

so no four entries to let see all temps of a period of 4 hours

but only 2

yeah, seems kind of a stretch since that hourly API seems to be behind a paywall

I can do a hourly one so over 4 hours with this one https://openweathermap.org/api/one-call-api

ah, ok

I have then a extra call to convert a zipcode to a lat and lon

see this page : https://openweathermap.org/api/one-call-api

OK, so one more thing I would mention before I leave you: it would be a shame to waste all this REPL potential to just go back to modifying state everywhere

so I recommend learning to develop code where you do an API call and store it somewhere temporarily, like we've done with @raw-data

but to make things challenging. to display all 4 with the knowledge I have to make 4 update-in

and not use a collection

next, write functions that take the value of that response and return new data

and then write a final function that calls swap! or update!

b/c those middle functions you can test interactively in the REPL without actually changing the app-state

oke, time to leave here almost time to sleep

> but to make things challenging. to display all 4 with the knowledge I have to make 4 update-in so how do you want to keep track of this?

perhaps:

:temperatures [{:timestamp "..." :value ...}
               {:timestamp "..." :value ...}]

I thought of this :

(defonce app-state (r/atom {:title "WhichWeather"          ;; <1>
                            :latitude 0
                            :longtitude 0
                            :temperatures {:current {:label "Current"
                                                   :value nil}
                                           :oneHour {:label "1 hour"
                                                     :value nil}

}}))

that's fine, but won't scale great if you want to store 4 or 20 hours

yep, I know

oke I have to use a list

or a map I think where I use the hour as key and the temp as value

if you want to go down that route, I'd probably do:

:temperatures {"timestamp": {:label "...", :value ...}
               "timestamp": {:label "...", :value ...}}

where timestamp can be that string timestamp or the integer epoch

yeah, or just hour as key and temp as value

all valid options

oke, but that means if I have twenty one I have add some 20 entries

but as I said time to sleep here

I fall almost at asleep behind the computer 😛

sure, but you would write a function that returns that entire datastructure; and then you need only one update!

oke

^ I meant swap!

OK, good night and good luck :)

first tommorow time to try to make it work with 2 entries and another api

where I can exactly use 4 hours

and you thanks for all the patience. We were very long busy to come to this point

I'm just glad we got your env setup; I hope it will pay off handsomely. Make sure to find some youtube videos where people talk about "REPL driven development" and you'll start to understand why Clojure developers are so keen on making sure your setup works :)

GN

sorry, I need your help one more time I have this respons

"hourly": [
    {
      "dt": 1618315200,
      "temp": 282.58,
      "feels_like": 280.4,
      "pressure": 1019,
      "humidity": 68,
      "dew_point": 276.98,
      "uvi": 1.4,
      "clouds": 19,
      "visibility": 306,
      "wind_speed": 4.12,
      "wind_deg": 296,
      "wind_gust": 7.33,
      "weather": [
        {
          "id": 801,
          "main": "Clouds",
          "description": "few clouds",
          "icon": "02d"
        }
      ],
      "pop": 0
    },

How do I change this

(map-indexed (fn [idx item] [idx (get item :dt)]) (get @raw-data :hourly))

hmm

I can do this (map-indexed (fn [idx item] [idx (get item "dt")]) (get @raw-data "hourly"))

but then I see all the dates in unix time

@U0EGWJE3E if I understand correctly, you don't get back "dt_txt" so you can't retrieve it from the map directly; but you can try converting the epoch time to an actual date if you want to make it more readable

yep, please

(js/Date. (* 1000 (get item "dt")))

that looks a lot better

([0 #inst "2021-10-26T06:00:00.000-00:00"]
 [1 #inst "2021-10-26T07:00:00.000-00:00"]
 [2 #inst "2021-10-26T08:00:00.000-00:00"]
 [3 #inst "2021-10-26T09:00:00.000-00:00"]
 [4 #inst "2021-10-26T10:00:00.000-00:00"]
 [5 #inst "2021-10-26T11:00:00.000-00:00"]
 [6 #inst "2021-10-26T12:00:00.000-00:00"]
 [7 #inst "2021-10-26T13:00:00.000-00:00"]
 [8 #inst "2021-10-26T14:00:00.000-00:00"]
 [9 #inst "2021-10-26T15:00:00.000-00:00"]

So I need now 2 and 6 because it is now 8.13 here

No, I think the API is returning time in UTC

pfff

(it's 6:14 now in UTC time; you're in a +2 timezone)

then I need 1 and 5 🙂

got to run; good luck, but feel free to post questions here (or on #beginners)

cheers!

BTW, if you haven't tried it yet; try running Calva: Fire up the "Getting Started" REPL in vscode - there are a couple of files that give you good hints on how to use calva, paredit, rich comments, etc

I tried

I use calva also on solving exercism challenges

and there's also this - https://github.com/PEZ/rich4clojure

anywho, I'm off for a while ☕

and im back from sport

I personally like them as I find them substantially more readable, though my experience has been that this isn’t considered idiomatic.

Though now I think about it, what exactly do you mean by “vertical alignment”? I was envisaging something like this:

{
  :first-key            "first value"
  :second-key           "second value"
  :key-with-a-long-name "this is a longer value"
}

(I’ve heard this referred to as “tabular alignment” elsewhere, fwiw)

@U0MDMDYR3 yep, that's what I meant.

Cool. Ok then I like it and also use it in let forms etc.

But then as a solo programmer these days I don’t have to worry so much about conforming to the herd’s opinions on things like this. 😉 If I were still working in a team I’d line up with whatever the team’s standards are, however.

Some people drink tea, others coffee; some put milk in their tea while others consider that disgusting. If we can't get people to agree on that, what hope is there for non-enforceable vertical alignment? :) I'm a fan, but I would never put milk in my tea.

@U05476190 without ratholing, I’m an equal opportunity hot beverage enjoyer - I’ll drink (and enjoy) any/all of the above, depending on my mood. 😉

Just no sugar. Sugar is the devil. 😉

Yes, true. I've also wished for a semantic git diff 🙂

with git, I typically use --word-diff=color when looking at diffs, which often helps

Looks like using a ,) is quite popular.

I've found some linters and prettifiers remove the comma; but none touch my #__

I use #_()

Oh wow, I thought it would be a lisp-specific thing but it even supports languages with actual syntax. That's crazy

Yep, pretty cool. Thanks for the link.

That's what I was looking for 🙂

When you use the :keys shortcut for binding names that are keys, what exactly does that mean? For instance, does that mean anything that's a key gets bound to the same name without the :? a = (:a my-map) b = (:b my-map) etc?

(let [{:keys [foo bar]} {:foo "hello" :bar "world"}]
  (str foo ", " bar))
==> "hello, world"

I'm not saying it's good or bad. I'm only trying to understand an example.

Right, I just like to bring this up as context, since this is #beginners. Sometimes when I'm just starting out, I have trouble knowing what's "this is how we do things" and what's just "here's a cool feature that you may not use very often but it's good to know anyway."

Absolutely makes sense. On the one hand I appreciate the mathematical brilliance of it. On the other hand, too many layers get unreadable very quickly.

He did: https://stuartsierra.com/2018/07/15/clojure-donts-thread-as

> Outside of ->, the arguments to as-> appear in the order value name rather than name value, making it unlike anything else in Clojure. > Therefore, I can confidently say one should never use as-> by itself,

i don't buy it

as-> was specifically designed to work inside -> pipelines.

That's what Rich said about it on the mailing list when it was originally introduced (years ago now).

(-> thing
    (process)
    (as-> sym
          (do-stuff :to sym 42))
    (more-processing))

I get that. But I don’t see how that gives any evidence to it’s wrong to use it outside of a threading context

To me it seems to fit it’s original purpose and others just fine

I'm tired of arguing with people about this.

Using as-> on its own is just wrong.

I didn’t mean to be contentiousness

Go search the mailing list for Rich's discussion about it, when it was introduced.

I wish they'd put this in the bloody docstring so folks wouldn't keep arguing about it 😞

I was curious about this. I think I found the mailing list conversation in question: https://groups.google.com/g/clojure/c/67JQ7xSUOM4/m/AoxwLmfDJNwJ

It does explain the purpose of the macro as being insertion into a more conventional threading pipeline. It does not give a substantive reason that other uses would be wrong.

first a want the literal 2r1010101 , then I'll convert that to decimal

that is a format that can be read, but nothing ever prints that way as a literal

(Long/parseLong (apply str bits) 2) will give you the decimal integer

thank you!

you can use (Long/toBinaryString 85) to get "1010101"

(read-string (str "2r" (apply str bits))) would be another approach (but this is really doing more steps to do the same thing above)